1763825 - [New users] The “about:welcome” slides are cut off when the browser is horizontally resized to 25%

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: onboardingNewUsers_browserResize.gif

[Affected versions]:

• Firefox Nightly 101.0a1 (Build ID: 20220408094506)
• Firefox Beta 100.0b3 (Build ID: 20220407185832)

[Affected Platforms]:

• Mac 11.6
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest Firefox Nightly/Beta 100 browser installed.
• Have a new Firefox profile.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Resize the browser to 25% of its width.
3. Navigate through all the slides from the “about:welcome” page.
4. Observe the slides.

[Expected result]:

• The slides are visible and correctly rendered.

[Actual result]:

• The slides are not fully visible and the “Alpenglow” theme text from the “Themes” slide is cut off.

[Notes]:

• Attached is a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1763825 - Handle about:welcome and spotlight dialog display for shorter screen width

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4610b9c86ea0
Handle about:welcome and spotlight dialog display for shorter screen width r=Mardak,emcminn

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing node failures

• backout: https://hg.mozilla.org/integration/autoland/rev/9dc13b7777c5ffc1617e6da70431f867096ff3bc
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=4610b9c86ea0ffff8dfec8d25271ce8e55f9c7d7&selectedTaskRun=LrkTTAhXRe28R8izdyZUug.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=375334805&repo=autoland&lineNumber=450

[task 2022-04-21T16:54:25.454Z] TEST START | sasslint
[task 2022-04-21T16:54:27.001Z] TEST-UNEXPECTED-FAIL sasslint | content-src/aboutwelcome/aboutwelcome.scss(1399, 3): Attribute-selector should be nested within its parent Class (force-attribute-nesting)
[task 2022-04-21T16:54:27.001Z] TEST-UNEXPECTED-FAIL sasslint | content-src/aboutwelcome/aboutwelcome.scss(1399, 15): Attribute values should be surrounded by quotes (attribute-quotes)
[task 2022-04-21T16:54:27.003Z] {
[task 2022-04-21T16:54:27.003Z]   checkBundles: true,
[task 2022-04-21T16:54:27.003Z]   karma: true,
[task 2022-04-21T16:54:27.003Z]   zipCodeCoverage: true,
[task 2022-04-21T16:54:27.003Z]   sasslint: false
[task 2022-04-21T16:54:27.003Z] }
[task 2022-04-21T16:54:27.003Z] CODE 1
[taskcluster 2022-04-21 16:54:27.510Z] === Task Finished ===
[taskcluster 2022-04-21 16:54:27.511Z] Unsuccessful task run with exit code: 1 completed in 812.07 seconds

Comment 4

[Punam Dahiya [:pdahiya]]

Updated patch with sass lint fixes thanks

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f97cd0f1adb4df09d9869727a0ed42eaeaf8e10a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49180e5cea92
Handle about:welcome and spotlight dialog display for shorter screen width r=Mardak,emcminn

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/49180e5cea92

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pdahiya, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Punam Dahiya [:pdahiya]]

Fix is not required to uplift into Fx100 and will ride the train

Comment 9

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified that this issue is no longer reproducible using the latest Firefox Nightly 102.0a1 (build ID: 20220503190534) and Firefox Beta 101.0b2 (Build ID: 20220503185929) on Windows 10 x64, macOS 12.3.1, and Ubuntu 20.04 x64.

• The "about:welcome" page can be scrolled horizontally and vertically, and its slides are entirely visible when the browser is resized to 25%.