1767811 - Ship a v100.2.1 out-of-band update to Firefox 100

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, defect, P1)

Description

[Dennis Schubert [:denschub]]

Let's relieve some of the pressure for our users by shipping another batch of UA-Version-99 caps to Firefox release.

Comment 1

[Dennis Schubert [:denschub]]

Just for the record, :flod tested a try build based on release with the UA cap applied to Commerzbank properties, and confirmed this works.

Comment 2

[Dennis Schubert [:denschub]]

Attachment: GitHub Pull Request

Comment 3

[Dennis Schubert [:denschub]]

I've included one additional bug with UA99 caps that has not yet reached Firefox 100 Release (bug 1765925). These are in Beta 101 at the moment, but if we're shipping an update anyway, there is no harm in including those.

Edit: actually, only one. The second patch had additional changes.

Comment 4

[Dennis Schubert [:denschub]]

Attachment: Bug 1767811 - Release - Add additional domains to the Version 99 UA cap.

Comment 5

[Dennis Schubert [:denschub]]

Oana and Raul, could you please test the candidate for this update for me?

The following test steps have to be done in an unbranded Firefox release build. You can find the correct binaries (from this build):

• Linux: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Zcgsq8OlR7i-RnTVwweoSg/runs/0/artifacts/public/build/target.tar.bz2
• macOS: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/XoQPypozRgexEvECAcR2Xw/runs/0/artifacts/public/build/target.dmg
• Windows: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/So53o9GzTgaJA_nqhfYhTQ/runs/0/artifacts/public/build/target.zip

Testing steps:

1. In the aforementioned unbranded build, go to about:support, and verify that the "Web Compatibility Interventions" entry in "Nightly Features" shows version number 100.2.0.
2. Open about:config, create a new boolean pref named xpinstall.signatures.dev-root and set it to true.
3. Open this link to an .xpi in that build. It should ask you to install an addon, and the installation should succeed.
4. Open about:support again. The "Web Compatibility Interventions" entry should now be in the "Add-ons" section, and it should show the version number 100.2.1buildid20220504.194401.
5. Open the addon testbed and verify that the top four tests are green.
6. Verify that the new UA overrides work as expected:
   • On https://www.commerzbank.de/, open the DevTools console and verify that navigator.userAgent returns a User Agent string with version 99, not 100.
   • WebCompat Issue #102376 should no longer reproduce.
   • WebCompat Issue #102367 should no longer reproduce.
   • WebCompat Issue #102103 should no longer reproduce.
7. Restart Firefox, keep using the same profile.
8. After a restart, verify that about:support still shows the version number 100.2.1buildid20220504.194401, and verify that the addon testbed still shows the first four squares green.

Thank you very much!

Comment 6

[Oana Arbuzov [:oanaarbuzov]]

Dennis, we've performed the tests as requested, and below are the results:

Windows 10 Pro Test:
https://www.commerzbank.de/ - displays User-Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0
https://github.com/webcompat/web-bugs/issues/102103 - not reproducible
https://github.com/webcompat/web-bugs/issues/102367 - not reproducible
https://github.com/webcompat/web-bugs/issues/102376 - not reproducible

Linux 20.04.2 Test:
https://www.commerzbank.de/ - displays Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Firefox/99.0
https://github.com/webcompat/web-bugs/issues/102103 - not reproducible
https://github.com/webcompat/web-bugs/issues/102367 - not reproducible
https://github.com/webcompat/web-bugs/issues/102376 - not reproducible

macOS 10.15.7 Test:
https://www.commerzbank.de/ - displays Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:99.0) Gecko/20100101 Firefox/99.0
https://github.com/webcompat/web-bugs/issues/102103 - not reproducible
https://github.com/webcompat/web-bugs/issues/102367 - not reproducible
https://github.com/webcompat/web-bugs/issues/102376 - not reproducible

**Note: **
On Firefox Nightly v.102 and Firefox Beta v.101 on Windows, Linux and Mac the issues: 102103, 102367 and 102376 are not reproducible.
On Firefox Release v.100 on Windows, Linux and Mac the issues: 102103 - is not reproducible, 102367 and 102376 - are reproducible.

Comment 7

[Dennis Schubert [:denschub]]

Thanks for testing!

The notes about the three Web-Bugs working in Nightly and Beta are expected - these are interventions that we already ship to Nightly and Beta, and I'm just "uplifting" those into the release as well. They're low-risk patches, and there is no harm in fixing more issues for our users if we roll out an update anyway.

Issue 102103 is an interesting case. It looks like the site has deployed a fix some time between me testing this intervention and now. We have not yet removed the interventions yet because we didn't know that. This is a bit unfortunate, but not a blocker: the intervention doesn't do any harm to the site, it just sees Firefox 99 instead of 100. Instead of removing that intervention and starting the whole testing cycle again, let's stick with it for the sake of time. I filed bug 1767951, which will make sure to remove this specific intervention in our next planned release for Firefox 102.

Comment 8

[Dennis Schubert [:denschub]]

Attachment: Bug 1767811 - Import WebCompat addon 101.4.0 sources.

Comment 9

[Dennis Schubert [:denschub]]

Raul and Oana, I have a final round of testing for you, this time with the real addon-update in the real Firefox Release version. The steps below are only testing a single intervention - the Commerzbank one. That's fine: if one works, the others work as well - the addon you're testing is exactly the same binary, just signed with a different signature.

1. In a unmodified Firefox Release and a fresh profile, confirm that on about:support, in the Firefox Features section, it shows Web Compatibility Interventions with Version 100.2.0.
2. On https://www.commerzbank.de/, open the DevTools console and verify that navigator.userAgent returns a User Agent string with version 100.
3. In DevTools, open the Settings via the Three-Dot-Menu -> Settings. In there, enable the checkbox Enable browser chrome and add-on debugging toolboxes.
4. Verify you see an entry with [e-mail]-100.2.1[...]signed.xpi at this URL.
5. Change the update channel to release-sysaddon in the channel-prefs.js file inside the Firefox directory:
   • on Linux, this file should be at defaults/pref/channel-prefs.js relative to the directory where the Firefox binary is
   • on macOS the file should be at /Applications/Firefox.app/Contents/Resources/defaults/pref/channel-prefs.js
   • on Windows, this file should be at C:\Program Files\Mozilla Firefox\defaults\pref\channel-prefs.js
6. Restart Firefox, using the same profile as before.
7. Open the Firefox Browser Console:
   • on Linux and Windows, press Ctrl+Shift+J to open it
   • on macOS, it's Cmd+Shift+J
8. In that new console, run Components.utils.import("resource://gre/modules/AddonManager.jsm"); AddonManagerPrivate.backgroundUpdateCheck();
9. You won't see any progress, the update happens in the background. Wait 30 seconds, just to make sure Firefox has enough time to download and apply all updates.
10. On about:support, confirm that the Web Compatibility Interventions version number is now 100.2.1buildid20220504.194401.
11. On https://www.commerzbank.de/ again, open the DevTools console and verify that navigator.userAgent now returns a User Agent string with version 99.
12. Restart Firefox
13. Verify that the version number still matches what's expected in step 10.

Comment 10

[Dennis Schubert [:denschub]]

While our QA friends are doing their magic, I'll land the new intervention (Commerzbank) and the removal (Twitch) in Nightly as well, so this can be uplifted into Beta eventually.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/281bc0a6d45b
Import WebCompat addon 101.4.0 sources. r=webcompat-reviewers,twisniewski

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/281bc0a6d45b

Comment 13

[Oana Arbuzov [:oanaarbuzov]]

Dennis, we've tested again based on comment 9 and everything works as expected.

Tested with:
Browser / Version: Firefox Release 100.0
Operating System: Windows 10 Pro, Ubuntu 20.04.2, macOS 10.15.7

Comment 14

[Dennis Schubert [:denschub]]

Thank you both.

Comment 15

[Dennis Schubert [:denschub]]

Dianna, as announced per Slack, we're intending to ship an update to the WebCompat Interventions Add-on, Version 100.2.1, directly to Release users. We're done with our QA, and are now requesting your sign-off to have the update go live.

The update includes changes to a list of domains where we cap the version number in the User Agent string to 99:

• We added Commerzbank, a large German bank, where logging into the online banking system is broken due to broken user agent sniffing,
• Three other cases where we've seen reports about "your browser is not supported" banners showing in Firefox 100+,
• It removes the Version 99 cap from Twitch: they have deployed a change that makes this redundant.

This patch shows what's changing in the update.

Risk wise, this is as low as it can get for us: It doesn't add any new code or logic, it just extends a list of domains for an already shipped intervention. Since this specific intervention is already in Release, we know it works, so I have no doubts this update will work as well.

The release should be prepared in Balrog and ready for you to push the button. I'm personally comfortable with the kick-off happening on a Friday, but if you'd like to wait until Monday, that's fine for us, too.

Comment 16

[Dianna Smith [:diannaS]]

Thank you for the summary. This has been signed off on Balrog. I feel the risk is very low and there is no need to wait until Monday.

Comment 17

[Dennis Schubert [:denschub]]

The update is now live on the release channel.

I've created a telemetry query to keep an eye on the rollout: https://sql.telemetry.mozilla.org/queries/85734#212283 (this link is Mozilla-internal). Keep in mind that this query needs to be executed manually to refresh the data, and also that there is ~1 day of latency in the data.

Comment 18

[Dennis Schubert [:denschub]]

Attachment: Bug 1767811 - Beta - Import Hotfix changes into beta. r?twisniewski!

Comment 19

[Dennis Schubert [:denschub]]

Comment on attachment 9275544 [details]
Bug 1767811 - Beta - Import Hotfix changes into beta. r?twisniewski!

Beta/Release Uplift Approval Request

• User impact if declined: UA version-number parsing related issues mentioned in this bug, most significantly login issues into the online banking of a German bank.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes are already shipping in Nightly, and we're rolling out a System Addon Update as well. The reasons of why this is low-risk are explained in comment 15.
• String changes made/needed:
• Is Android affected?: No

Comment 20

[Dennis Schubert [:denschub]]

Comment on attachment 9275037 [details]
Bug 1767811 - Release - Add additional domains to the Version 99 UA cap.

Beta/Release Uplift Approval Request

• User impact if declined: The changes are rolling out in a System Addon Update. Uplifting it into whatever dot-release comes next is a good idea to make sure new profiles get the fixes directly without having to wait for the background update.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Changes are already shipping to Firefox 100 release out-of-band. For this patches risk in general, see comment 15.
• String changes made/needed:
• Is Android affected?: No

Comment 21

[Dennis Schubert [:denschub]]

(Setting tracking flags according to the Nightly merge in comment 12 and the system addon rollout for 100.*)

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9275544 [details]
Bug 1767811 - Beta - Import Hotfix changes into beta. r?twisniewski!

Approved for 101.0b4.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2b8e9c49eacf

Comment 24

[Dianna Smith [:diannaS]]

Comment on attachment 9275037 [details]
Bug 1767811 - Release - Add additional domains to the Version 99 UA cap.

Approved for 100.0.1

Comment 25

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/679896767af2

Comment 26

[Dennis Schubert [:denschub]]

The update rollout is at >95%, and a dot-release is just around the corner. This is also shipping in Beta and Nightly. I'll consider this done now!