1767825 - -options and -addressbook commandline arguments not working as expected

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Rob Lemley [:rjl]]

-options doesn't seem to work at all. I think it's trying to open preferences.xhtml in a new window as I see a preferences.xhtml show up in devtools' window selection dropdown. It should open a settings tab in an existing window or open a window. "options" should also be renamed to "settings" so it's consistent with the menus

-addressbook opens the old addressbook in a new window. It should open the new addressbook in a tab, or open an existing addressbook tab

Comment 1

[Wayne Mery (:wsmwk)]

Alice, mozregression tool can handle command line arguments, correct?

Comment 2

[Thomas D. (:thomas8)]

Thanks Rob for finding and filing this!

(In reply to Rob Lemley [:rjl] from comment #0)

-options doesn't seem to work at all. I think it's trying to open preferences.xhtml in a new window as I see a preferences.xhtml show up in devtools' window selection dropdown. It should open a settings tab in an existing window or open a window.

Do we always need to show the 3-pane when we go directly for specific spaces from command line?
From past experience, I would expect command line options to open directly and only what is specified in the command line option. I don't care if it's shown as a tab or not (with or without a tab header), but I'd probably prefer the thing to open on its own without the clutter and resource-eating overhead of 3-pane.

"options" should also be renamed to "settings" so it's consistent with the menus

Having -settings switch sounds good. Some minor questions, no strong feelings:

• Do we want to do this and be different from Firefox (assuming they haven't changed it)?
• Do we really want to change this age-old switch?
• Maybe we could just support -settings in addition to -options?

-addressbook opens the old addressbook in a new window. It should open the new addressbook in a tab, or open an existing addressbook tab

Not sure if things started from command line parameter should open existing tabs? Why would you use command line when TB is already open in the first place?

Comment 3

[Alessandro Castellani [:aleca]]

Do we always need to show the 3-pane when we go directly for specific spaces from command line?

Yes we do. This is a limitation of our architecture.
With Geoff we're looking into allowing tabs to be opened as windows, but that will probably happen later in the 114 cycle.

Comment 4

[Rob Lemley [:rjl]]

Firefox uses "--preferences" to open either the "Options Page" on Windows or "Preferences Page" on other platforms. They're inconsistent with their own menus as well. It opens a new browser window every time.

This bug isn't necessarily about how these arguments work, it's that they don't work at all currently.

Comment 5

[Alice0775 White]

• Regarding -options

#1 Regression window(The size of the options window is small and not resizable. And the content is empty except sidebar menus and searchbar):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=376d4a7f56f68beed993e202b2cec4a0e9a7857c&tochange=9dc474fda8ab3c2c8ada0a53c88c118c6d5d6de5
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=921a30cac33b6d0760f318b6f1a2e3ce1bd687cc&tochange=adc328596e28636b03fabe701ec6a4d07054e5af

#2 Regression window(The options window shows window caption bar only):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=e37008cded8439c5a61f2b15c4ffa1f9bb7e7d5d&tochange=03ce934778499b4c043321dd217e88f2935dcfdfhttps://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=509cb523d4f7fb0d57adab93f74efdeae3897560&tochange=8a78072a547d759082a7173924f28886defc5594

• Regarding -addressbook
  Did the address book have ever worked as expected?

Comment 6

[Rob Lemley [:rjl]]

I'm not sure when this started working, but both -options and -addressbook work as expected on 102.0.3 (win64) and 102.1.0 (linux64).