1767916 - [wayland] Firefox aborts on fedora 36 when resizing to second display with scale factor 2: "Buffer size (1568x1501) must be an integer multiple of the buffer_scale (2)"

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jan Horak [:jhorak]]

1. have at least two monitor setup, first monitor with scale factor 1, second with scale factor 2. open firefox window on first monitor
2. resize or move window to the second monitor.
3. crash occurs with following message:

[1720618.985] [e-mail](wl_surface@48, 2, "Buffer size (1568x1501) must be an integer multiple of the buffer_scale (2)")

It's race condition crash and seems to be caused by the Renderer thread. It sets the wl_surface buffer_scale to 2 in moz_container_wayland_set_scale_factor_locked but the attached buffer has not yet been resized to double size - which happens on the main thread.

Crash occurs on Fedora 36.

Comment 1

[Jan Horak [:jhorak]]

Attachment: Bug 1767916 Clear the attached wl_buffer from wl_surface before scale factor change;r=stransky

The wl_buffer can be still not resized to double size when the Renderer thread changes
the wl_surface buffer scale to 2 which leads to crash.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71a84ed06b13
Clear the attached wl_buffer from wl_surface before scale factor change;r=stransky

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/71a84ed06b13

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9275131 [details]
Bug 1767916 Clear the attached wl_buffer from wl_surface before scale factor change;r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: Crashes on Wayland when laptop is restored from sleep or multi-monitor system is used.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple patch, removes attached buffer from wl_surface when we change scale which leads to screen clear.
• String changes made/needed: none
• Is Android affected?: No

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9275131 [details]
Bug 1767916 Clear the attached wl_buffer from wl_surface before scale factor change;r=stransky

Approved for 101.0b6.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a0693a8029d3