Closed Bug 1767942 Opened 2 months ago Closed 2 months ago

Multiple OpenPGP keys in a single email attachment should be processed separately

Categories

(MailNews Core :: Security: OpenPGP, defect)

defect

Tracking

(thunderbird_esr91 affected, thunderbird101 fixed)

RESOLVED FIXED
102 Branch
Tracking Status
thunderbird_esr91 --- affected
thunderbird101 --- fixed

People

(Reporter: KaiE, Assigned: KaiE)

References

Details

Attachments

(1 file)

When processing email attachments that contain OpenPGP keys, we obtain a list of the included keys (for each attachment separately), and individually decide which keys we want to auto-update.

However, if we decide to update, we import the full block of key data. This means, if there are additional keys, those will be imported, too.

This could be abused by a sender to automatically inject keys into the user's permanent key store.

Assignee: nobody → kaie
Attachment #9275150 - Attachment description: WIP: Bug 1767942 - Process arriving OpenPGP keys separately. → Bug 1767942 - Process arriving OpenPGP keys separately. r=mkmelin
Status: NEW → ASSIGNED

Note sure whether TB already uses this feature, but RNP API has flag RNP_LOAD_SAVE_SINGLE for rnp_import_keys(), which would allow to import first key with subkeys and return it's fingerprint(s) and import status.

Nickolay, thanks for the info, it's good to know. I think it doesn't help in this scenario, because we want to load all keys and process all of them just separately. I can import, then extract individually.

(In reply to Kai Engert (:KaiE:) from comment #0)

However, if we decide to update, we import the full block of key data. This means, if there are additional keys, those will be imported, too.

Luckily I was wrong, and we're safe.

We don't import the attached key block completely.
The import call filters by fingerprint, and will only import the one key we want.

Nevertheless, we still need the patch here, because for CollectedKeysDB we should only store the single key.

Group: mail-core-security
Blocks: 1767945
Target Milestone: --- → 102 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/e1dba725238f
Process arriving OpenPGP keys separately. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED

Comment on attachment 9275150 [details]
Bug 1767942 - Process arriving OpenPGP keys separately. r=mkmelin

I'd like to have beta testing of this code.

Attachment #9275150 - Flags: approval-comm-beta?

Comment on attachment 9275150 [details]
Bug 1767942 - Process arriving OpenPGP keys separately. r=mkmelin

[Triage Comment]
Approved for beta

Attachment #9275150 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.