Failure to import OpenPGP key from autocrypt-only email
Categories
(MailNews Core :: Security: OpenPGP, defect)
Tracking
(thunderbird_esr102 unaffected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr102 | --- | unaffected |
People
(Reporter: KaiE, Assigned: KaiE)
References
Details
(Keywords: regression)
Attachments
(1 file)
If an email contains an OpenPGP key in an autocrypt header, but no key attachment is present, we fail to process/import the key.
This is a regression in version 102, introduced by bug 1767942.
Because that code changed how we obtain the public key for importing
(using RNP.getOnePubKeyFromKeyBlock instead of using the keyData parameter)
calling RNP.enArmorString is wrong, because we already have a key in the correct format, and calling enArmorString produces an incorrect double-base64-encoded parameter.
|
Assignee | |
Comment 1•3 years ago
|
||
No, I was wrong about the cause of the regression, I cannot reproduce on 102.
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
This patch fixes my test scenario from bug 1688495.
I don't understand yet why the patch isn't necessary on comm-esr102.
|
||
Updated•3 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/93f4f24667b2
Remove unnecessary call to RNP.enArmorString. r=mkmelin
Description
•