1768050 - Move all OPFS operations other than getting the root off PBackground

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

We can't do database opens/operations or obtain fd's on PBackground; they need to be done on another thread/TaskQueue.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1768050: Move OPFS operations off PBackground r=nika,jari,janv,#dom-storage-reviewers,#ipc-reviewers

Comment 2

[Jari Jalkanen [:jari]]

Attachment: Bug 1768050: Move OPFS operations off PBackground r=jari,janv,#dom-storage-reviewers,#ipc-reviewers

This is copy and refactoring of https://phabricator.services.mozilla.com/D145643
for the purpose of resolving conflicts in the OPFS patch stack.
It can be merged or abandoned in favor of the original patch D145643.

Comment 3

[Jari Jalkanen [:jari]]

Attachment: WIP: Bug 1768050: Move OPFS operations off PBackground.

This is copy and refactoring of https://phabricator.services.mozilla.com/D145643
for the purpose of resolving conflicts in the OPFS patch stack.
It can be merged or abandoned in favor of the original patch D145643.

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1768050 - Move OPFS operations off PBackground - fixes; r=#dom-storage

This patch is intended to be folded into D147273.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1768050: Cache OPFS IPC channels by nsIGlobalObject to allow reuse r=#dom-storage-reviewers,nika

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1768050: Factor out connection creation for OPFS so we can reuse it for PostMessage r=#dom-storage-reviewers

Comment 7

[Jari Jalkanen [:jari]]

Attachment: Bug 1768050: Test request handler. r=jesup,janv,#dom-storage-reviewers

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP: Bug 1768050: Cache OPFS IPC channels by nsIGlobalObject to allow reuse r=#dom-storage-reviewers,nika

Depends on D148318

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3c7a9041511
Move OPFS operations off PBackground r=janv,nika
https://hg.mozilla.org/integration/autoland/rev/52f54c3384db
Test request handler. r=jesup

Comment 10

[Atila Butkovits]

Backed out for causing gtest failures complaining about function calls.

Backout link: https://hg.mozilla.org/integration/autoland/rev/ea37b71a386060ca606af80a1e374e77967bbcc4

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=a-9iEsudRn2ray5X1XvK2A.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=52f54c3384dbc750537074764ee3044e465f18cd

Failure log: https://treeherder.mozilla.org/logviewer?job_id=383530933&repo=autoland&lineNumber=6557

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3297ee78ba17
Move OPFS operations off PBackground r=janv,nika
https://hg.mozilla.org/integration/autoland/rev/57d24405f8e1
Test request handler. r=jesup

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3297ee78ba17
https://hg.mozilla.org/mozilla-central/rev/57d24405f8e1

Comment 13

[Phabricator Automation]

Comment on attachment 9281218 [details]
Bug 1768050: Cache OPFS IPC channels by nsIGlobalObject to allow reuse r=#dom-storage-reviewers,nika

Revision D149262 was moved to bug 1789696. Setting attachment 9281218 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9281219 [details]
Bug 1768050: Factor out connection creation for OPFS so we can reuse it for PostMessage r=#dom-storage-reviewers

Revision D149263 was moved to bug 1789696. Setting attachment 9281219 [details] to obsolete.

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

Moved remaining patches to a new bug