1761370 - Unshared FilesystemSyncAccessHandle r/w test implementation

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

Provide an initial working read/write FilesystemSyncAccessHandle implementation for use in Workers, in dom/fs/FileSystemSyncAccessHandle.cpp

See for example https://github.com/WICG/file-system-access/blob/main/AccessHandle.md

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1761370: Add SyncAccessHandles to OPFS r=janv,jari,asuth,#dom-storage-reviewers

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1761370: Add HashMap of OPFS Parents for use in locking and cleanup r=#dom-storage-reviewers,jari,janv

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1761370: Add locking across multiple connections in OPFS r=#dom-storage-reviewers,jari,janv

Depends on D145649

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1761370: Add support for getFile() to FileSystemHandles in OPFS r=#dom-storage-reviewers,janv

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

We'll need to block pages using OPFS from the BFCache (https://github.com/whatwg/fs/issues/17)

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1761370 - Add locking across multiple connections in OPFS - fixes; r=#dom-storage

This patch fixes a compilation error and is intended to be folded into D145791.

Comment 7

[Phabricator Automation]

Comment on attachment 9277616 [details]
Bug 1761370: Add support for getFile() to FileSystemHandles in OPFS r=#dom-storage-reviewers,janv

Revision D146986 was moved to bug 1761089. Setting attachment 9277616 [details] to obsolete.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1761370: Use a single TaskQueue per origin for OPFS r=#dom-storage-reviewers,janv

Depends on D145649

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1761370: Fixes for Add SyncAccessHandles patch r=janv,jari,asuth,#dom-storage-reviewers

This is meant to be merged into D148267 "Add SyncAccessHandles to OPFS"

Comment 10

[Jan Varga [:janv]]

Attachment: Bug 1761370 - Add IsValidName() for OPFS r=#dom-storage

Comment 11

[Jan Varga [:janv]]

Attachment: Bug 1761370 - Make sure we are on correct thread when handling messages from the child; r=#dom-storage

Comment 12

[Jan Varga [:janv]]

Attachment: Bug 1761370 - Add [Throws] annotation for `read` and `write` in FileSystemSyncAccessHandle; r=#dom-storage

Comment 13

[Jan Varga [:janv]]

Attachment: Bug 1761370 - Change FileSystemSyncAccessHandle to inherit from FileSystemHandle; r=#dom-storage

Depends on D156685

Comment 14

[Jan Varga [:janv]]

Attachment: Bug 1761370 - Rework SyncAccessHandle implementation to use a sub protocol; r=#dom-storage

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2071b21f532
Add IsValidName() for OPFS r=janv
https://hg.mozilla.org/integration/autoland/rev/a1923876b4df
Make sure we are on correct thread when handling messages from the child; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/aa682026c2d5
Add [Throws] annotation for `read` and `write` in FileSystemSyncAccessHandle; r=dom-storage-reviewers,janv,smaug
https://hg.mozilla.org/integration/autoland/rev/7c1a069706de
Add SyncAccessHandles to OPFS r=dom-storage-reviewers,jari,janv

Comment 16

[Sandor Molnar[:smolnar]]

Backed out for causing multiple lint failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/292d43f4f4d259a83975b0a6ea2ffee2f473b5e2

Push with failures

Failure log ESlint

Failure log py black

Failure log mozlint wpt

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8b472462d48
Add IsValidName() for OPFS r=janv
https://hg.mozilla.org/integration/autoland/rev/9b1cb4b7d5e2
Make sure we are on correct thread when handling messages from the child; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/c4555c4937a9
Add [Throws] annotation for `read` and `write` in FileSystemSyncAccessHandle; r=dom-storage-reviewers,janv,smaug
https://hg.mozilla.org/integration/autoland/rev/4eedec454db1
Add SyncAccessHandles to OPFS r=dom-storage-reviewers,jari,janv

Comment 18

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing wpt failures . CLOSED TREE
Backout link
Push with failures
Link to failure log 1
Link to failure log 2
Failure line 1 : TEST-UNEXPECTED-FAIL | /fs/FileSystemDirectoryHandle-removeEntry.https.any.worker.html | removeEntry() while the file has an open writable fails - promise_test: Unhandled rejection with value: object "TypeError: navigator.storage.getDirectory is not a function"
Failure line 2 : TEST-UNEXPECTED-FAIL | /fs/FileSystemDirectoryHandle-removeEntry.https.any.html | removeEntry() while the file has an open writable fails - promise_test: Unhandled rejection with value: object "TypeError: navigator.storage.getDirectory is not a function"

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bb8c4b1614e
Add IsValidName() for OPFS r=janv
https://hg.mozilla.org/integration/autoland/rev/1193594d1bb1
Make sure we are on correct thread when handling messages from the child; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/4058c1a74e18
Add [Throws] annotation for `read` and `write` in FileSystemSyncAccessHandle; r=dom-storage-reviewers,janv,smaug
https://hg.mozilla.org/integration/autoland/rev/249ebf125b3f
Add SyncAccessHandles to OPFS r=dom-storage-reviewers,jari,janv

Comment 20

[Norisz Fay [:noriszfay]]

Backed out for causing FileSystem related wpt failures

Backout link

Push with failures

Failure log

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/473e3fe83dc9
Add IsValidName() for OPFS r=janv
https://hg.mozilla.org/integration/autoland/rev/b25dd706fa23
Make sure we are on correct thread when handling messages from the child; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/dbbf940538fa
Add [Throws] annotation for `read` and `write` in FileSystemSyncAccessHandle; r=dom-storage-reviewers,janv,smaug
https://hg.mozilla.org/integration/autoland/rev/ee048ee96921
Add SyncAccessHandles to OPFS r=dom-storage-reviewers,jari,janv

Comment 23

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/473e3fe83dc9
https://hg.mozilla.org/mozilla-central/rev/b25dd706fa23
https://hg.mozilla.org/mozilla-central/rev/dbbf940538fa
https://hg.mozilla.org/mozilla-central/rev/ee048ee96921

Comment 24

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1761370: Fix path pairs passed to OPFS GetFile() operations r=#dom-storage-reviewers

Comment 25

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4af7cf703dfa

Comment 26

[Jan Varga [:janv]]

Attachment: Bug 1761370 - Fix bad formatting in FileSystemManagerParent::RecvGetAccessHandle and FileSystemManagerParent::RecvGetFile; r=#dom-storage

Comment 27

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54d92679d430
Fix bad formatting in FileSystemManagerParent::RecvGetAccessHandle and FileSystemManagerParent::RecvGetFile; r=dom-storage-reviewers,jesup

Comment 29

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/54d92679d430

Comment 30

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36034 for changes under testing/web-platform/tests

Comment 31

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging