1768241 - [wayland] Blank webextension popups.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: image.png

See screenshots. Mozregression says this was caused by bug 1765399, Markus can you take a look?

Comment 1

[Markus Stange [:mstange]]

Will look.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1765399

Comment 3

[Emilio Cobos Álvarez (:emilio)]

For the record in case it's useful, the commit that broke this is https://hg.mozilla.org/mozilla-central/rev/22b568631834e556ab8351ac8458d5b24aa638bd according to git bisect.

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1768241 - Fall back to the global vsync dispatcher when we're on Wayland and there's no widget-local dispatcher. r=jrmuizel

This is fixing an oversight in a patch that was supposed to be functionally neutral.
https://hg.mozilla.org/mozilla-central/rev/22b568631834e556ab8351ac8458d5b24aa638bd#l1.49

The old code always called UpdateVsyncDispatcher, even if the widget's vsync
source was null, and then UpdateVsyncDispatcher fell back to using the global
vsync source when null was passed.
The new code skipped the call entirely when the vsync dispatcher was null,
so it prevented fallback to the global vsync dispatcher.
Now with this patch, we correctly fall back to the global vsync
dispatcher if the widget's dispatcher is null.

This code only runs on Linux wayland; on other platforms, BrowserParent::mVsyncParent
is always null because nothing calls AllocPVsyncParent.

Comment 5

[Markus Stange [:mstange]]

I've attached a speculative fix based on code inspection. I haven't tested it yet.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

(In reply to Markus Stange [:mstange] from comment #5)

I've attached a speculative fix based on code inspection. I haven't tested it yet.

Patch works for me.

Comment 8

[Markus Stange [:mstange]]

Thanks for testing!

I've gone ahead and queued it for landing; smaug can review it on Monday. It's a really simple fix and it just restores previous behavior.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bc074934dad
Fall back to the global vsync dispatcher when we're on Wayland and there's no widget-local dispatcher.

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2bc074934dad