1768451 - The PiP's buttons don't show a highlight on hover when in full screen

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user watches a video in PiP, goes in full screen and hovers over the buttons, he will notice that the buttons don't show a highlight as feedback.

Affected versions

• Nightly v102.0a1
• Beta v101.0b3
• Release
• ESR

Affected platforms

• all

Steps to reproduce

1. Launch browser.
2. Right-click...

Expected result

• The buttons show slight lighting as feedback on hover.

Actual result

• The buttons don't show any kind of feedback on hover.

Regression range

• Regression:
  2022-05-09T16:45:36.356000: DEBUG : Found commit message:
  Bug 1707279 Fix picture-in-picture control do not always disappear r=mconley
  Differential Revision: https://phabricator.services.mozilla.com/D130838

Additional notes
*

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:shirshak55, since you are the author of the regressor, bug 1707279, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[kpatenio [PTO Dec 18 - Jan 4]]

I think this behaviour is caused by this css selector. Whenever pip video controls appear, we attach an attribute "showing", which will set 100% opacity for player controls. And with full-screen mode, moving the mouse is one action that attaches this attribute.

We could try setting the button opacity to 80% for full-screen mode when not hovering over a button (like non full-screen mode), even if "showing" is attached:

body:fullscreen #controls[showing]:hover .control-item:not(:hover) {
  opacity: 0.8;
}

Comment 3

[Janvi Bajoria [:janvi01]]

Hey, I would like to take this up. Thanks!

Comment 4

[Janvi Bajoria [:janvi01]]

Attachment: Bug 1768451 - The PiP's buttons show a highlight on hover when in full screen r=kpatenio,niklas

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b136d2f2b267
The PiP's buttons show a highlight on hover when in full screen r=kpatenio,niklas

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b136d2f2b267

Comment 7

[Pascal Chevrel:pascalc]

We have a couple of betas left in the 102 cycle, should we uplift this or an it wait 103? Thanks

Comment 8

[kpatenio [PTO Dec 18 - Jan 4]]

This doesn't need to be uplifted and can wait. Thanks!