176850 - bring over mscott's thread pane "view" code from ns, to mozilla

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

bring over mscott's thread pane "view" code from ns, to mozilla.

we should find any bugscape bugs on the feature, and bring them over to
bugzilla, too.

note, we might not be able to turn it on fully, until we've finished all the
filter changes.  I'll elaborate on that in this bug, and the meta bug I'll log
about when we can fork rules.dat (if that bug doesn't already exist)

Comment 1

[(not reading, please use [e-mail] instead)]

taking.

Comment 2

[(not reading, please use [e-mail] instead)]

good news, I've open sourced mscott's work.  it's not on by default yet, since 
we are frozen for 1.2 final

it will be on by default (At least for windows and linux) in 1.3 alpha

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: turns this feature on for linux, windows.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

could you explain what this change is all about?

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of the feature

Comment 6

[Alex Bishop]

Oh, it's a virtual/search folders type thing. Nice!

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

firstly, thanks a lot for this feature!

secondly, I now applied the patch and built it, and it has a small problem...
(well, maybe it's designed like this...):
I usually have mozilla set up to only show unread mail (view|messages|unread).
now, if I have that option set, and click "All" in the new dropdown list, I
still don't get all messages, but only the unread ones. would be great if this
would show all.

Comment 8

[(not reading, please use [e-mail] instead)]

*** Bug 164092 has been marked as a duplicate of this bug. ***

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of how you customize

for mike lee (and others) a screen shot of how you customize views.

it's the advanced search UI.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

I just noticed that it's not possible to show mails/newsgroup postings
threaded... this would be so much more useful if that was possible.

also, I wish that the view would reset to "All" when I switched from Mail to
News; although if threaded display mode were possible, this would not be so much
of a problem.

Comment 11

[Roope Lehmuslehto]

Looks great, but can it be used in usenet also? 'Recent' filter would be
especially useful in newsgroups. Also thread view when filtered would be great.

Comment 12

[(not reading, please use [e-mail] instead)]

henrik asks:

> are views cross folders?

No, single folder.  That idea (virtual folders) is still an open RFE.
Cross folders would be doable, as would cross accounts, but the latter would
take more work.

Here's something I've been doing, to simulate virtual folders.

1)  disable my filters 
  a) if sender contains bugzilla, then ...
  b) uf subject contains "adv: ", then ..
2)  create three custom views instead:
  a) sender contains bugzilla
  b) subject contains "adv: "
  c) and sender doesn't contain bugzilla and subject does not contain "adv: ".
3)  view my inbox in mode (c).  instead of switching folders, I just switch views.

Comment 13

[(not reading, please use [e-mail] instead)]

>Looks great, but can it be used in usenet also? 'Recent' filter would be
especially useful in newsgroups.

yes, works in news.  

but right now you can't thread when you are in a view mode.

Comment 14

[(not reading, please use [e-mail] instead)]

known bug:  after using the customize view, the view picker says "customize..."
instead of what it was before.  (might only be if you do customize and then hit
cancel)

Comment 15

[Christopher Blizzard (:blizzard)]

Seth, do you want to only check this in for 1.2 as an extension that doesn't
touch other code?

Comment 16

[(not reading, please use [e-mail] instead)]

> Seth, do you want to only check this in for 1.2 as an extension that doesn't
> touch other code?

I wanted to know if drivers wanted it for 1.2 final, but I should wait for 1.3
alpha.

there's some issues, we need to wait for rules.dat to fork (bug owned by naving)
and I still need to do the mac project work.

Comment 17

[Christopher Blizzard (:blizzard)]

Yeah, let's wait for 1.3a.

Comment 18

[JonStipe]

*** Bug 162246 has been marked as a duplicate of this bug. ***

Comment 19

[lchiang]

Talked with Seth.  Laurel, pls bring the open bugs on this feature from bugscape
over to bugzilla now that the code is open sourced. Thanks.

Comment 20

[(not reading, please use [e-mail] instead)]

turned on for windows and linux, mac coming soon.

Comment 21

[(not reading, please use [e-mail] instead)]

Attachment: .xml files already checked in.

Comment 22

[(not reading, please use [e-mail] instead)]

Attachment: .xml file, for review

Comment 23

[(not reading, please use [e-mail] instead)]

Attachment: second xml file, for review

Comment 24

[(not reading, please use [e-mail] instead)]

Attachment: patch, -uw this time

Comment 25

[(not reading, please use [e-mail] instead)]

fixed, on all platforms.

also, I forgot to package up mailViews.dat, so that meant today's builds didn't
have a default mailViews.dat, but tomorrow's will.

Comment 26

[Ere Maijala (slow)]

Something missing from the installer build? The feature is not visible in
installer build trunk-2002110808 on WinXP, but the zip package works.

Comment 27

[Peter Van der Beken [:peterv]]

Doesn't work in yesterdays nightly on Mac either. I had to manually add

content,install,url,jar:resource:/chrome/messenger.jar!/content/messenger-views/

to installed-chrome.txt. My own trunk build works fine.

Comment 28

[Christopher Blizzard (:blizzard)]

Hmm, adding that line to installed-chrome.txt still doesn't allow my custom
views to show up in the list of mail views in an rpm build.  Something is still
missing.

Comment 29

[Andrew Perry]

Still have the problem of no MailViews showing up (evein with added line) in
latest builds -- 2002111404 (Both ZIP & SEA Build tested).

Comment 30

[Andrew Perry]

Correction:  I overwrote the SEA build dir with the ZIP build ... After deleting
install dir and unzipping, MailViews are back ... current ZIP build works (on
clean install, :) )

Comment 31

[Peter Van der Beken [:peterv]]

This still doesn't work in Mac nightlies, have to manually add the line to
installed-chrome.txt every time.

Comment 32

[Andrew Perry]

Anyone else have the problem that their ADVANCED button wen taway (allows Search
Messages) ... This only happens once you get the VIEW button back up .. 

Comment 33

[(not reading, please use [e-mail] instead)]

ok, I just double checked that today's trunk linux bits
(mozilla-i686-pc-linux-gnu-sea.tar.gz) are ok.

peterv says mac is hosed, looking into that now...

Comment 34

[(not reading, please use [e-mail] instead)]

ruh-ruh, three mailnews related lines appear to missing from the official mac
installed-chrome.txt file

> content,install,url,jar:resource:/chrome/messenger.jar!/content/messenger-mdn/
> content,install,url,jar:resource:/chrome/messenger.jar!/content/messenger-views/
> locale,install,url,jar:resource:/chrome/en-US.jar!/locale/en-US/messenger-mdn/

working it...

Comment 35

[Quinn Yost (mythdraug)]

Bug 183755 might be the same issue...

Comment 36

[(not reading, please use [e-mail] instead)]

looks like I forgot to add lines to the per platform mail.jst files
(I'll double check with ssu)

not sure why it works for win32 / linux, though.

working on it...

Comment 37

[(not reading, please use [e-mail] instead)]

Attachment: jst file cleanup

sure enough, some of these .jst changes were in the ns tree, which is why
people behind the firewall weren't seeing it (on linux / win32)

Comment 38

[(not reading, please use [e-mail] instead)]

I think we want this for 1.3a, I'll go seek reviews...

Comment 39

[(not reading, please use [e-mail] instead)]

*** Bug 183755 has been marked as a duplicate of this bug. ***

Comment 40

[David :Bienvenu]

Comment on attachment 108417 [details] [diff] [review]
jst file cleanup

sr=bienvenu

Comment 41

[(not reading, please use [e-mail] instead)]

Comment on attachment 108417 [details] [diff] [review]
jst file cleanup

seeking approval.

Comment 42

[Asa Dotzler [:asa]]

Comment on attachment 108417 [details] [diff] [review]
jst file cleanup

a=asa for checkin to 1.3a

Comment 43

[(not reading, please use [e-mail] instead)]

fixed.  but the proof is in the pudding, when tomorrow's bits come out.

Comment 44

[Peter Van der Beken [:peterv]]

Works for my Mac nightlies now.

Comment 45

[Ere Maijala (slow)]

Great, also works in Windows installer build now.

Comment 46

[(not reading, please use [e-mail] instead)]

I just tested today's mozilla mac and linux bits, they seem ok too.

Comment 47

[laurel]

marking verified
OK using dec23 commercial trunk: win98, linux rh8.0, mac OS 10.2
Generally in an functional
Any further, specific issues for this views feature should be logged separately.