1768692 - Mute/Unmute is out of sync with original video on www.cbc.ca

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Niklas Baumgardner [:niklas]]

STR:

1. navigate to https://www.cbc.ca/player/play/1994098243991
2. open a PiP window
3. mute the video and observe that the original video is still unmuted
4. close the PiP window and play the video

Actual results:
The video plays in a muted state but the volume indicator shows the video is unmuted

Expected results:
The mute state should change on the original video when mute is clicked from the PiP window

Comment 1

[kpatenio]

This mute method is responsible for muting the sound from the PiP window. The fallback, when no video wrapper exists for a particular site, sets video.muted to true or false. While this does mute the sound for CBC, it would be better to select the mute button on CBC instead, like we do for airmozilla for example.

To make a script that can do this, we need a brand new video wrapper for CBC. Please see how to make a video wrapper here.

Comment 2

[Lata]

I want to try solving this bug. Can you assign me?

Comment 3

[kpatenio]

Hi there, sure! I assigned the ticket to you. Please reach out if you have any questions. Otherwise if there's no activity on the bug after a couple days, I might unassign the ticket to give other applicants a chance to work on a patch.

Comment 4

[Lata]

Sure. I'm on it.

Comment 5

[Lata]

Hey! I have been trying to solve this bug. As you said that we have to create a new video wrapper for CBC. I have created and build but still the problem is not solved. Can you please help me in figuring what is the mistake I am making? I'm submitting a patch for your referance.

Comment 6

[Lata]

Attachment: Bug 1768692 - Add CBC entry to picture_in_picture_overrides.js and sync mute/unmute. r=kpatenio!

Depends on D172274

Comment 7

[Leila Kaltouma]

Hello,
I think you forgot to create your custom video wrapper ('cbc.js') and place it inside "browser/extensions/pictureinpicture/video-wrappers".
Your solution should be similar to airmozilla video wrapper.

Comment 8

[Lata]

Hey! I have created cbc.js but at time of submitting my patch I received this error "Warning: found 1 untracked file (will not be submitted):" That's Why that file didn't got submitted. For your referance: https://paste.mozilla.org/2LoZqv34
How can I rectify this error?

Comment 9

[Leila Kaltouma]

I see. Our mentors will be able to assist you better that I can. But I was assigned to a similar bug as this one. And if I remember correctly I had to type "hg add" to start tracking new files added to the codebase. In this case, "cbc.js". I find the documentation a little confusing. Here is a link that was useful to me. How mconley uses Mercurial for Mozilla code

Comment 10

[Lata]

Thankyou so much for helping me out here!

Comment 11

[Lata]

Attachment: Bug 1768692 - Added CBC video wrapper and synced mute buttons. r=kpatenio!

Comment 12

[kpatenio]

Hello!

(In reply to Lata from comment #8)

Hey! I have created cbc.js but at time of submitting my patch I received this error "Warning: found 1 untracked file (will not be submitted):" That's Why that file didn't got submitted. For your referance: https://paste.mozilla.org/2LoZqv34
How can I rectify this error?

This means that the cbc.js file that you created isn't being tracked by Mercurial, hence why in your first patch the file isn't there. If there's a file you want to track that's marked as an "untracked" file, you will want to run hg add for that file. I noticed that you added it in the second patch though, which is fine for now. I recommend updating a single revision for future work, since it makes it easier for reviewers to view your changes.

(In reply to Leila Kaltouma from comment #9)

I see. Our mentors will be able to assist you better that I can. But I was assigned to a similar bug as this one. And if I remember correctly I had to type "hg add" to start tracking new files added to the codebase. In this case, "cbc.js". I find the documentation a little confusing. Here is a link that was useful to me. How mconley uses Mercurial for Mozilla code

Thanks for the help here Leila! I greatly appreciate it.

Comment 13

[Lata]

Okay ! I will take care of this.(In reply to kpatenio from comment #12)

Hello!

(In reply to Lata from comment #8)

Hey! I have created cbc.js but at time of submitting my patch I received this error "Warning: found 1 untracked file (will not be submitted):" That's Why that file didn't got submitted. For your referance: https://paste.mozilla.org/2LoZqv34
How can I rectify this error?

This means that the cbc.js file that you created isn't being tracked by Mercurial, hence why in your first patch the file isn't there. If there's a file you want to track that's marked as an "untracked" file, you will want to run hg add for that file. I noticed that you added it in the second patch though, which is fine for now. I recommend updating a single revision for future work, since it makes it easier for reviewers to view your changes.

(In reply to Leila Kaltouma from comment #9)

I see. Our mentors will be able to assist you better that I can. But I was assigned to a similar bug as this one. And if I remember correctly I had to type "hg add" to start tracking new files added to the codebase. In this case, "cbc.js". I find the documentation a little confusing. Here is a link that was useful to me. How mconley uses Mercurial for Mozilla code

Thanks for the help here Leila! I greatly appreciate it.

I will take care of it.

Comment 14

[kpatenio]

(In reply to Lata from comment #13)

I will take care of it.

No need to worry about turning it into one patch. I accepted one of them. Currently reviewing the other.

Comment 15

[Lata]

I have made the changes you suggested. Please review. https://phabricator.services.mozilla.com/D172373

Comment 16

[Lata]

Attachment: Bug 1768692 - Mute/Unmute is out of sync with original video on www.cbc.ca. r=kpatenio!

Depends on D172383

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9624a6f53c6
Mute/Unmute is out of sync with original video on www.cbc.ca. r=kpatenio

Comment 18

[kpatenio]

Whoops, not all patches were pushed at once. Fortunately, they should work fine on their own and not break anything (hopefully).

Comment 19

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustages on browser/extensions/pictureinpicture/video-wrappers/cbc.js

• backout: https://hg.mozilla.org/integration/autoland/rev/43006e98f28feacd2c2b7b5fa6ccbf83fbba2837
• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=b9624a6f53c60e6ef8d99e3405fefb8644d6d978
• failure log: https://treeherder.mozilla.org/logviewer?job_id=408954463&repo=autoland&lineNumber=1151

[task 2023-03-15T02:16:10.458Z] 02:16:10    ERROR -  Traceback (most recent call last):
[task 2023-03-15T02:16:10.458Z] 02:16:10     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 343, in <module>
[task 2023-03-15T02:16:10.458Z] 02:16:10     INFO -      sys.exit(main(sys.argv))
[task 2023-03-15T02:16:10.458Z] 02:16:10     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 156, in main
[task 2023-03-15T02:16:10.459Z] 02:16:10     INFO -      return config_status(config)
[task 2023-03-15T02:16:10.459Z] 02:16:10     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 294, in config_status
[task 2023-03-15T02:16:10.459Z] 02:16:10     INFO -      return config_status(args=[], **sanitized_config)
[task 2023-03-15T02:16:10.459Z] 02:16:10     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/config_status.py", line 152, in config_status
[task 2023-03-15T02:16:10.459Z] 02:16:10     INFO -      definitions = list(definitions)
[task 2023-03-15T02:16:10.459Z] 02:16:10     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 156, in emit
[task 2023-03-15T02:16:10.459Z] 02:16:10     INFO -      objs = list(emitfn(out))
[task 2023-03-15T02:16:10.460Z] 02:16:10     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1461, in emit_from_context
[task 2023-03-15T02:16:10.460Z] 02:16:10     INFO -      raise SandboxValidationError(
[task 2023-03-15T02:16:10.460Z] 02:16:10     INFO -  mozbuild.frontend.reader.SandboxValidationError:
[task 2023-03-15T02:16:10.460Z] 02:16:10     INFO -  ==============================
[task 2023-03-15T02:16:10.460Z] 02:16:10     INFO -  FATAL ERROR PROCESSING MOZBUILD FILE
[task 2023-03-15T02:16:10.460Z] 02:16:10     INFO -  ==============================
[task 2023-03-15T02:16:10.460Z] 02:16:10     INFO -  The error occurred while processing the following file or one of the files it includes:
[task 2023-03-15T02:16:10.460Z] 02:16:10     INFO -      /builds/worker/checkouts/gecko/browser/extensions/pictureinpicture/moz.build
[task 2023-03-15T02:16:10.461Z] 02:16:10     INFO -  The error occurred when validating the result of the execution. The reported error is:
[task 2023-03-15T02:16:10.461Z] 02:16:10     INFO -      File listed in FINAL_TARGET_FILES does not exist: /builds/worker/checkouts/gecko/browser/extensions/pictureinpicture/video-wrappers/cbc.js
[task 2023-03-15T02:16:11.117Z] 02:16:11     INFO -  *** Fix above errors and then restart with "./mach build"
[task 2023-03-15T02:16:11.177Z] 02:16:11     INFO - Return code: 1
[task 2023-03-15T02:16:11.177Z] 02:16:11  WARNING - setting return code to 2
[task 2023-03-15T02:16:11.177Z] 02:16:11    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2023-03-15T02:16:11.177Z] 02:16:11    FATAL - Running post_fatal callback...
[task 2023-03-15T02:16:11.177Z] 02:16:11    FATAL - Exiting -1

Comment 20

[kpatenio]

Thanks for the ping. Will get this resolved asap.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f051b610eee3
Add CBC entry to picture_in_picture_overrides.js and sync mute/unmute. r=kpatenio

Comment 22

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f051b610eee3

Comment 23

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-03-14 Nightly build on Windows 10.
Verified as fixed on Firefox 113.0(build ID: 20230501151611) and Nightly 114.0a1(build ID: 20230501093846) on Windows 10, Ubuntu 22, macOS 12.