1768694 - Mute/Unmute is out of sync with original video on ici.radio-canada.ca

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Niklas Baumgardner [:niklas]]

STR:

1. navigate to https://ici.radio-canada.ca/info/videos/media-8607193/2460-entrevue-avec-michel-tremblay-immortel
2. open a PiP window
3. mute the video and observe that the original video is still unmuted
4. close the PiP window and play the video

Actual results:
The video plays in a muted state but the volume indicator shows the video is unmuted.

Expected results:
The mute state should change on the original video when mute is clicked from the PiP window

Comment 1

[kpatenio]

This mute method is responsible for muting the sound from the PiP window. The fallback, when no video wrapper exists for a particular site, sets video.muted to true or false. While this does mute the sound for ICI Radio Canada, it would be better to select the mute button on ICI Radio Canada instead, like we do for airmozilla for example.

To make a script that can do this, we need a brand new video wrapper for ICI Radio Canada. Please see how to make a video wrapper here.

Comment 2

[Leila Kaltouma]

Hello,
may I work on this bug?

Comment 3

[kpatenio]

Hello, thank you for your interest! I assigned the bug to you. Please reach out if you have any questions. Otherwise if there's no activity on the bug after a couple days, I might unassign the ticket to give other applicants a chance to work on a patch.

Comment 4

[Leila Kaltouma]

Thank you. I'll submit a patch soon.

Comment 5

[Leila Kaltouma]

Attachment: Bug 1768694 - Mute/Unmute is out of sync with original video on ici.radio-canada.ca. r=kpatenio!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/412ec6ee13cf
Mute/Unmute is out of sync with original video on ici.radio-canada.ca. r=kpatenio

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/412ec6ee13cf

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-03-12 Nightly build on macOS 12.
Verified as fixed on Firefox 113.0(build ID: 20230501151611) and Nightly 114.0a1(build ID: 20230502160708) on macOS 12, Windows 10, Ubuntu 22.