1768926 - Composer: Toolbar button for encryption options needs an icon

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert (:KaiE:)]

Bug 1764324 added a toolbar button that shows either the text OpenPGP or S/MIME.

If the toolbar is configured to show an icon, only, there is just a blank space shown.

If we want to keep this button here, we should add an icon.

(The alternative is to show a plain text (without menu) on the status bar, and have users rely on the top level menu bar to switch options.)

Comment 1

[Kai Engert (:KaiE:)]

Unless anyone has a better idea, I suggest to show a little "shield" icon, I found one here:
https://openclipart.org/detail/33001/basic-shield-1

I think images from the site openclipart.org are generally allowed to be used by us?

Based on the above, I've created a new svg file that matches our other icons.

Comment 2

[Kai Engert (:KaiE:)]

Here is an improved idea for the icon:

Inside the shield, we could display one large character, either the character O for OpenPGP, or the character S for S/MIME.

Comment 3

[Kai Engert (:KaiE:)]

Attachment: Bug 1768926 - Add an icon to the toolbar button for encryption options. r=aleca

Comment 4

[Alessandro Castellani [:aleca]]

(In reply to Kai Engert (:KaiE:) from comment #2)

Inside the shield, we could display one large character, either the character O for OpenPGP, or the character S for S/MIME.

Better not to as it's a bit of a weird paradigm and not easily understandable.
The encryption technology is decided by the user if they have more than one, and they need to open that dropdown to select the preferred, so I don't see a huge necessity of referencing which one is used at all times since picking one or another is an active choice.

Comment 5

[Kai Engert (:KaiE:)]

When landing, apply on top of bug 1768609 to avoid merge conflicts (both this and the other one are ready for landing).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a4378aaa8c14
Add an icon to the toolbar button for encryption options. r=aleca

Comment 7

[Kai Engert (:KaiE:)]

Comment on attachment 9276138 [details]
Bug 1768926 - Add an icon to the toolbar button for encryption options. r=aleca

let's test functionality intended for 102 in beta

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9276138 [details]
Bug 1768926 - Add an icon to the toolbar button for encryption options. r=aleca

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 101.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/47304105efa2