1769200 - Offline event modification on remote calendars, events are not sent to the server when you go back online

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[adrien.rybarczyk]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.88 Safari/537.36

Steps to reproduce:

1. Create events online on a remote calendar (I only tested CalDAV)
2. Switch to offline
3. Modify the created events
4. Go back online

Actual results:

After going back online, the changes are not sent to the server.

Moreover, if you restart Thunderbird. We keep the changes in the event in our calendar. However, on the server the event does not have the changes. This can lead to confusion.

Expected results:

Don't have this problem anymore.

Comment 1

[Magnus Melin [:mkmelin]]

Do you know if this used to work?

Comment 2

[adrien.rybarczyk]

(In reply to Magnus Melin [:mkmelin] from comment #1)

Do you know if this used to work?

Yes, it worked before 101 and it works in 91.

It must be due to the changes in version 101 that took place for the management of adding events in the calendars.

Comment 3

[Wayne Mery (:wsmwk)]

tcw can you reproduce?

Comment 4

[Arthur K. (he/him)]

(In reply to Wayne Mery (:wsmwk) from comment #3)

tcw can you reproduce?

Yup. Tested with 101.0b4. I had my GMail calendar open whilst I went online and reloaded it but the change did not show. Even did a ctrl-shift-c and clicked Synchronize and it still did not change on the gmail calendar side.

While in Offline mode, I checked the error console twice after making a change to an event and it spit out the below error twice:
10:13:24.544 NS_ERROR_FAILURE: ReferenceError: self is not defined calCachedCalendar.js:742

Comment 5

[Magnus Melin [:mkmelin]]

Arthur: Which version? (Which line does that link to.)

Comment 6

[Arthur K. (he/him)]

Attachment: calCachedCalendar.js

Comment 7

[Arthur K. (he/him)]

I am on 101.0b4. Well, a copy/paste into Notepad++ says calCachedCalendar.js:742 is

return reject(new Components.Exception(detail, status));

Is that what you're looking for? Attaching the calCachedCalendar.js file for review to verify I'm looking at the right line.

Comment 8

[Lasana Murray]

Attachment: Bug 1769200 - Make doAdoptItem() and doModifyItem() simpler in calCachedCalendar. r=darktrojan

Comment 9

[Lasana Murray]

The problem here is the use of self in the wrong scope but I'll use this opportunity to do some further clean up here I was putting off until after 102.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bac7042eaf0d
Make doAdoptItem() and doModifyItem() simpler in calCachedCalendar. r=darktrojan