1908530 - Items not added to the offline cache when network fails (TypeError: calendar is null)

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

In https://searchfox.org/comm-central/rev/5dd86d8570114551f29277f4eef220757168c7ff/calendar/base/src/CalCachedCalendar.sys.mjs#709

If the network fails (isUnavailableCode() is true), then a message is shown that includes calendar.name. However, in line 734, the callback is always called without a calendar. Hence items are never actually added to the offline cache on failure.

The same happens for other operations.

I'd recommend uplifting this once done as it causes events not to be changed while failing the network.

Comment 1

[Magnus Melin [:mkmelin]]

Maybe this is the root cause of various bugs we've got for not-properly-syncing nextcloud calendars...

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

This seems to go back to bug 1769200 based on the code. I'm requesting tracking this for 128, as it inhibits adding items while offline or during a network outage. You might also consider backporting this to 115, I expect the fix to be low risk.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1908530 - Fix "calendar is null" error in adoptItemCallback. r=Fallen

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/247126682247
Fix "calendar is null" error in adoptItemCallback. r=Fallen

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9417954 [details]
Bug 1908530 - Fix "calendar is null" error in adoptItemCallback. r=Fallen

[Approval Request Comment]
Regression caused by (bug #): bug 1769200
User impact if declined: offline cache inconsistency after network errors
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): not too risky

Comment 6

[Corey Bryant]

Comment on attachment 9417954 [details]
Bug 1908530 - Fix "calendar is null" error in adoptItemCallback. r=Fallen

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 130.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/7fc04b6c039b

Comment 8

[Corey Bryant]

Comment on attachment 9417954 [details]
Bug 1908530 - Fix "calendar is null" error in adoptItemCallback. r=Fallen

[Triage Comment]
Approved for esr128

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/78c69d57bfff