Closed
Bug 1769475
Opened 3 years ago
Closed 3 years ago
Fix URI comparison in OpenMessageByHeader()
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(thunderbird_esr91 wontfix)
RESOLVED
FIXED
102 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr91 | --- | wontfix |
People
(Reporter: infofrommozilla, Assigned: infofrommozilla)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
rnons
:
review+
|
Details | Diff | Splinter Review |
When clicking on a message ID in the header pane, OpenMessageByHeader() is called.
A comparison there is always TRUE, because wrong variables are compared:
https://searchfox.org/comm-central/rev/48468049ddceab57193e15c3ef92ec1b59fef59e/mail/base/content/mailContextMenus.js#222
if (msgWindow.openFolder != folderURI) {
|
Assignee | |
Comment 1•3 years ago
|
||
if (msgWindow.openFolder != folderURI) {
Correct is msgWindow.openFolder.URI.
Since folderURI is only used once, I removed the variable altogether.
Assignee: nobody → infofrommozilla
Attachment #9276619 -
Flags: review?(remotenonsense)
|
||
Updated•3 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•3 years ago
|
Summary: Fix URI comparison in OpenMessageForMessageId() → Fix URI comparison in OpenMessageByHeader()
|
||
Comment 2•3 years ago
|
||
Comment on attachment 9276619 [details] [diff] [review]
Fix URI comparison in OpenMessageByHeader().
Looks good, thanks.
Attachment #9276619 -
Flags: review?(remotenonsense) → review+
|
|
||
Updated•3 years ago
|
status-thunderbird_esr91:
--- → wontfix
Keywords: checkin-needed-tb
Target Milestone: --- → 102 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/720902865137
Fix URI comparison in OpenMessageByHeader(). r=rnons
|
||
Updated•3 years ago
|
Blocks: tb102found
You need to log in
before you can comment on or make changes to this bug.
Description
•