Closed Bug 1769487 Opened 2 years ago Closed 2 years ago

Unintended repositioning on the right-side of the tab-strip with multiple tabs opened

Categories

(Firefox :: Tabbed Browser, defect)

Firefox 100
defect

Tracking

()

VERIFIED FIXED
102 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox100 --- wontfix
firefox101 --- wontfix
firefox102 --- verified

People

(Reporter: okazki98, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

  1. Open approximately 8 tabs (for a 1920x1080 16:9 screen). Maybe fewer tabs for a smaller screen, and more tabs for a larger screen.
  2. Click on "Add new tab" button
  3. Close the newly opened tab

Actual results:

The "Arrow down" button (search tabs) briefly appears and then disappears.
This also seems to cause the tabs to shift/move with a choppy animation.
(Recording of the issue: https://youtu.be/DCBlD8Rx8R0)
Tried narrowing the issue down with mozz-regression and as suspected, the issue is caused by the patch from #bug1759221

Expected results:

The "Arrow down" (search tabs) button should appear only when a specific number of tabs are opened (aprox. 20tabs on my screen specs). It should not appear briefly unnecessarily. The tab shifting/moving should be smooth, without any choppiness.

Component: Untriaged → Tabbed Browser
Regressed by: 1759221

Set release status flags based on info from the regressing bug 1759221

:emilio, since you are the author of the regressor, bug 1759221, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)
Has Regression Range: --- → yes

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Status: UNCONFIRMED → NEW
Ever confirmed: true

This prevents the overflow button and such from getting unexpectedly
shown mid-animation. With -moz-box-pack: start it doesn't look visibly
worse, afaict.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Depends on: 1769512
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a703c001c31e
Prevent overflow during the start/end of the tab open/close animation. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

We'd need to uplift bug 1769512 so probably not.

Flags: needinfo?(emilio)
Flags: qe-verify+

I managed to reproduce this issue on Firefox 100.0 on Windows 10x64. Verified as fixed on Firefox 102.0b4(20220605185654) and Nightly 103.0a1( 20220606212503) on Windows 10 x64, macOS 11 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: