1769512 - Implement overflow-clip-margin: <length>

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task)

Description

[Emilio Cobos Álvarez (:emilio)]

Seems this should be uncontroversial for now.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1769512 - Add some convenience operators to BaseMargin. r=#gfx-reviewers

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1769512 - Support both negative and positive offsets in border radius adjustments. r=#layout-reviewers

Depends on D146430

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1769512 - Implement overflow-clip-margin: <length>. r=jwatt

Depends on D146431

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1769512 - Apply overflow: clip to IntersectionObserver. r=#layout-reviewers

Depends on D146432

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7e356cfca68
Add some convenience operators to BaseMargin. r=gfx-reviewers,nical

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c7e356cfca68

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d8f25c4388a
Support both negative and positive offsets in border radius adjustments. r=jwatt

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2e017726323
Implement overflow-clip-margin: <length>. r=jwatt

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34147 for changes under testing/web-platform/tests

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/853afa1f9242
Apply overflow: clip to IntersectionObserver. r=hiro

Comment 11

[Cristian Tuns]

Backed out for causing multiple failures(wr and c1)

• Backout link
• Push with failures
• Failure Log
• Failure Log 2
• Failure line: TEST-UNEXPECTED-FAIL | devtools/server/tests/chrome/test_animation-type-longhand.html | All longhands should be mapped to some animation type - got 1, expected +0
• Failure line: TEST-UNEXPECTED-FAIL | /css/css-overflow/overflow-clip-margin-002.html | Testing http://web-platform.test:8000/css/css-overflow/overflow-clip-margin-002.html == http://web-platform.test:8000/css/css-overflow/overflow-clip-margin-002-ref.html
  log 3: https://treeherder.mozilla.org/logviewer?job_id=378810525&repo=autoland

I also had to backout the other revision for causing build bustages: https://treeherder.mozilla.org/logviewer?job_id=378813402&repo=autoland
And also this reftest: https://treeherder.mozilla.org/logviewer?job_id=378813967&repo=autoland

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3322c3e25aee
Backed out changeset 853afa1f9242 for causing build bustages when backing out the previous revision CLOSED TREE

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0d8f25c4388a

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0368bdfdea8e
Implement overflow-clip-margin: <length>. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/1c6e41202bd2
Apply overflow: clip to IntersectionObserver. r=hiro

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c678efcdd877
fixed lint failures r=fix CLOSED TREE

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb390dade1c3
Minor test tweaks.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d51b55ba4d8
Fix a typo in animation-type-longhand.js

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1a9aa8ca9da
Fix partial prerender tests by preserving sketchy behavior.

Comment 20

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0368bdfdea8e
https://hg.mozilla.org/mozilla-central/rev/1c6e41202bd2
https://hg.mozilla.org/mozilla-central/rev/c678efcdd877
https://hg.mozilla.org/mozilla-central/rev/bb390dade1c3
https://hg.mozilla.org/mozilla-central/rev/5d51b55ba4d8
https://hg.mozilla.org/mozilla-central/rev/a1a9aa8ca9da

Comment 21

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot