1769492 - Crash in [@ core::option::expect_failed | webrender::render_task_graph::RenderTaskGraphBuilder::end_frame] - Unable to find a bin!

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

36 crash reports with Firefox 100.0 for the last week, a few with 101.0b. All on macOS.

Crash report: https://crash-stats.mozilla.org/report/index/371508b8-12ee-49b6-be76-b04320220515

MOZ_CRASH Reason: Unable to find a bin!

Top 10 frames of crashing thread:

0 XUL RustMozCrash mozglue/static/rust/wrappers.cpp:18
1 XUL mozglue_static::panic_hook mozglue/static/rust/lib.rs:91
2 XUL core::ops::function::Fn::call library/core/src/ops/function.rs:70
3 XUL std::panicking::rust_panic_with_hook library/std/src/panicking.rs:610
4 XUL std::panicking::begin_panic_handler::{{closure}} library/std/src/panicking.rs:502
5 XUL std::sys_common::backtrace::__rust_end_short_backtrace library/std/src/sys_common/backtrace.rs:139
6 XUL rust_begin_unwind library/std/src/panicking.rs:498
7 XUL core::panicking::panic_fmt library/core/src/panicking.rs:116
8 XUL core::panicking::panic_display library/core/src/panicking.rs:72
9 XUL core::panicking::panic_str library/core/src/panicking.rs:56

Comment 1

[Glenn Watson [:gw]]

I only see a single crash report when I click the link - how do I see the others?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Crash submissions dropped since the release of 102 (the date range in crash stats needs to be expanded to see the older ones):

102.0.1	3	0.9%	3
101.0.1	89	27.1%	64
101.0	38	11.6%	38

Comment 3

[Gabriele Svelto [:gsvelto]]

We're starting to hit the panic message in bug 1790172, here's an example. Panic message is: Unable to find a bin for 2816x0!.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 5 desktop browser crashes on Mac on beta

:gw, could you consider increasing the severity of this top-crash bug?

For more information, please visit auto_nag documentation.

Comment 5

[Glenn Watson [:gw]]

We'll need to be able to reproduce this locally to do anything about it. I was unable to repro locally from any of the reported crash URLs, however most of them were google drive pages that I was unable to access.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit auto_nag documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Sorry for removing the keyword earlier but there is a recent change in the ranking, so the bug is again linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on beta

For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit BugBot documentation.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Any chance we've seen something like this crash with the fuzzers?

Comment 10

[Tyson Smith [:tsmith]]

Bug 1872775 and Bug 1877585 do have the same stack but don't seem to be reproducible.

I also managed to get an rr recording I am uploading to Pernosco now.

Comment 11

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/4X8N51cPwPu8o5v5Avb1ZA/index.html

I can trigger the issue by visiting https://modern.seowptheme.com/ and scrolling up and down the page.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Hi Glenn, do the recent comments help?

Comment 13

[Glenn Watson [:gw]]

This might be something Nical is able to diagnose, especially with the repro info in comment #11.

Comment 14

[Nicolas Silva [:nical]]

Pernosco saves the day once again. Thanks Tyson!

Comment 15

[Nicolas Silva [:nical]]

Attachment: Bug 1769492 - Ensure that get_surface_rect does not produce a zero-sized rect. r=gw

Comment 16

[Nicolas Silva [:nical]]

Attachment: Bug 1769492 - Don't assume that get_surface_rect returns a non-empty rect. r=gw

Comment 17

[Nicolas Silva [:nical]]

Attachment: Bug 1769492 - Don't assume that get_surface_rect returns a non-empty rect. r=gw

Comment 18

[Nicolas Silva [:nical]]

Attachment: Bug 1769492 - Don't assume that get_surface_rect returns a non-empty rect. r=gw

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd1b3d97c6a8
Ensure that get_surface_rect does not produce a zero-sized rect. r=gw
https://hg.mozilla.org/integration/autoland/rev/987284103c26
Don't assume that get_surface_rect returns a non-empty rect. r=gw

Comment 20

[tszentpeteri]

Backed out for causing webrender bustages in conftest.c

• Backout link
• Push with failures
• Failure Log
• Failure lines: [servo-fontconfig-sys 5.1.0] conftest.c:85:26: fatal error: atomic.h: No such file or directory
  subprocess.CalledProcessError: Command '['../target/release/wrench', '--no-scissor', '--headless', 'reftest']' died with <Signals.SIGABRT: 6>.

We also have mochitest failures like this: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=11d507e55b6e2588004ca5fef5c00799b6baf900&searchStr=android%2C7.0%2Cx86-64%2Clite%2Cwebrender%2Copt%2Cmochitests%2Cthat%2Crun%2Con%2Cfission%2Cwith%2Cisolatehighvalue%2Cisolation%2Cstrategy%2C%28android-specific%29%2Ctest-android-em-7.0-x86_64-lite-qr%2Fopt-geckoview-mochitest-plain-fis-hv%2C5&selectedTaskRun=In6bOe_sQ7G6Tn5TcKOr0A.0&tochange=987284103c26599be1cfe7738d0780c6253fb5cb

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7eaa2650ed5
Ensure that get_surface_rect does not produce a zero-sized rect. r=gw
https://hg.mozilla.org/integration/autoland/rev/841e7dd0db80
Don't assume that get_surface_rect returns a non-empty rect. r=gw

Comment 22

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f7eaa2650ed5
https://hg.mozilla.org/mozilla-central/rev/841e7dd0db80