1769991 - Geckodriver cannot launch firefox from within snap confinement

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P3)

Description

[Olivier Tilloy]

Following up on bug #1766125, and per request in https://phabricator.services.mozilla.com/D146303, I'm filing this separate issue to track changing the default firefox binary path when geckodriver is used from within snap confinement.

This issue was initially discussed in https://github.com/mozilla/geckodriver/issues/2010.

Snapd refuses to execute an arbitrary executable in /snap/bin/ (even though that executable is part of the same snap) because these executables are all symlinks to /usr/bin/snap, but it does allow executing an executable which it knows for sure is contained in the same snap (under /snap/firefox/current/).

So when running under snap confinement, we need to make sure the default path to the firefox binary is specified as /snap/firefox/current/firefox.launcher.

Comment 1

[Olivier Tilloy]

Attachment: Bug 1769991 - Change the default firefox binary path when geckodriver is used from within snap confinement

Comment 2

[BugBot [:suhaib / :marco]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 3

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oliver, are you still interested to continue working on this bug? After James' last review an update of the patch is required. Thanks.

Comment 5

[Olivier Tilloy]

Yes, sorry for not addressing this earlier. I have now updated the patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93e827afaac1
Change the default firefox binary path when geckodriver is used from within snap confinement r=webdriver-reviewers,jgraham,whimboo

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/93e827afaac1