Closed Bug 1770140 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34124 - Fix potential test error by using different color for testing attribute.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Notable wpt changes
68.49 KB, text/plain
Details

Sync web-platform-tests PR 34124 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34124
Details from upstream follow.

Byungwoo Lee <blee@igalia.com> wrote:

Fix potential test error by using different color for testing attribute.

The commit 696ebeed0f0475edfc4bd54dfcd8304db774f7cf added additaional
tests to check attribute selectors inside :has() in all relationship.

To minimize the change, the CL just added new :has() argument selector
to the existing style rules, and it has a potential problem of hiding
test failure from one argument selector by another argument selector.

To avoid it, this CL used different color for attribute testing.

Bug: 669058
Change-Id: Ic06776bbc47702076a4ec1aff1a14fd5d87e774f
Reviewed-on: https://chromium-review.googlesource.com/3651933
WPT-Export-Revision: 3ca948b8858be45d8d0b0b35e08e5858252e2798

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Attached file Notable wpt changes —
# CI Results Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 4 tests and 295 subtests ## Status Summary ### Firefox `OK` : 4 `PASS`: 736 `FAIL`: 402 ### Chrome `OK` : 4 `PASS`: 1138 ### Safari `OK` : 4 `PASS`: 1062 `FAIL`: 76 ## Links [GitHub PR Head](https://wpt.fyi/results/?sha=89b0434fd15751ffd4d9e843d5bf733b498ef00a&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=89b0434fd15751ffd4d9e843d5bf733b498ef00a&label=pr_base) ## Details ### Firefox-only Failures * [/css/selectors/invalidation/has-in-adjacent-position.html](https://wpt.live/css/selectors/invalidation/has-in-adjacent-position.html) [[wpt.fyi](https://wpt.fyi/results/css/selectors/invalidation/has-in-adjacent-position.html)] * add .test to previous_sibling_child: `FAIL` * add .test to previous_sibling_descendant: `FAIL` * add .test to subject: `FAIL` * add .test to next_sibling: `FAIL` * add .test to next_sibling_child: `FAIL` * add .test to next_sibling_descendant: `FAIL` * insert element div.test before previous_sibling_child: `FAIL` * add the class 'test' again to the element inserted before previous_sibling_child: `FAIL` * insert element div[test_attr] before previous_sibling_child: `FAIL` * insert element div.test before previous_sibling_descendant: `FAIL` * add the class 'test' again to the element inserted before previous_sibling_descendant: `FAIL` * insert element div[test_attr] before previous_sibling_descendant: `FAIL` * insert element div.test before next_sibling: `FAIL` * add the class 'test' again to the element inserted before next_sibling: `FAIL` * add the class 'test' to the element inserted again before next_sibling: `FAIL` * insert element div[test_attr] before next_sibling: `FAIL` * insert element div.test before next_sibling_child: `FAIL` * add the class 'test' again to the element inserted before next_sibling_child: `FAIL` * insert element div[test_attr] before next_sibling_child: `FAIL` * insert element div.test before next_sibling_descendant: `FAIL` * add the class 'test' again to the element inserted before next_sibling_descendant: `FAIL` * insert element div[test_attr] before next_sibling_descendant: `FAIL` * insert element div.test after previous_sibling_child: `FAIL` * add the class 'test' again to the element inserted after previous_sibling_child: `FAIL` * insert element div[test_attr] after previous_sibling_child: `FAIL` * insert element div.test after previous_sibling_descendant: `FAIL` * add the class 'test' again to the element inserted after previous_sibling_descendant: `FAIL` * insert element div[test_attr] after previous_sibling_descendant: `FAIL` * insert element div.test after subject: `FAIL` * add the class 'test' again to the element inserted after subject: `FAIL` * add the class 'test' to the element inserted again after subject: `FAIL` * insert element div[test_attr] after subject: `FAIL` * insert element div.test after next_sibling: `FAIL` * add the class 'test' again to the element inserted after next_sibling: `FAIL` * add the class 'test' to the element inserted again after next_sibling: `FAIL` * insert element div[test_attr] after next_sibling: `FAIL` * insert element div.test after next_sibling_child: `FAIL` * add the class 'test' again to the element inserted after next_sibling_child: `FAIL` * insert element div[test_attr] after next_sibling_child: `FAIL` * insert element div.test after next_sibling_descendant: `FAIL` * add the class 'test' again to the element inserted after next_sibling_descendant: `FAIL` * insert element div[test_attr] after next_sibling_descendant: `FAIL` * insert tree div>div.test before previous_sibling_child: `FAIL` * add the class 'test' again to the element in the tree inserted before previous_sibling_child: `FAIL` * insert element div>div[test_attr] before previous_sibling_child: `FAIL` * insert tree div>div.test before previous_sibling_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted before previous_sibling_descendant: `FAIL` * insert element div>div[test_attr] before previous_sibling_descendant: `FAIL` * insert tree div>div.test before subject: `FAIL` * add the class 'test' again to the element in the tree inserted before subject: `FAIL` * add the class 'test' to the element in the tree inserted again before subject: `FAIL` * insert element div>div[test_attr] before subject: `FAIL` * insert tree div>div.test before next_sibling: `FAIL` * add the class 'test' again to the element in the tree inserted before next_sibling: `FAIL` * add the class 'test' to the element in the tree inserted again before next_sibling: `FAIL` * insert element div>div[test_attr] before next_sibling: `FAIL` * insert tree div>div.test before next_sibling_child: `FAIL` * add the class 'test' again to the element in the tree inserted before next_sibling_child: `FAIL` * insert element div>div[test_attr] before next_sibling_child: `FAIL` * insert tree div>div.test before next_sibling_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted before next_sibling_descendant: `FAIL` * insert element div>div[test_attr] before next_sibling_descendant: `FAIL` * insert tree div>div.test after previous_sibling: `FAIL` * add the class 'test' again to the element in the tree inserted after previous_sibling: `FAIL` * add the class 'test' to the element in the tree inserted again after previous_sibling: `FAIL` * insert element div>div[test_attr] after previous_sibling: `FAIL` * insert tree div>div.test after previous_sibling_child: `FAIL` * add the class 'test' again to the element in the tree inserted after previous_sibling_child: `FAIL` * insert element div>div[test_attr] after previous_sibling_child: `FAIL` * insert tree div>div.test after previous_sibling_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted after previous_sibling_descendant: `FAIL` * insert element div>div[test_attr] after previous_sibling_descendant: `FAIL` * insert tree div>div.test after subject: `FAIL` * add the class 'test' again to the element in the tree inserted after subject: `FAIL` * add the class 'test' to the element in the tree inserted again after subject: `FAIL` * insert element div>div[test_attr] after subject: `FAIL` * insert tree div>div.test after next_sibling: `FAIL` * add the class 'test' again to the element in the tree inserted after next_sibling: `FAIL` * add the class 'test' to the element in the tree inserted again after next_sibling: `FAIL` * insert element div>div[test_attr] after next_sibling: `FAIL` * insert tree div>div.test after next_sibling_child: `FAIL` * add the class 'test' again to the element in the tree inserted after next_sibling_child: `FAIL` * insert element div>div[test_attr] after next_sibling_child: `FAIL` * insert tree div>div.test after next_sibling_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted after next_sibling_descendant: `FAIL` * insert element div>div[test_attr] after next_sibling_descendant: `FAIL` * [/css/selectors/invalidation/has-in-ancestor-position.html](https://wpt.live/css/selectors/invalidation/has-in-ancestor-position.html) [[wpt.fyi](https://wpt.fyi/results/css/selectors/invalidation/has-in-ancestor-position.html)] * add .test to subject_parent: `FAIL` * add .test to subject: `FAIL` * add .test to subject_child: `FAIL` * add .test to subject_descendant: `FAIL` * add .test to next_sibling: `FAIL` * add .test to next_sibling_child: `FAIL` * add .test to next_sibling_descendant: `FAIL` * insert element div.test before subject_parent: `FAIL` * add the class 'test' again to the element inserted before subject_parent: `FAIL` * insert element div[test_attr] before subject_parent: `FAIL` * insert element div.test before subject: `FAIL` * add the class 'test' again to the element inserted before subject: `FAIL` * insert element div[test_attr] before subject: `FAIL` * insert element div.test before subject_child: `FAIL` * add the class 'test' again to the element inserted before subject_child: `FAIL` * insert element div[test_attr] before subject_child: `FAIL` * insert element div.test before subject_descendant: `FAIL` * add the class 'test' again to the element inserted before subject_descendant: `FAIL` * insert element div[test_attr] before subject_descendant: `FAIL` * insert element div.test before next_sibling: `FAIL` * add the class 'test' again to the element inserted before next_sibling: `FAIL` * insert element div[test_attr] before next_sibling: `FAIL` * insert element div.test before next_sibling_child: `FAIL` * add the class 'test' again to the element inserted before next_sibling_child: `FAIL` * insert element div[test_attr] before next_sibling_child: `FAIL` * insert element div.test before next_sibling_descendant: `FAIL` * add the class 'test' again to the element inserted before next_sibling_descendant: `FAIL` * insert element div[test_attr] before next_sibling_descendant: `FAIL` * insert element div.test after subject_ancestor: `FAIL` * add the class 'test' again to the element inserted after subject_ancestor: `FAIL` * insert element div[test_attr] after subject_ancestor: `FAIL` * insert element div.test after subject_parent: `FAIL` * add the class 'test' again to the element inserted after subject_parent: `FAIL` * insert element div[test_attr] after subject_parent: `FAIL` * insert element div.test after subject: `FAIL` * add the class 'test' again to the element inserted after subject: `FAIL` * insert element div[test_attr] after subject: `FAIL` * insert element div.test after subject_child: `FAIL` * add the class 'test' again to the element inserted after subject_child: `FAIL` * insert element div[test_attr] after subject_child: `FAIL` * insert element div.test after subject_descendant: `FAIL` * add the class 'test' again to the element inserted after subject_descendant: `FAIL` * insert element div[test_attr] after subject_descendant: `FAIL` * insert element div.test after next_sibling: `FAIL` * add the class 'test' again to the element inserted after next_sibling: `FAIL` * insert element div[test_attr] after next_sibling: `FAIL` * insert element div.test after next_sibling_child: `FAIL` * add the class 'test' again to the element inserted after next_sibling_child: `FAIL` * insert element div[test_attr] after next_sibling_child: `FAIL` * insert element div.test after next_sibling_descendant: `FAIL` * add the class 'test' again to the element inserted after next_sibling_descendant: `FAIL` * insert element div[test_attr] after next_sibling_descendant: `FAIL` * insert tree div>div.test before subject_parent: `FAIL` * add the class 'test' again to the element in the tree inserted before subject_parent: `FAIL` * insert element div>div[test_attr] before subject_parent: `FAIL` * insert tree div>div.test before subject: `FAIL` * add the class 'test' again to the element in the tree inserted before subject: `FAIL` * insert element div>div[test_attr] before subject: `FAIL` * insert tree div>div.test before subject_child: `FAIL` * add the class 'test' again to the element in the tree inserted before subject_child: `FAIL` * insert element div>div[test_attr] before subject_child: `FAIL` * insert tree div>div.test before subject_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted before subject_descendant: `FAIL` * insert element div>div[test_attr] before subject_descendant: `FAIL` * insert tree div>div.test before next_sibling: `FAIL` * add the class 'test' again to the element in the tree inserted before next_sibling: `FAIL` * insert element div>div[test_attr] before next_sibling: `FAIL` * insert tree div>div.test before next_sibling_child: `FAIL` * add the class 'test' again to the element in the tree inserted before next_sibling_child: `FAIL` * insert element div>div[test_attr] before next_sibling_child: `FAIL` * insert tree div>div.test before next_sibling_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted before next_sibling_descendant: `FAIL` * insert element div>div[test_attr] before next_sibling_descendant: `FAIL` * insert tree div>div.test after subject_ancestor: `FAIL` * add the class 'test' again to the element in the tree inserted after subject_ancestor: `FAIL` * insert element div>div[test_attr] after subject_ancestor: `FAIL` * insert tree div>div.test after subject_parent: `FAIL` * add the class 'test' again to the element in the tree inserted after subject_parent: `FAIL` * insert element div>div[test_attr] after subject_parent: `FAIL` * insert tree div>div.test after subject: `FAIL` * add the class 'test' again to the element in the tree inserted after subject: `FAIL` * insert element div>div[test_attr] after subject: `FAIL` * insert tree div>div.test after subject_child: `FAIL` * add the class 'test' again to the element in the tree inserted after subject_child: `FAIL` * insert element div>div[test_attr] after subject_child: `FAIL` * insert tree div>div.test after subject_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted after subject_descendant: `FAIL` * insert element div>div[test_attr] after subject_descendant: `FAIL` * insert tree div>div.test after next_sibling: `FAIL` * add the class 'test' again to the element in the tree inserted after next_sibling: `FAIL` * insert element div>div[test_attr] after next_sibling: `FAIL` * insert tree div>div.test after next_sibling_child: `FAIL` * add the class 'test' again to the element in the tree inserted after next_sibling_child: `FAIL` * insert element div>div[test_attr] after next_sibling_child: `FAIL` * insert tree div>div.test after next_sibling_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted after next_sibling_descendant: `FAIL` * insert element div>div[test_attr] after next_sibling_descendant: `FAIL` * [/css/selectors/invalidation/has-in-parent-position.html](https://wpt.live/css/selectors/invalidation/has-in-parent-position.html) [[wpt.fyi](https://wpt.fyi/results/css/selectors/invalidation/has-in-parent-position.html)] * add .test to subject: `FAIL` * add .test to subject_child: `FAIL` * add .test to subject_descendant: `FAIL` * insert element div.test before subject: `FAIL` * add the class 'test' again to the element inserted before subject: `FAIL` * insert element div[test_attr] before subject: `FAIL` * insert element div.test before subject_child: `FAIL` * add the class 'test' again to the element inserted before subject_child: `FAIL` * insert element div[test_attr] before subject_child: `FAIL` * insert element div.test before subject_descendant: `FAIL` * add the class 'test' again to the element inserted before subject_descendant: `FAIL` * insert element div[test_attr] before subject_descendant: `FAIL` * insert element div.test after subject_parent: `FAIL` * add the class 'test' again to the element inserted after subject_parent: `FAIL` * insert element div[test_attr] after subject_parent: `FAIL` * insert element div.test after subject: `FAIL` * add the class 'test' again to the element inserted after subject: `FAIL` * insert element div[test_attr] after subject: `FAIL` * insert element div.test after subject_child: `FAIL` * add the class 'test' again to the element inserted after subject_child: `FAIL` * insert element div[test_attr] after subject_child: `FAIL` * insert element div.test after subject_descendant: `FAIL` * add the class 'test' again to the element inserted after subject_descendant: `FAIL` * insert element div[test_attr] after subject_descendant: `FAIL` * insert tree div>div.test before subject: `FAIL` * add the class 'test' again to the element in the tree inserted before subject: `FAIL` * insert element div>div[test_attr] before subject: `FAIL` * insert tree div>div.test before subject_child: `FAIL` * add the class 'test' again to the element in the tree inserted before subject_child: `FAIL` * insert element div>div[test_attr] before subject_child: `FAIL` * insert tree div>div.test before subject_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted before subject_descendant: `FAIL` * insert element div>div[test_attr] before subject_descendant: `FAIL` * insert tree div>div.test after subject_parent: `FAIL` * add the class 'test' again to the element in the tree inserted after subject_parent: `FAIL` * insert element div>div[test_attr] after subject_parent: `FAIL` * insert tree div>div.test after subject: `FAIL` * add the class 'test' again to the element in the tree inserted after subject: `FAIL` * insert element div>div[test_attr] after subject: `FAIL` * insert tree div>div.test after subject_child: `FAIL` * add the class 'test' again to the element in the tree inserted after subject_child: `FAIL` * insert element div>div[test_attr] after subject_child: `FAIL` * insert tree div>div.test after subject_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted after subject_descendant: `FAIL` * insert element div>div[test_attr] after subject_descendant: `FAIL` * [/css/selectors/invalidation/has-in-sibling-position.html](https://wpt.live/css/selectors/invalidation/has-in-sibling-position.html) [[wpt.fyi](https://wpt.fyi/results/css/selectors/invalidation/has-in-sibling-position.html)] * add .test to previous_sibling_child: `FAIL` * add .test to previous_sibling_descendant: `FAIL` * add .test to subject: `FAIL` * add .test to next_sibling: `FAIL` * add .test to next_sibling_child: `FAIL` * add .test to next_sibling_descendant: `FAIL` * insert element div.test before previous_sibling_child: `FAIL` * add the class 'test' again to the element inserted before previous_sibling_child: `FAIL` * insert element div[test_attr] before previous_sibling_child: `FAIL` * insert element div.test before previous_sibling_descendant: `FAIL` * add the class 'test' again to the element inserted before previous_sibling_descendant: `FAIL` * insert element div[test_attr] before previous_sibling_descendant: `FAIL` * insert element div.test before subject: `FAIL` * add the class 'test' again to the element inserted before subject: `FAIL` * add the class 'test' to the element inserted again before subject: `FAIL` * insert element div[test_attr] before subject: `FAIL` * insert element div.test before next_sibling: `FAIL` * add the class 'test' again to the element inserted before next_sibling: `FAIL` * add the class 'test' to the element inserted again before next_sibling: `FAIL` * insert element div[test_attr] before next_sibling: `FAIL` * insert element div.test before next_sibling_child: `FAIL` * add the class 'test' again to the element inserted before next_sibling_child: `FAIL` * insert element div[test_attr] before next_sibling_child: `FAIL` * insert element div.test before next_sibling_descendant: `FAIL` * add the class 'test' again to the element inserted before next_sibling_descendant: `FAIL` * insert element div[test_attr] before next_sibling_descendant: `FAIL` * insert element div.test after previous_sibling: `FAIL` * add the class 'test' again to the element inserted after previous_sibling: `FAIL` * add the class 'test' to the element inserted again after previous_sibling: `FAIL` * insert element div[test_attr] after previous_sibling: `FAIL` * insert element div.test after previous_sibling_child: `FAIL` * add the class 'test' again to the element inserted after previous_sibling_child: `FAIL` * insert element div[test_attr] after previous_sibling_child: `FAIL` * insert element div.test after previous_sibling_descendant: `FAIL` * add the class 'test' again to the element inserted after previous_sibling_descendant: `FAIL` * insert element div[test_attr] after previous_sibling_descendant: `FAIL` * insert element div.test after subject: `FAIL` * add the class 'test' again to the element inserted after subject: `FAIL` * add the class 'test' to the element inserted again after subject: `FAIL` * insert element div[test_attr] after subject: `FAIL` * insert element div.test after next_sibling: `FAIL` * add the class 'test' again to the element inserted after next_sibling: `FAIL` * add the class 'test' to the element inserted again after next_sibling: `FAIL` * insert element div[test_attr] after next_sibling: `FAIL` * insert element div.test after next_sibling_child: `FAIL` * add the class 'test' again to the element inserted after next_sibling_child: `FAIL` * insert element div[test_attr] after next_sibling_child: `FAIL` * insert element div.test after next_sibling_descendant: `FAIL` * add the class 'test' again to the element inserted after next_sibling_descendant: `FAIL` * insert element div[test_attr] after next_sibling_descendant: `FAIL` * insert tree div>div.test before previous_sibling: `FAIL` * add the class 'test' again to the element in the tree inserted before previous_sibling: `FAIL` * add the class 'test' to the element in the tree inserted again before previous_sibling: `FAIL` * insert element div>div[test_attr] before previous_sibling: `FAIL` * insert tree div>div.test before previous_sibling_child: `FAIL` * add the class 'test' again to the element in the tree inserted before previous_sibling_child: `FAIL` * insert element div>div[test_attr] before previous_sibling_child: `FAIL` * insert tree div>div.test before previous_sibling_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted before previous_sibling_descendant: `FAIL` * insert element div>div[test_attr] before previous_sibling_descendant: `FAIL` * insert tree div>div.test before subject: `FAIL` * add the class 'test' again to the element in the tree inserted before subject: `FAIL` * add the class 'test' to the element in the tree inserted again before subject: `FAIL` * insert element div>div[test_attr] before subject: `FAIL` * insert tree div>div.test before next_sibling: `FAIL` * add the class 'test' again to the element in the tree inserted before next_sibling: `FAIL` * add the class 'test' to the element in the tree inserted again before next_sibling: `FAIL` * insert element div>div[test_attr] before next_sibling: `FAIL` * insert tree div>div.test before next_sibling_child: `FAIL` * add the class 'test' again to the element in the tree inserted before next_sibling_child: `FAIL` * insert element div>div[test_attr] before next_sibling_child: `FAIL` * insert tree div>div.test before next_sibling_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted before next_sibling_descendant: `FAIL` * insert element div>div[test_attr] before next_sibling_descendant: `FAIL` * insert tree div>div.test after previous_sibling: `FAIL` * add the class 'test' again to the element in the tree inserted after previous_sibling: `FAIL` * add the class 'test' to the element in the tree inserted again after previous_sibling: `FAIL` * insert element div>div[test_attr] after previous_sibling: `FAIL` * insert tree div>div.test after previous_sibling_child: `FAIL` * add the class 'test' again to the element in the tree inserted after previous_sibling_child: `FAIL` * insert element div>div[test_attr] after previous_sibling_child: `FAIL` * insert tree div>div.test after previous_sibling_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted after previous_sibling_descendant: `FAIL` * insert element div>div[test_attr] after previous_sibling_descendant: `FAIL` * insert tree div>div.test after subject: `FAIL` * add the class 'test' again to the element in the tree inserted after subject: `FAIL` * add the class 'test' to the element in the tree inserted again after subject: `FAIL` * insert element div>div[test_attr] after subject: `FAIL` * insert tree div>div.test after next_sibling: `FAIL` * add the class 'test' again to the element in the tree inserted after next_sibling: `FAIL` * add the class 'test' to the element in the tree inserted again after next_sibling: `FAIL` * insert element div>div[test_attr] after next_sibling: `FAIL` * insert tree div>div.test after next_sibling_child: `FAIL` * add the class 'test' again to the element in the tree inserted after next_sibling_child: `FAIL` * insert element div>div[test_attr] after next_sibling_child: `FAIL` * insert tree div>div.test after next_sibling_descendant: `FAIL` * add the class 'test' again to the element in the tree inserted after next_sibling_descendant: `FAIL` * insert element div>div[test_attr] after next_sibling_descendant: `FAIL` (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ecf7aed8d508 [wpt PR 34124] - Fix potential test error by using different color for testing attribute., a=testonly

https://hg.mozilla.org/mozilla-central/rev/ecf7aed8d508

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: