1770158 - Use double-conversion library instead of dtoa for string-to-double conversion

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1770158 part 1 - Add MFBT_API to StringToDouble. r?glandium!

The update script successfully applies this diff to the upstream code.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1770158 part 2 - Assert ComputeAccurateDecimalInteger parsed the whole string. r?anba!

Depends on D146878

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1770158 part 3 - Use GetDecimal instead of ComputeAccurateDecimalInteger. r?anba!

Rename GetDecimalNonInteger to GetDecimal because it's now also used for (large)
integers.

Depends on D146879

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1770158 part 4 - Use double-conversion library instead of dtoa in GetDecimal. r?anba!

Depends on D146880

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1770158 part 5 - Use double-conversion library instead of dtoa in js_strtod. r?anba!

Depends on D146881

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1770158 part 6 - Make js_strtod and callers infallible. r?anba!

Also removes the now-unused cx argument.

Depends on D146882

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1770158 part 7 - Remove unused functions from dtoa.c. r?anba!

There's more we can clean up after this and hopefully the remaining code can be
simplified a lot, but this deletes the functions that are no longer used.

Depends on D146883

Comment 8

[Jan de Mooij [:jandem]]

Attachment: Bug 1770158 part 8 - Replace MaybeStringToNumber with LinearStringToNumber. r?anba!

Depends on D146884

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8f25b3c8cda
part 1 - Add MFBT_API to StringToDouble. r=glandium
https://hg.mozilla.org/integration/autoland/rev/4836f0036205
part 2 - Assert ComputeAccurateDecimalInteger parsed the whole string. r=anba
https://hg.mozilla.org/integration/autoland/rev/88e821c3ab03
part 3 - Use GetDecimal instead of ComputeAccurateDecimalInteger. r=anba
https://hg.mozilla.org/integration/autoland/rev/fe54f23a07e1
part 4 - Use double-conversion library instead of dtoa in GetDecimal. r=anba
https://hg.mozilla.org/integration/autoland/rev/29782f99b7fc
part 5 - Use double-conversion library instead of dtoa in js_strtod. r=anba
https://hg.mozilla.org/integration/autoland/rev/54b64e18266d
part 6 - Make js_strtod and callers infallible. r=anba
https://hg.mozilla.org/integration/autoland/rev/452717550d2c
part 7 - Remove unused functions from dtoa.c. r=anba
https://hg.mozilla.org/integration/autoland/rev/9a17a5ec9869
part 8 - Replace MaybeStringToNumber with LinearStringToNumber. r=anba

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f8f25b3c8cda
https://hg.mozilla.org/mozilla-central/rev/4836f0036205
https://hg.mozilla.org/mozilla-central/rev/88e821c3ab03
https://hg.mozilla.org/mozilla-central/rev/fe54f23a07e1
https://hg.mozilla.org/mozilla-central/rev/29782f99b7fc
https://hg.mozilla.org/mozilla-central/rev/54b64e18266d
https://hg.mozilla.org/mozilla-central/rev/452717550d2c
https://hg.mozilla.org/mozilla-central/rev/9a17a5ec9869