Closed Bug 1770158 Opened 2 years ago Closed 2 years ago

Use double-conversion library instead of dtoa for string-to-double conversion

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(8 files)

No description provided.

The update script successfully applies this diff to the upstream code.

Rename GetDecimalNonInteger to GetDecimal because it's now also used for (large)
integers.

Depends on D146879

Also removes the now-unused cx argument.

Depends on D146882

There's more we can clean up after this and hopefully the remaining code can be
simplified a lot, but this deletes the functions that are no longer used.

Depends on D146883

Attachment #9277809 - Attachment description: Bug 1770158 part 8 - Simplify MaybeStringToNumber now that js_strtod is infallible. r?anba! → Bug 1770158 part 8 - Replace MaybeStringToNumber with LinearStringToNumber. r?anba!
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f8f25b3c8cda
part 1 - Add MFBT_API to StringToDouble. r=glandium
https://hg.mozilla.org/integration/autoland/rev/4836f0036205
part 2 - Assert ComputeAccurateDecimalInteger parsed the whole string. r=anba
https://hg.mozilla.org/integration/autoland/rev/88e821c3ab03
part 3 - Use GetDecimal instead of ComputeAccurateDecimalInteger. r=anba
https://hg.mozilla.org/integration/autoland/rev/fe54f23a07e1
part 4 - Use double-conversion library instead of dtoa in GetDecimal. r=anba
https://hg.mozilla.org/integration/autoland/rev/29782f99b7fc
part 5 - Use double-conversion library instead of dtoa in js_strtod. r=anba
https://hg.mozilla.org/integration/autoland/rev/54b64e18266d
part 6 - Make js_strtod and callers infallible. r=anba
https://hg.mozilla.org/integration/autoland/rev/452717550d2c
part 7 - Remove unused functions from dtoa.c. r=anba
https://hg.mozilla.org/integration/autoland/rev/9a17a5ec9869
part 8 - Replace MaybeStringToNumber with LinearStringToNumber. r=anba
Blocks: 1771874
Blocks: 1759123
Blocks: 1767268
Blocks: 520629
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: