Use double-conversion library instead of dtoa for string-to-double conversion
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 2 open bugs)
Details
Attachments
(8 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
|
Assignee | |
Comment 1•11 months ago
|
||
The update script successfully applies this diff to the upstream code.
|
|
Assignee | |
Comment 2•11 months ago
|
||
Depends on D146878
|
|
Assignee | |
Comment 3•11 months ago
|
||
Rename GetDecimalNonInteger to GetDecimal because it's now also used for (large)
integers.
Depends on D146879
|
|
Assignee | |
Comment 4•11 months ago
|
||
Depends on D146880
|
|
Assignee | |
Comment 5•11 months ago
|
||
Depends on D146881
|
|
Assignee | |
Comment 6•11 months ago
|
||
Also removes the now-unused cx argument.
Depends on D146882
|
|
Assignee | |
Comment 7•11 months ago
|
||
There's more we can clean up after this and hopefully the remaining code can be
simplified a lot, but this deletes the functions that are no longer used.
Depends on D146883
|
|
Assignee | |
Comment 8•10 months ago
|
||
Depends on D146884
|
||
Updated•10 months ago
|
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8f25b3c8cda part 1 - Add MFBT_API to StringToDouble. r=glandium https://hg.mozilla.org/integration/autoland/rev/4836f0036205 part 2 - Assert ComputeAccurateDecimalInteger parsed the whole string. r=anba https://hg.mozilla.org/integration/autoland/rev/88e821c3ab03 part 3 - Use GetDecimal instead of ComputeAccurateDecimalInteger. r=anba https://hg.mozilla.org/integration/autoland/rev/fe54f23a07e1 part 4 - Use double-conversion library instead of dtoa in GetDecimal. r=anba https://hg.mozilla.org/integration/autoland/rev/29782f99b7fc part 5 - Use double-conversion library instead of dtoa in js_strtod. r=anba https://hg.mozilla.org/integration/autoland/rev/54b64e18266d part 6 - Make js_strtod and callers infallible. r=anba https://hg.mozilla.org/integration/autoland/rev/452717550d2c part 7 - Remove unused functions from dtoa.c. r=anba https://hg.mozilla.org/integration/autoland/rev/9a17a5ec9869 part 8 - Replace MaybeStringToNumber with LinearStringToNumber. r=anba
|
||
Comment 10•10 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f8f25b3c8cda
https://hg.mozilla.org/mozilla-central/rev/4836f0036205
https://hg.mozilla.org/mozilla-central/rev/88e821c3ab03
https://hg.mozilla.org/mozilla-central/rev/fe54f23a07e1
https://hg.mozilla.org/mozilla-central/rev/29782f99b7fc
https://hg.mozilla.org/mozilla-central/rev/54b64e18266d
https://hg.mozilla.org/mozilla-central/rev/452717550d2c
https://hg.mozilla.org/mozilla-central/rev/9a17a5ec9869
Description
•