1759123 - Remove helper thread JSContexts

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Jan de Mooij [:jandem]]

At this point helper threads only use a JSContext for the parse tasks. After Stencil, it should now be feasible to remove helper thread JSContexts completely. Remaining dependencies include things like:

• Exception handling
• Stack limit checks
• TempAllocPolicy
• cx->dtoaState

We could replace these uses with a stack-allocated class that contains just the data the frontend needs (ParseContext is already taken, let's call it FrontendContext for now). This would let us decouple the frontend from JSContext, very similar to how other Stencil changes decoupled the parser from the VM.

For the stack limit checks, we could copy the stack limit from the main thread's JSContext to the FrontendContext if we're parsing on the main thread. If we're parsing off-thread, we would do something similar to what we do now in JSContext::setHelperThread.

When parsing is finished, exceptions would be converted from the FrontendContext to an actual JS exception in JSContext. This will let us unify exception handling in the frontend (instead of having different code paths for main thread vs helper thread contexts).

Comment 1

[Jan de Mooij [:jandem]]

Bug 1770158 and bug 1771874 will take care of cx->dtoaState. (The remaining use is for non-base-10 double to string conversion and that's not used by the frontend.)

Comment 2

[Ted Campbell [:tcampbell]]

The ORB M1 milestone can use existing parser APIs, so we can move this to M2 as potential performance work.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1759123 - Part 1: Remove GlobalHelperThreadState::helperContexts_. r?nbp!

Depends on D183841

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1759123 - Part 2: Remove JSContext::isHelperThreadContext. r?nbp!

Depends on D183842

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1759123 - Part 3: Remove JSContext::errors_. r?nbp!

Depends on D183843

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1759123 - Part 4: Remove JSContext::isMainThreadContext. r?nbp!

Depends on D183844

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1759123 - Part 5: Remove JSContext::kind_. r?nbp!

Depends on D183845

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6ec25d30279
Part 1: Remove GlobalHelperThreadState::helperContexts_. r=nbp
https://hg.mozilla.org/integration/autoland/rev/fb6e411d1d73
Part 2: Remove JSContext::isHelperThreadContext. r=nbp
https://hg.mozilla.org/integration/autoland/rev/01d39e78a971
Part 3: Remove JSContext::errors_. r=nbp
https://hg.mozilla.org/integration/autoland/rev/574097795dd2
Part 4: Remove JSContext::isMainThreadContext. r=nbp
https://hg.mozilla.org/integration/autoland/rev/0b97cab35896
Part 5: Remove JSContext::kind_. r=nbp

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b6ec25d30279
https://hg.mozilla.org/mozilla-central/rev/fb6e411d1d73
https://hg.mozilla.org/mozilla-central/rev/01d39e78a971
https://hg.mozilla.org/mozilla-central/rev/574097795dd2
https://hg.mozilla.org/mozilla-central/rev/0b97cab35896