1770204 - Simplify breakpoint list selectors

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Hubert Boma Manilla (:bomsy)]

Simplify breakpoint list selectors

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1770204 - [devtools] Simplify breakpoint list selectors r=nchevobbe

The selector is already sorting the breakpoints,
so there is no need to re-sort them in the component.

Also Array.sort(stringA-stringB) was misbehaving.

Then I'm using getSourcesMap in order to avoid calling getBreakpointList many times.
Otherwise getSourcesForBreakpoints has to receive the state object
in order to retrieve the source objects.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1459819402b
[devtools] Simplify breakpoint list selectors r=nchevobbe

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43ac17a9f0e2
Backed out 2 changesets (bug 1770204, bug 1770205) for devtools faolires on browser_dbg-html-breakpoints.js. CLOSED TREE

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b64de7fd715
[devtools] Simplify breakpoint list selectors r=nchevobbe

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9b64de7fd715

Comment 6

[Julian Descottes [:jdescottes]]

Performance alert (improvement) https://treeherder.mozilla.org/perfherder/alerts?id=34233&hideDwnToInv=0