Closed Bug 1770204 Opened 3 months ago Closed 3 months ago

Simplify breakpoint list selectors

Categories

(DevTools :: Debugger, enhancement)

enhancement

Tracking

(firefox102 fixed)

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Simplify breakpoint list selectors

The selector is already sorting the breakpoints,
so there is no need to re-sort them in the component.

Also Array.sort(stringA-stringB) was misbehaving.

Then I'm using getSourcesMap in order to avoid calling getBreakpointList many times.
Otherwise getSourcesForBreakpoints has to receive the state object
in order to retrieve the source objects.

Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1459819402b
[devtools] Simplify breakpoint list selectors r=nchevobbe
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43ac17a9f0e2
Backed out 2 changesets (bug 1770204, bug 1770205) for devtools faolires on browser_dbg-html-breakpoints.js. CLOSED TREE
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b64de7fd715
[devtools] Simplify breakpoint list selectors r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.