1770402 - For right-click on contacts or address books, context menus open at a distance from mouse pointer

Status: VERIFIED FIXED

(Thunderbird :: Address Book, defect, P3)

Description

[Thomas D. (:thomas8)]

It's pretty inconvenient when you right-click on an AB or contact in address book, and the context menu pops up somewhere else, but not where you clicked, requiring extra mouse moves. Horizontal layout is most affected.

STR

• right-click on the icon or in the middle of an address book item in directory pane
• right-click on the icon, the first name, or in the middle of a contact item in the list of contacts
• Do Change the list order > Switch to horizontal layout, and right-click e.g. on the email address of a contact.
• For comparison, right-click anywhere on a message in message list.

Actual

• context menu pops up at a distance from click position / mouse pointer
• in horizontal layout, depending on where you clicked, the context menu might be very far away from current pointer position.

Expected

• context menu should pop up at the click position, i.e. at the mouse pointer (as happens when right-clicking on a message in message list).

Comment 1

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Remote context menu after right-clicking on a contact in horizontal layout

Horizontal mode: Have a safe journey from where you clicked to where the context menu pops up!

Comment 2

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Remote context menu after right-clicking on a contact in horizontal layout

Horizontal mode: Have a safe journey from where you clicked to where the context menu pops up!
New screenshot to visualize the mouse journey after right-click.

Comment 3

[Thomas D. (:thomas8)]

Attachment: Screenshot 2: Distant context menu after right-clicking on a contact in vertical layout

We should only pop up the context menu at the triple dots when the triple dots were clicked, to avoid inconvenient mouse moves for users who prefer to right-click anywhere on the contact (which is a far bigger hence faster click target than the triple dots).

Comment 4

[Geoff Lankow (:darktrojan)]

That's … odd. And it's only happening on Windows.

Comment 5

[Geoff Lankow (:darktrojan)]

We've lost the event.buttons value, which should be 2 in these places (it's 0).

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1770402 - Fix Address Book context menus on Windows. r=#thunderbird-reviewers

Uses something other than event.buttons to check if the contextmenu event comes from a mouse click. That property is buggy (bug 1770671).

Also moves the cards list context menu to the middle of the selected row when opened by keyboard, which looks a bit better now we have a layout with long rows.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e890e942c2a9
Fix Address Book context menus on Windows. r=mkmelin

Comment 8

[WaltS48 [:walts48]]

I just updated to Build ID 20220525102342 on Windows 10 and both views look fixed.