1770452 - [wpt-sync] Sync PR 34146 - Add test to confirm calling Request constructor without `new` throws an error

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34146 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34146
Details from upstream follow.

Jake Champion <[e-mail]> wrote:

Add test to confirm calling Request constructor without new throws an error

The Request interface defines a Web IDL constructor and the Web IDL constructor definition states:

If the interface is declared with a constructor operation, then the interface object can be called as a constructor to create an object that implements that interface. Calling that interface as a function will throw an exception.
https://webidl.spec.whatwg.org/#interface-object

This commit adds a test to ensure that calling Request as a function will throw an exception.

I couldn't find an already existing test case for this, which is why I have created this pull-request.
If this test case addition is correct, I can add test cases for other interfaces which are missing this type of test case

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8bd0ec99dbe9735117ae63d034483c283ed489d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 22 subtests

Status Summary

Firefox

OK : 4
PASS: 84
FAIL: 4

Chrome

OK : 4
PASS: 84
FAIL: 4

Safari

OK : 4
PASS: 88

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fetch/api/request/request-error.any.serviceworker.html [wpt.fyi]
  • RequestInit's window is not null: FAIL (Chrome: FAIL, Safari: PASS)
• /fetch/api/request/request-error.any.sharedworker.html [wpt.fyi]
  • RequestInit's window is not null: FAIL (Chrome: FAIL, Safari: PASS)
• /fetch/api/request/request-error.any.html [wpt.fyi]
  • RequestInit's window is not null: FAIL (Chrome: FAIL, Safari: PASS)
• /fetch/api/request/request-error.any.worker.html [wpt.fyi]
  • RequestInit's window is not null: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2696b81b9666
[wpt PR 34146] - Add test to confirm calling Request constructor without `new` throws an error, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2696b81b9666