1770476 - Support for returning primitive values from "script.evaluate" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With bug 1742979 we will get basic support for script.evaluate. This bug covers the addition of returning primitive protocol values and the creation of appropriate webdriver and maybe xpcshell tests.

Comment 1

[Julian Descottes [:jdescottes]]

Since we already have primitive values serialization, adding this soon will enable to write more tests for script.evaluate

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770476 - [bidi] Add support for return values in script.evaluate

Depends on D148907

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770476 - [wdspec] Add script evaluate tests for frame context and CSP

Depends on D149411

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770476 - [wdspec] Use script.evaluate in test_navigator_webdriver_enabled

Depends on D149646

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For the wdspec tests we will need bug 1770705 (downstream sync from Maxim's PR) first.

Comment 6

[Julian Descottes [:jdescottes]]

Adding leave open. I am landing the implementation but I want to land the test fixes once the sync is done in Bug 1770705

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f91ee506e95a
[bidi] Add support for return values in script.evaluate r=webdriver-reviewers,whimboo

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/f91ee506e95a

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3eedb52aae33
[wdspec] Use script.evaluate in test_navigator_webdriver_enabled r=webdriver-reviewers,whimboo

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3eedb52aae33