1770792 - Add webdriver tests for "script.evaluate' for serialization of complex objects with simple value field

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This bug covers the addition of WebDriver tests for script.evaluate for serializing complex objects with simple value fields. It requires bug 1770752 to be fixed first.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1770792 - [wdspec] Format script.evaluate tests.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1770792 - [wdspec] Add webdriver tests for script.evaluate for serialization of primitive/simple values.

Depends on D150534

Comment 3

[Phabricator Automation]

Comment on attachment 9283341 [details]
Bug 1770792 - [wdspec] Format script.evaluate tests.

Revision D150534 was moved to bug 1775270. Setting attachment 9283341 [details] to obsolete.

Comment 4

[Phabricator Automation]

Comment on attachment 9283342 [details]
Bug 1770792 - [wdspec] Add webdriver tests for script.evaluate for serialization of primitive/simple values.

Revision D150535 was moved to bug 1775270. Setting attachment 9283342 [details] to obsolete.

Comment 5

[Alexandra Borovova [:Sasha]]

Maxim notified me that there are already some tests in their repository which we could use as a reference: https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/tests/test_serialization.py

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Everything seems to have been done here. Closing as fixed.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We should include the enhancements for Javascript Object serialization into our release notes but do not want to mention the script.evaluate command given that it is still experimental.

Comment 8

[Julian Descottes [:jdescottes]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #7)

We should include the enhancements for Javascript Object serialization into our release notes but do not want to mention the script.evaluate command given that it is still experimental.

I was looking at what to include in release notes. In 104, the only implementation changes which landed for the Serialization are:

• throwing for invalid types https://hg.mozilla.org/mozilla-central/rev/29be5540259989e22b15d11c9e49c7471071b636
• fixes for incorrect/missing toString etc... https://hg.mozilla.org/mozilla-central/rev/2eab01956e47b3947d13e6b81cdcc64fa479a334

The first one is not really exposed to users, and the second one is really an edge case. Otherwise we added tests, but the main implementation changes landed in 103 (we mentioned them in the release notes last time, for what it's worth). I'll think a bit more about it, but I might not mention serialization changes in the release notes.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I checked myself and you are right. Lets remove the relnote whiteboard entry given that nothing needs to be included for serialization. Thanks for checking!