Closed Bug 1770479 Opened 3 years ago Closed 3 years ago

Update wgpu to new version 1ec26784c45e8453dea8e1d5331483abbf8e4022 from 2022-05-19 21:10:27

Categories

(Core :: Graphics: WebGPU, enhancement)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1778629
Tracking Status
firefox102 --- affected

People

(Reporter: update-bot, Assigned: jimb)

Details

(Whiteboard: [3pl-filed][task_id: CJED1q_WSZCF4ZfxKVkaAQ])

Attachments

(1 obsolete file)

This update covers 38 commits, including 13 new upstream commits I've never filed a bug on before. (They're the top 13.):


1ec26784c45e8453dea8e1d5331483abbf8e4022 by Ashley

https://github.com/gfx-rs/wgpu-/commit/1ec26784c45e8453dea8e1d5331483abbf8e4022
Authored: 2022-05-19 23:10:27 +0200
Committed: 2022-05-19 17:10:27 -0400

[Gles] Fix clearing depth and stencil at the same time (#2675)

Files Added:

  • wgpu-hal/src/gles/command.rs
  • wgpu-hal/src/gles/mod.rs
  • wgpu-hal/src/gles/queue.rs

b53a8bcb1733374f00c738d7b2622da85dc3386d by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/b53a8bcb1733374f00c738d7b2622da85dc3386d
Authored: 2022-05-19 10:10:47 -0700
Committed: 2022-05-19 13:10:47 -0400

New function: Global::create_buffer_error. (#2673)

Files Added:

  • wgpu-core/src/device/mod.rs

8b2e6fe3a22837403fdaf5ecc5bf37d5297340cd by Jinlei Li

https://github.com/gfx-rs/wgpu-/commit/8b2e6fe3a22837403fdaf5ecc5bf37d5297340cd
Authored: 2022-05-19 12:09:22 +0800
Committed: 2022-05-18 21:09:22 -0700

Roll naga to 571302e (50 revisions) (#2672)

Files Added:

  • Cargo.lock
  • wgpu-core/Cargo.toml
  • wgpu-hal/Cargo.toml
  • wgpu/Cargo.toml

0c1233b8342d974fe8fa608b5d71c8f8d058b80f by Jinlei Li

https://github.com/gfx-rs/wgpu-/commit/0c1233b8342d974fe8fa608b5d71c8f8d058b80f
Authored: 2022-05-19 00:38:53 +0800
Committed: 2022-05-18 12:38:53 -0400

Move TEXTURE_COMPRESSION_ETC2 | ASTC_LDR to web section to match spec (#2671)

Files Added:

  • player/tests/data/clear-buffer-texture.ron
  • player/tests/data/pipeline-statistics-query.ron
  • wgpu-types/src/lib.rs

36f8d83e5c6ccf021a3160c810aa966ad6861ecd by Jinlei Li

https://github.com/gfx-rs/wgpu-/commit/36f8d83e5c6ccf021a3160c810aa966ad6861ecd
Authored: 2022-05-18 00:17:06 +0800
Committed: 2022-05-17 12:17:06 -0400

Roll wasm32 target dependencies to latest (#2669)

Files Added:

  • Cargo.lock
  • run-wasm/Cargo.toml
  • wgpu/Cargo.toml

f5c2ff11d058eb65d51dc60b2d9196baf97481f1 by i509VCB

https://github.com/gfx-rs/wgpu-/commit/f5c2ff11d058eb65d51dc60b2d9196baf97481f1
Authored: 2022-05-17 01:13:58 -0500
Committed: 2022-05-17 06:13:58 +0000

Adapter and Instance as_hal functions (#2663)

These functions are added to allow lower level access to adapter and instance from backends.

Files Added:

  • wgpu-core/src/hub.rs
  • wgpu-core/src/resource.rs
  • wgpu/src/backend/direct.rs
  • wgpu/src/lib.rs

26f96c7dfe3dd5a5015de69842d7738835b662e7 by Jinlei Li

https://github.com/gfx-rs/wgpu-/commit/26f96c7dfe3dd5a5015de69842d7738835b662e7
Authored: 2022-05-17 14:11:05 +0800
Committed: 2022-05-17 02:11:05 -0400

Add DEPTH32FLOAT_STENCIL8 featue (#2664)

Files Added:

  • deno_webgpu/src/lib.rs
  • player/tests/data/pipeline-statistics-query.ron
  • wgpu-core/src/command/transfer.rs
  • wgpu-core/src/conv.rs
  • wgpu-core/src/validation.rs
  • wgpu-hal/src/auxil/dxgi/conv.rs
  • wgpu-hal/src/dx12/adapter.rs
  • wgpu-hal/src/gles/adapter.rs
  • wgpu-hal/src/gles/conv.rs
  • wgpu-hal/src/lib.rs
  • wgpu-hal/src/metal/adapter.rs
  • wgpu-hal/src/vulkan/adapter.rs
  • wgpu-hal/src/vulkan/conv.rs
  • wgpu-types/src/lib.rs
  • wgpu/src/backend/web.rs
  • wgpu/tests/clear_texture.rs

b51fd851be51cfe40c937ef789a44244e7dc2971 by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/b51fd851be51cfe40c937ef789a44244e7dc2971
Authored: 2022-05-16 13:47:49 -0700
Committed: 2022-05-16 14:26:36 -0700

Report invalid pipelines in render bundles as errors, not panics.

Fixes #2665.

Files Added:

  • wgpu-core/src/command/bundle.rs

c608ee0bbea3132efc410f06bb9e76b4584e49a3 by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/c608ee0bbea3132efc410f06bb9e76b4584e49a3
Authored: 2022-05-15 22:16:53 -0700
Committed: 2022-05-16 01:16:53 -0400

Accept both parking-lot 0.11 and 0.12.*, to avoid windows-rs. (#2660)

In parking_lot 0.12 and parking_lot_core 0.9.0, those crates switched
from the winapi crate to the official Microsoft windows-sys crate.
This is fine, except that windows-sys and its dependencies are even
larger than winapi. Some users may wish to stick with winapi for the
time being; this change allows wgpu to accommodate them.

Files Added:

  • Cargo.lock
  • wgpu-core/Cargo.toml
  • wgpu-hal/Cargo.toml
  • wgpu/Cargo.toml

202d81a64a85f4587d0074ad3d792ad87a625bff by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/202d81a64a85f4587d0074ad3d792ad87a625bff
Authored: 2022-05-15 12:18:05 -0700
Committed: 2022-05-15 15:18:05 -0400

Move set_index_buffer FFI functions back into wgpu. (#2661)

It's very odd to have almost all the render pass and compute pass ffi
functions in wgpu except for the set_index_buffer functions, which
live in Firefox. I'd like to remove these from Firefox and put them
back next to their companions.

These functions were originally removed from wgpu in #1077, because
wgpu-native has its own incompatible version of IndexFormat (see that
PR for details). However, with wgpu-native#85, that code was removed,
so having these functions in wgpu should be no longer be a problem
for wgpu-native.

Files Added:

  • wgpu-core/src/command/bundle.rs
  • wgpu-core/src/command/render.rs

75b881e6365a6f69d48321c71a7623a4f92bf822 by Shaye Garg

https://github.com/gfx-rs/wgpu-/commit/75b881e6365a6f69d48321c71a7623a4f92bf822
Authored: 2022-05-14 14:59:47 +0530
Committed: 2022-05-14 14:59:47 +0530

fix: panic in Storage::get (#2657)

  • fix: don't panic on invalid id in Storage::get

  • formatting

  • removed double matches

  • more match removal

  • fix formatting

  • add fix to Storage::label_for_invalid_id

Files Added:

  • wgpu-core/src/hub.rs

284ed4654e6bd79a4d883b766cb70a9474c06a01 by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/284ed4654e6bd79a4d883b766cb70a9474c06a01
Authored: 2022-05-13 14:29:44 -0700
Committed: 2022-05-13 22:18:12 -0700

Spell out the type of the result from map_pass_err.

Without these changes, rust-analyzer cannot determine the type of
cmd_buf.

Files Added:

  • wgpu-core/src/command/compute.rs
  • wgpu-core/src/command/render.rs

8e5ac75d45369b1e8693739d25b581db23043e0e by Jinlei Li

https://github.com/gfx-rs/wgpu-/commit/8e5ac75d45369b1e8693739d25b581db23043e0e
Authored: 2022-05-14 09:06:06 +0800
Committed: 2022-05-14 01:06:06 +0000

metal: fix Rgb9e5Ufloat capabilities and sampler_lod_average support (#2656)

Files Added:

  • wgpu-hal/src/metal/adapter.rs
  • wgpu-hal/src/metal/mod.rs

c1934dc07f39f8643471f8b40cf62f47fd56c9a6 by Kevin Reid

https://github.com/gfx-rs/wgpu-/commit/c1934dc07f39f8643471f8b40cf62f47fd56c9a6
Authored: 2022-05-12 22:16:53 -0700
Committed: 2022-05-12 22:16:53 -0700

RenderPassDescriptor: make label lifetime match doc, and make names descriptive. (#2654)

Lifetime names like <'a, 'b> mean that the reader must look at how
they are used to understand them. By changing them to 'tex (lifetime
of borrows of the texture views the documentation describes) and 'desc
(everything else), and mentioning them in the documentation, it's more
obvious which role each one plays.

For consistency, I also changed begin_render_pass(),
RenderPassColorAttachment, and RenderPassDepthStencilAttachment to
use matching lifetime names.

Also, this made it clear that the Label had the wrong lifetime --
the docs say that the texture views have a different lifetime from
“everything else”, but the Label in fact had the same lifetime as
the texture views, so I changed it to the 'desc (formerly 'b)
lifetime. (On review of change history, this mismatch was previously
introduced in commit 632f828eda9af1f6f18c74398b5f40644cf02f03.)
This change is definitely safe because I followed the data flow down
to BasePass::new which promptly calls to_string() on the label,
thus converting it to owned data.

Files Added:

  • wgpu/src/lib.rs

ddf1903b0331336392a7e29581745058f26b9904 by Jinlei Li

https://github.com/gfx-rs/wgpu-/commit/ddf1903b0331336392a7e29581745058f26b9904
Authored: 2022-05-13 13:14:19 +0800
Committed: 2022-05-12 22:14:19 -0700

Add SHADER_FLOAT16 feature (#2646)

  • Add SHADER_FLOAT16 feature

  • vk: check SHADER_FLOAT16 feature

Files Added:

  • deno_webgpu/02_idl_types.js
  • deno_webgpu/src/lib.rs
  • deno_webgpu/webgpu.idl
  • wgpu-hal/src/metal/adapter.rs
  • wgpu-hal/src/vulkan/adapter.rs
  • wgpu-types/src/lib.rs

144e943737cb6933dc8ae1d6aa3d477d434f8eb0 by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/144e943737cb6933dc8ae1d6aa3d477d434f8eb0
Authored: 2022-05-12 20:15:02 -0700
Committed: 2022-05-12 20:27:54 -0700

Two more fixes to WebGPU spec links.

Files Added:

  • wgpu-types/src/lib.rs

07f94d829a01fedeebe150fa8f877ae6294f33b7 by Kevin Reid

https://github.com/gfx-rs/wgpu-/commit/07f94d829a01fedeebe150fa8f877ae6294f33b7
Authored: 2022-05-11 21:58:34 -0700
Committed: 2022-05-12 20:27:54 -0700

Add cross-references to each wgpu type's documentation.

Added:

  • WebGPU specification links.
  • How to create an instance, if it is not all-public-fields.
  • What function or enclosing type this type is used for.

(The latter two are not present for wgpu-types items due to the
dependency running the wrong direction for that — I saw existing
../wgpu/ links, but those do not work on https://docs.rs/wgpu/.)

This commit specifically does not:

  • substantially revise existing language, except where necessary to fit
    the new information, or when there was an obvious trivial improvement
    like adding a link to support "how to use this".
  • add similar information to the documentation of types not directly
    corresponding to the WebGPU specification

Files Added:

  • wgpu-types/src/lib.rs
  • wgpu/src/lib.rs

8e62ca05381fed4f89fabf3eea8340f2f347c31f by Poly

https://github.com/gfx-rs/wgpu-/commit/8e62ca05381fed4f89fabf3eea8340f2f347c31f
Authored: 2022-05-08 02:04:59 +0200
Committed: 2022-05-11 20:32:43 -0700

Add new integrated GPU to the list: AMD Renoir

Renoir is codename for AMD series of mainstream mobile and desktop APUs based on the Zen 2 CPU and Vega GPU microarchitectures succeeding Picasso.

Files Added:

  • wgpu-hal/src/gles/adapter.rs

bfcf5fa513d51f9f4de4318f9627b39b528c8977 by Poly

https://github.com/gfx-rs/wgpu-/commit/bfcf5fa513d51f9f4de4318f9627b39b528c8977
Authored: 2022-05-08 02:03:44 +0200
Committed: 2022-05-11 20:32:43 -0700

Make GLES DeviceType unknown by default

Files Added:

  • wgpu-core/src/instance.rs
  • wgpu-hal/src/gles/adapter.rs

a5e7275b9ca0124cf1fb01589309dcf297423bce by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/a5e7275b9ca0124cf1fb01589309dcf297423bce
Authored: 2022-05-10 14:07:19 -0700
Committed: 2022-05-11 20:17:32 -0700

Document random bits and pieces.

Files Added:

  • wgpu/examples/cube/main.rs
  • wgpu/src/util/belt.rs

9be974aa6bff1170e95f6668fe79291a7d59e55c by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/9be974aa6bff1170e95f6668fe79291a7d59e55c
Authored: 2022-05-10 15:58:10 -0700
Committed: 2022-05-10 16:35:56 -0700

Documentation fixes for Instance::poll_all and Device::poll.

Files Added:

  • wgpu/src/lib.rs

654a75b058cd5238ddee3a6757b69ee10d39406e by xiaopengli89

https://github.com/gfx-rs/wgpu-/commit/654a75b058cd5238ddee3a6757b69ee10d39406e
Authored: 2022-05-08 18:35:30 +0800
Committed: 2022-05-10 16:35:56 -0700

Return all_queue_empty for Instance::poll_all

Files Added:

  • wgpu-core/src/device/mod.rs
  • wgpu/src/backend/direct.rs
  • wgpu/src/backend/web.rs
  • wgpu/src/lib.rs

3f3af605db70fbf4dac33399eb1e90d56b5ef661 by xiaopengli89

https://github.com/gfx-rs/wgpu-/commit/3f3af605db70fbf4dac33399eb1e90d56b5ef661
Authored: 2022-05-05 14:58:22 +0800
Committed: 2022-05-10 16:35:56 -0700

Return queue_empty for Device::poll

Files Added:

  • deno_webgpu/src/buffer.rs
  • wgpu-core/src/device/mod.rs
  • wgpu/src/backend/direct.rs
  • wgpu/src/backend/web.rs
  • wgpu/src/lib.rs

72dd9d77dba7a1a9e3f2420e9d2441539a356b80 by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/72dd9d77dba7a1a9e3f2420e9d2441539a356b80
Authored: 2022-05-06 16:40:11 -0700
Committed: 2022-05-06 18:56:26 -0700

Document GpuFuture.

Files Added:

  • wgpu/src/backend/native_gpu_future.rs

85b4815f838a50834228846e2e38840db215d3d4 by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/85b4815f838a50834228846e2e38840db215d3d4
Authored: 2022-05-06 18:32:30 -0700
Committed: 2022-05-06 21:32:30 -0400

Rename timeout_us to timeout_ns, to match actual units. (#2645)

Files Added:

  • wgpu-hal/src/vulkan/device.rs

af259aa12a6df033f8e23460215af5f1b64cf3a1 by Hiroaki Yutani

https://github.com/gfx-rs/wgpu-/commit/af259aa12a6df033f8e23460215af5f1b64cf3a1
Authored: 2022-05-05 06:35:45 +0900
Committed: 2022-05-04 17:35:45 -0400

Exclude dependencies from documents (#2642)

Files Added:

  • .github/workflows/docs.yml

ee3d23d5467898d276b73491ac077e5241589b75 by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/ee3d23d5467898d276b73491ac077e5241589b75
Authored: 2022-05-03 01:07:15 -0700
Committed: 2022-05-03 04:07:15 -0400

Raise wgpu_hal::MAX_COLOR_TARGETS to 8. (#2640)

Files Added:

  • wgpu-hal/src/lib.rs

51dbe230950ba489a8513f88739ccc514895711a by Aaro Perämaa

https://github.com/gfx-rs/wgpu-/commit/51dbe230950ba489a8513f88739ccc514895711a
Authored: 2022-05-03 08:04:28 +0300
Committed: 2022-05-03 05:04:28 +0000

Update push constant docs to reflect the API (#2637)

Files Added:

  • wgpu/src/lib.rs

a613a568b61fa765144e4d95e1f9b1491eb9bed8 by Emilio Cobos Álvarez

https://github.com/gfx-rs/wgpu-/commit/a613a568b61fa765144e4d95e1f9b1491eb9bed8
Authored: 2022-05-03 06:28:17 +0200
Committed: 2022-05-03 04:28:17 +0000

Update parking_lot. (#2639)

Files Added:

  • Cargo.lock
  • wgpu-core/Cargo.toml
  • wgpu-hal/Cargo.toml
  • wgpu/Cargo.toml

6fadbdecf20ee85f885e9fd821160e808657d780 by Zen

https://github.com/gfx-rs/wgpu-/commit/6fadbdecf20ee85f885e9fd821160e808657d780
Authored: 2022-05-01 21:17:12 -0400
Committed: 2022-05-02 01:17:12 +0000

Update lib.rs (#2634)

Files Added:

  • wgpu-types/src/lib.rs

ebca3298f01ea72f80aeac4ab1be889469f9c699 by Ashley

https://github.com/gfx-rs/wgpu-/commit/ebca3298f01ea72f80aeac4ab1be889469f9c699
Authored: 2022-04-25 23:38:57 +0200
Committed: 2022-04-25 17:38:57 -0400

Remove gles compressed texture log::error! (#2630)

Files Added:

  • wgpu-hal/src/gles/queue.rs

e54a36ee78693aca0120458bcc2c03262a715f1e by Connor Fitzgerald

https://github.com/gfx-rs/wgpu-/commit/e54a36ee78693aca0120458bcc2c03262a715f1e
Authored: 2022-04-25 14:32:53 -0400
Committed: 2022-04-25 18:32:53 +0000

Move texture-array example over to wgsl (#2618)

Files Added:

  • wgpu/examples/texture-arrays/indexing.wgsl
  • wgpu/examples/texture-arrays/non_uniform_indexing.wgsl
  • wgpu/examples/texture-arrays/screenshot.png

Files Deleted:

  • wgpu/examples/texture-arrays/constant.frag
  • wgpu/examples/texture-arrays/constant.frag.spv
  • wgpu/examples/texture-arrays/non-uniform.frag
  • wgpu/examples/texture-arrays/non-uniform.frag.spv
  • wgpu/examples/texture-arrays/shader.vert
  • wgpu/examples/texture-arrays/shader.vert.spv
  • wgpu/examples/texture-arrays/uniform.frag
  • wgpu/examples/texture-arrays/uniform.frag.spv
  • wgpu/examples/texture-arrays/unsized-non-uniform.frag
  • wgpu/examples/texture-arrays/unsized-non-uniform.frag.spv

Files Added:

  • Cargo.lock
  • deno_webgpu/src/lib.rs
  • player/tests/data/clear-buffer-texture.ron
  • wgpu-core/Cargo.toml
  • wgpu-core/src/device/mod.rs
  • wgpu-core/src/validation.rs
  • wgpu-hal/Cargo.toml
  • wgpu-hal/src/dx12/adapter.rs
  • wgpu-hal/src/dx12/device.rs
  • wgpu-hal/src/dx12/mod.rs
  • wgpu-hal/src/metal/device.rs
  • wgpu-hal/src/vulkan/adapter.rs
  • wgpu-hal/src/vulkan/device.rs
  • wgpu-hal/src/vulkan/mod.rs
  • wgpu-types/src/lib.rs
  • wgpu/Cargo.toml
  • wgpu/examples/README.md
  • wgpu/examples/texture-arrays/main.rs
  • wgpu/src/backend/direct.rs

bc850d2a0e9ebc82718cfe113926c6f9b6a09958 by Connor Fitzgerald

https://github.com/gfx-rs/wgpu-/commit/bc850d2a0e9ebc82718cfe113926c6f9b6a09958
Authored: 2022-04-25 00:19:25 -0400
Committed: 2022-04-25 04:19:25 +0000

Bind group deduplication (#2623)

Files Added:

  • wgpu-core/src/command/bundle.rs
  • wgpu-core/src/command/compute.rs
  • wgpu-core/src/command/mod.rs
  • wgpu-core/src/command/render.rs
  • wgpu-core/src/validation.rs
  • wgpu-hal/src/dx11/adapter.rs

c226a10329f8c3283b995cccda21f4881b1ce6b1 by Jim Blandy

https://github.com/gfx-rs/wgpu-/commit/c226a10329f8c3283b995cccda21f4881b1ce6b1
Authored: 2022-04-21 13:57:35 -0700
Committed: 2022-04-21 20:57:35 +0000

Specify an exact wasm-bindgen-cli version in publish.yml. (#2624)

The versions of wasm-bindgen-cli run by .github/workflows/publish.yml must
exactly match the version of wasm-bindgen used by wgpu. At the moment,
wgpu/Cargo.toml specifies 0.2.76, and our Cargo.lock says 0.2.78, so
the latter is what publish.yml should mention.

Files Added:

  • .github/workflows/publish.yml

59d640a10777bae6dffaee838486f81166dc56b8 by Dragoș Tiselice

https://github.com/gfx-rs/wgpu-/commit/59d640a10777bae6dffaee838486f81166dc56b8
Authored: 2022-04-21 21:49:33 +0200
Committed: 2022-04-21 19:49:33 +0000

metal: Don't skip incomplete binding resources. (#2622)

Files Added:

  • wgpu-hal/src/metal/command.rs

8feac35033ea0b1a8f752f66d224f3d8aa86e22e by Jinlei Li

https://github.com/gfx-rs/wgpu-/commit/8feac35033ea0b1a8f752f66d224f3d8aa86e22e
Authored: 2022-04-22 00:08:13 +0800
Committed: 2022-04-21 12:08:13 -0400

Update texture_create_view logic to match spec (#2621)

Files Added:

  • wgpu-core/src/device/mod.rs
  • wgpu-types/src/lib.rs

5706263917a86ee6487bc3edc8be2e845c48e0c6 by Jinlei Li

https://github.com/gfx-rs/wgpu-/commit/5706263917a86ee6487bc3edc8be2e845c48e0c6
Authored: 2022-04-21 12:28:56 +0800
Committed: 2022-04-20 23:24:21 -0700

Rename dispatch -> dispatch_workgroups

Files Added:

  • deno_webgpu/01_webgpu.js
  • deno_webgpu/src/compute_pass.rs
  • deno_webgpu/src/lib.rs
  • deno_webgpu/webgpu.idl
  • wgpu-core/src/command/compute.rs
  • wgpu/examples/boids/main.rs
  • wgpu/examples/hello-compute/main.rs
  • wgpu/src/backend/direct.rs
  • wgpu/src/backend/web.rs
  • wgpu/src/lib.rs
  • wgpu/src/util/indirect.rs

ff07716f79fb1d84a895bca9d0534947f024294f by Ashley

https://github.com/gfx-rs/wgpu-/commit/ff07716f79fb1d84a895bca9d0534947f024294f
Authored: 2022-04-21 02:56:16 +0200
Committed: 2022-04-20 20:56:16 -0400

Do a downlevel check for anisotrophy and enable it in the webgl backend (#2616)

  • Do a downlevel check for anisotrophy and enable it in the webgl backend

  • Run cargo fmt

  • Change to sample_parameter_i32

Files Added:

  • wgpu-hal/src/gles/adapter.rs
  • wgpu-hal/src/gles/device.rs

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.

Assignee: nobody → jimb

The patch attached to this bug doesn't actually contain any code changes. I've let :tjr know.

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
Attachment #9277523 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: