Closed Bug 1778629 Opened 2 years ago Closed 1 year ago

Update wgpu to new version 94c065cb33b8677b523a6d53c1166a0d0be9fab2 from 2022-07-07 23:43:13

Categories

(Core :: Graphics: WebGPU, enhancement)

Product:
Core
Component:
Graphics: WebGPU
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1818748
Tracking Flags:
Tracking Status
firefox104 --- affected

People

(Reporter: update-bot, Assigned: tjr)

References

Details

(Whiteboard: [3pl-filed][task_id: Omap8HxUTxG1CKORqaNKsQ])

Attachments

(2 files)

Bug 1778629: Disable updatebot for wgpu for now r?jewilde
48 bytes, text/x-phabricator-request
Details | Review
Bug 1778629: Add zstandard to the updatebot image r?jewilde
48 bytes, text/x-phabricator-request
Details | Review

This update covers 33 commits:

94c065cb33b8677b523a6d53c1166a0d0be9fab2 by i509VCB

https://github.com/gfx-rs/wgpucommit/94c065cb33b8677b523a6d53c1166a0d0be9fab2
Authored: 2022-07-07 18:43:13 -0500
Committed: 2022-07-07 19:43:13 -0400

allow access to queue family index in vulkan hal device (#2859)

Files Modified:

  • CHANGELOG.md
  • wgpu-hal/src/vulkan/adapter.rs
  • wgpu-hal/src/vulkan/device.rs
  • wgpu-hal/src/vulkan/mod.rs

9c5015f0598d31fc76476b6a48e19f291f5992dc by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/9c5015f0598d31fc76476b6a48e19f291f5992dc
Authored: 2022-07-06 10:51:32 -0400
Committed: 2022-07-06 11:06:34 -0400

Update Changelog

Files Modified:

  • CHANGELOG.md

259991e2589f01b6561a9daa9ff63d629c802c15 by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/259991e2589f01b6561a9daa9ff63d629c802c15
Authored: 2022-07-05 23:46:56 -0400
Committed: 2022-07-06 11:06:34 -0400

Refactor GLES's texture_format_capabilities

Files Modified:

  • wgpu-hal/src/gles/adapter.rs
  • wgpu-hal/src/gles/mod.rs

499e9e628e7c4d8e5cb38f55ee8af33d0cc8efc4 by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/499e9e628e7c4d8e5cb38f55ee8af33d0cc8efc4
Authored: 2022-07-04 17:47:57 -0400
Committed: 2022-07-06 11:06:34 -0400

Properly query SRV and UAV format features for depth formats

Files Modified:

  • wgpu-hal/src/dx12/adapter.rs

59f4efe93aaf2f3d2848fd683748b26bfeb3f97a by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/59f4efe93aaf2f3d2848fd683748b26bfeb3f97a
Authored: 2022-07-04 17:40:08 -0400
Committed: 2022-07-06 11:06:34 -0400

Prevent get_texture_format_features from saying textures always support COPY_*

Files Modified:

  • wgpu-core/src/instance.rs

7e369fdd573f2d6f46cbe60357eea8c702ce094f by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/7e369fdd573f2d6f46cbe60357eea8c702ce094f
Authored: 2022-07-04 17:37:19 -0400
Committed: 2022-07-06 11:06:34 -0400

Fix texture multi-sample-ability check with TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES

Files Modified:

  • wgpu-core/src/device/mod.rs

bb273a908fd7d5ec25bfd35507e258d0d73545ef by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/bb273a908fd7d5ec25bfd35507e258d0d73545ef
Authored: 2022-07-04 17:36:26 -0400
Committed: 2022-07-06 11:06:34 -0400

DX12/VK allow texture_format_capabilities to be called on any texture format

Files Modified:

  • wgpu-hal/src/auxil/dxgi/conv.rs
  • wgpu-hal/src/dx12/adapter.rs
  • wgpu-hal/src/vulkan/adapter.rs

ff233fbf31d7b17270f7711e1ddbb2171000883b by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/ff233fbf31d7b17270f7711e1ddbb2171000883b
Authored: 2022-07-04 17:35:03 -0400
Committed: 2022-07-06 11:06:34 -0400

Add format features table to wgpu-info and improve output

Files Modified:

  • wgpu-info/src/main.rs

1da5bbd7b43466a7cecbcdd67c0b613b36c6bf63 by Craig

https://github.com/gfx-rs/wgpucommit/1da5bbd7b43466a7cecbcdd67c0b613b36c6bf63
Authored: 2022-07-05 21:11:22 -0700
Committed: 2022-07-06 00:11:22 -0400

Prevent OpenGL from taking preference over Vulkan (#2853)

  • Prevent OpenGL from taking preference over Vulkan

  • update changelog

  • fix wasm build of example

Files Modified:

  • CHANGELOG.md
  • wgpu-core/src/instance.rs
  • wgpu-hal/src/gles/adapter.rs
  • wgpu-types/src/lib.rs
  • wgpu/examples/hello/README.md
  • wgpu/examples/hello/main.rs

b574354af4edeaf5d3d5ea0f738becc509c17e25 by Jinlei Li

https://github.com/gfx-rs/wgpucommit/b574354af4edeaf5d3d5ea0f738becc509c17e25
Authored: 2022-07-06 11:37:26 +0800
Committed: 2022-07-06 03:37:26 +0000

gl: fix depth stencil texture format capability (#2854)

  • gl: fix depth stencil texture format capabilitys

  • Update CHANGELOG

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>

Files Modified:

  • CHANGELOG.md
  • wgpu-hal/src/gles/adapter.rs

ab340baf6909833995273dd1bb78255b5477148a by Elabajaba

https://github.com/gfx-rs/wgpucommit/ab340baf6909833995273dd1bb78255b5477148a
Authored: 2022-07-05 16:59:41 -0400
Committed: 2022-07-05 20:59:41 +0000

Update present_mode docs as most of them don't automatically fall back to Fifo anymore. (#2855)

  • space

PresentMode no longer automatically falls back to Fifo

  • Update wgpu-types/src/lib.rs

Auto(No)Vsync fallback wording.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>

  • changelog

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>

Files Modified:

  • CHANGELOG.md
  • wgpu-types/src/lib.rs

615ced5a998215b8fa2a0266b17200dde3a16947 by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/615ced5a998215b8fa2a0266b17200dde3a16947
Authored: 2022-07-04 15:29:35 -0400
Committed: 2022-07-04 16:38:27 -0400

Changelog

Files Modified:

  • CHANGELOG.md

7319a8136b5f0759e42533105f287fba94f8109c by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/7319a8136b5f0759e42533105f287fba94f8109c
Authored: 2022-07-04 15:26:37 -0400
Committed: 2022-07-04 16:38:27 -0400

Add aniso to dx12

Files Modified:

  • wgpu-types/src/lib.rs

c36eb9f44bd9462fe176fb859839592131428feb by Steven

https://github.com/gfx-rs/wgpucommit/c36eb9f44bd9462fe176fb859839592131428feb
Authored: 2022-07-03 14:09:39 -0700
Committed: 2022-07-03 21:09:39 +0000

Add change (#2847)

Files Modified:

  • CHANGELOG.md

6befbcbca4ee2dc380c608ff3c7bfa51e2a291dc by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/6befbcbca4ee2dc380c608ff3c7bfa51e2a291dc
Authored: 2022-07-02 22:03:52 -0400
Committed: 2022-07-03 01:08:40 -0400

Touch up changelog

Files Modified:

  • CHANGELOG.md

7d85efb30194ed88f5a9d1c3ac277c8e4cc9168c by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/7d85efb30194ed88f5a9d1c3ac277c8e4cc9168c
Authored: 2022-07-03 00:55:41 -0400
Committed: 2022-07-03 01:08:40 -0400

Fix out of bounds access when surface texture is written to by multiple command buffers

Files Modified:

  • wgpu-core/src/device/queue.rs

aaabd56d9a3efd1614543da08f97a69c538aa35c by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/aaabd56d9a3efd1614543da08f97a69c538aa35c
Authored: 2022-07-02 21:44:34 -0400
Committed: 2022-07-03 01:08:40 -0400

Curb Expectations of DX11

Files Modified:

  • CHANGELOG.md

87552a92cca18b28d1bfad34479dd481bcb2996c by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/87552a92cca18b28d1bfad34479dd481bcb2996c
Authored: 2022-07-02 21:40:15 -0400
Committed: 2022-07-03 01:08:40 -0400

Fix GL_EXT_color_buffer_float detection on desktop

Files Modified:

  • wgpu-hal/src/gles/adapter.rs
  • wgpu-hal/src/gles/mod.rs

eea8edb8a0c17835894db41df38073599a3b4794 by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/eea8edb8a0c17835894db41df38073599a3b4794
Authored: 2022-07-02 21:39:57 -0400
Committed: 2022-07-03 01:08:40 -0400

Fix AutoNoVsync on OpenGL

Files Modified:

  • wgpu-core/src/device/mod.rs

72a4ef93620c7adca351f60a6589bab53e1418c9 by Spencer C. Imbleau (he/him)

https://github.com/gfx-rs/wgpucommit/72a4ef93620c7adca351f60a6589bab53e1418c9
Authored: 2022-07-02 22:00:25 -0400
Committed: 2022-07-03 02:00:25 +0000

Fixes #2840 (#2842)

Files Modified:

  • CHANGELOG.md
  • wgpu-core/src/device/mod.rs

cb0646f8da8280a357001f13da8a336578252947 by RustEnthusiast

https://github.com/gfx-rs/wgpucommit/cb0646f8da8280a357001f13da8a336578252947
Authored: 2022-07-02 03:17:08 -0500
Committed: 2022-07-02 08:17:08 +0000

Update wgpu repository link in Cargo.toml. (#2834)

This fixes issue #2830.

Files Modified:

  • wgpu/Cargo.toml

c20c86a9481b1585107cad6455652d434849147a by Fel

https://github.com/gfx-rs/wgpucommit/c20c86a9481b1585107cad6455652d434849147a
Authored: 2022-07-01 19:39:11 -0300
Committed: 2022-07-01 22:39:11 +0000

Add other breaking changes to 0.13 changelog (#2831)

Files Modified:

  • CHANGELOG.md

5bef140228cb56d1dc2b0bd669ae4bd6f6ecf508 by multisn8

https://github.com/gfx-rs/wgpucommit/5bef140228cb56d1dc2b0bd669ae4bd6f6ecf508
Authored: 2022-07-01 21:32:27 +0200
Committed: 2022-07-01 19:32:27 +0000

Clarify about breaking max_buffer_size in Limits (#2828)

Files Modified:

  • CHANGELOG.md

e125321bff7eb602d1849f18f22606afeebef3fb by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/e125321bff7eb602d1849f18f22606afeebef3fb
Authored: 2022-07-01 10:38:04 -0400
Committed: 2022-07-01 14:38:04 +0000

Release 0.13 two - electric boogaloo (#2827)

Files Modified:

  • Cargo.lock
  • wgpu-hal/Cargo.toml

93dbffa5d3d5ae2b26ee0c573862fef2f9f4de52 by David Huculak

https://github.com/gfx-rs/wgpucommit/93dbffa5d3d5ae2b26ee0c573862fef2f9f4de52
Authored: 2022-06-30 21:44:29 -0400
Committed: 2022-07-01 01:44:29 +0000

Add other breaking changes to 0.13 changelog (#2825)

  • add other breaking changes to 0.13 changelog

  • fix typo

Files Modified:

  • CHANGELOG.md

1ceef24261c6c0ace193090a51e9d7e406da1185 by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/1ceef24261c6c0ace193090a51e9d7e406da1185
Authored: 2022-06-30 16:25:49 -0400
Committed: 2022-06-30 20:25:49 +0000

Add changelog for 0.13 (#2823)

  • Changelog

  • Update CHANGELOG.md

  • Bump versions to 0.13

Files Modified:

  • .github/pull_request_template.md
  • CHANGELOG.md
  • Cargo.lock
  • wgpu-core/Cargo.toml
  • wgpu-hal/Cargo.toml
  • wgpu-hal/src/gles/adapter.rs
  • wgpu-hal/src/gles/device.rs
  • wgpu-info/Cargo.toml
  • wgpu-types/Cargo.toml
  • wgpu/Cargo.toml

ea05b44f384077a1a466eeb9a58c523379225a01 by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/ea05b44f384077a1a466eeb9a58c523379225a01
Authored: 2022-06-30 14:24:17 -0400
Committed: 2022-06-30 14:24:17 -0400

Improve Presentation Api (#2803)

  • Add new presentation modes

  • Expand presentation formats

  • Add Surface::get_supported_modes

  • Update to rust 2021 and improve some metal surface code

  • Update wgpu-types/src/lib.rs

Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>

  • Fix windows build errors

  • Fix issues with ALLOW_TEARING

Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>

Files Modified:

  • cts_runner/Cargo.toml
  • deno_webgpu/Cargo.toml
  • dummy/Cargo.toml
  • player/Cargo.toml
  • run-wasm/Cargo.toml
  • wgpu-core/Cargo.toml
  • wgpu-core/src/device/mod.rs
  • wgpu-core/src/instance.rs
  • wgpu-core/src/present.rs
  • wgpu-hal/Cargo.toml
  • wgpu-hal/src/dx12/adapter.rs
  • wgpu-hal/src/dx12/instance.rs
  • wgpu-hal/src/dx12/mod.rs
  • wgpu-hal/src/metal/adapter.rs
  • wgpu-hal/src/metal/mod.rs
  • wgpu-hal/src/metal/surface.rs
  • wgpu-hal/src/vulkan/adapter.rs
  • wgpu-hal/src/vulkan/conv.rs
  • wgpu-info/Cargo.toml
  • wgpu-types/Cargo.toml
  • wgpu-types/src/lib.rs
  • wgpu/Cargo.toml
  • wgpu/examples/hello-triangle/main.rs
  • wgpu/src/backend/direct.rs
  • wgpu/src/backend/web.rs
  • wgpu/src/lib.rs

98597da1ec44be4c0722454c99f051a257760dc8 by Jinlei Li

https://github.com/gfx-rs/wgpucommit/98597da1ec44be4c0722454c99f051a257760dc8
Authored: 2022-06-30 11:36:11 +0800
Committed: 2022-06-30 03:36:11 +0000

Allow fragment stage to have more outputs than the pipeline has (#2822)

Files Modified:

  • wgpu-core/src/device/mod.rs
  • wgpu-core/src/pipeline.rs

1d8bc57a86a989b2fb30d3f3ae1cfcb9e55adac1 by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/1d8bc57a86a989b2fb30d3f3ae1cfcb9e55adac1
Authored: 2022-06-29 23:05:42 -0400
Committed: 2022-06-30 03:05:42 +0000

Don't wait for current submission inside of submit (#2824)

Files Modified:

  • wgpu-core/src/device/queue.rs

464b61d01c5832497e7ae54dbb153464e74eb285 by Connor Fitzgerald

https://github.com/gfx-rs/wgpucommit/464b61d01c5832497e7ae54dbb153464e74eb285
Authored: 2022-06-28 15:49:51 -0400
Committed: 2022-06-28 19:49:51 +0000

Flip span labels to work better with tools (#2820)

Files Modified:

  • wgpu-core/src/command/compute.rs
  • wgpu-core/src/command/mod.rs
  • wgpu-core/src/command/render.rs
  • wgpu-core/src/command/transfer.rs
  • wgpu-core/src/device/life.rs
  • wgpu-core/src/device/mod.rs
  • wgpu-core/src/device/queue.rs
  • wgpu-core/src/hub.rs
  • wgpu-core/src/instance.rs
  • wgpu-core/src/present.rs
  • wgpu-core/src/resource.rs

5eb09f6bd786a7026fbd1d00e2e76afe450c7dac by Teodor Tanasoaia

https://github.com/gfx-rs/wgpucommit/5eb09f6bd786a7026fbd1d00e2e76afe450c7dac
Authored: 2022-06-28 20:32:43 +0200
Committed: 2022-06-28 18:32:43 +0000

Implement Queue::write_buffer_with (#2777)

  • implement Queue::write_buffer_with

  • address comments

  • update doc

  • Fix copy span location

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>

Files Modified:

  • wgpu-core/src/device/queue.rs
  • wgpu-core/src/hub.rs
  • wgpu-core/src/id.rs
  • wgpu-core/src/resource.rs
  • wgpu/src/backend/direct.rs
  • wgpu/src/backend/mod.rs
  • wgpu/src/backend/web.rs
  • wgpu/src/lib.rs

0eb6845b6ad114963de73167332b8048b8997184 by Jinlei Li

https://github.com/gfx-rs/wgpucommit/0eb6845b6ad114963de73167332b8048b8997184
Authored: 2022-06-29 02:15:57 +0800
Committed: 2022-06-28 14:15:57 -0400

web: march web-sys 0.3.58, sparse attachments support (#2813)

Files Modified:

  • Cargo.lock
  • wgpu/Cargo.toml
  • wgpu/src/backend/web.rs

b0c798639a9b041a14dfaf3f1deb1b1b932f55c5 by Jinlei Li

https://github.com/gfx-rs/wgpucommit/b0c798639a9b041a14dfaf3f1deb1b1b932f55c5
Authored: 2022-06-29 02:12:34 +0800
Committed: 2022-06-28 18:12:34 +0000

core: restrict hal::TextureUses::COLOR_TARGET condition within create_texture (#2818)

Files Modified:

  • wgpu-core/src/device/mod.rs

./mach vendor gfx/wgpu_bindings/moz.yaml failed with the following message:

Updating git repository `https://github.com/smol-rs/async-task`
Updating git repository `https://github.com/hsivonen/chardetng`
Updating git repository `https://github.com/hsivonen/chardetng_c`
Updating git repository `https://github.com/chris-zen/coremidi.git`
Updating git repository `https://github.com/mozilla/application-services`
Updating git submodule `https://github.com/mozilla/glean`
Updating git repository `https://github.com/mozilla/midir.git`
Updating git repository `https://github.com/rust-minidump/minidump-writer.git`
Updating git repository `https://github.com/hsivonen/packed_simd`
Updating crates.io index
Updating git repository `https://github.com/mozilla-spidermonkey/jsparagus`
Updating git repository `https://github.com/mozilla/neqo`
Updating git repository `https://github.com/mozilla/audioipc`
Updating git repository `https://github.com/kinetiknz/audioipc-2`
Updating git repository `https://github.com/mozilla/cubeb-coreaudio-rs`
Updating git repository `https://github.com/mozilla/cubeb-pulse-rs`
Updating git repository `https://github.com/jfkthame/mapped_hyph.git`
Updating git repository `https://github.com/mozilla/mp4parse-rust`
Updating git submodule `https://github.com/AOMediaCodec/av1-avif.git`
Updating git submodule `https://github.com/link-u/avif-sample-images`
Updating git repository `https://github.com/gfx-rs/wgpu`
Updating git repository `https://github.com/gfx-rs/naga`
Updating git repository `https://github.com/gfx-rs/metal-rs`
Updating git repository `https://github.com/kinetiknz/mio-named-pipes`
Updating git repository `https://github.com/gfx-rs/d3d12-rs.git`

Latest commit is 94c065cb33b8677b523a6d53c1166a0d0be9fab2 from 2022-07-07T23:43:13Z
Setting up artifact cargo-vet.tar.zst
Downloading artifact to local cache: /builds/worker/.mozbuild/toolchains/d7e75a9672e2ee19-cargo-vet.tar.zst
Downloading... 0.0 %
Downloading... 5.2 %
Downloading... 10.2 %
Downloading... 15.2 %
Downloading... 20.2 %
Downloading... 25.2 %
Downloading... 30.2 %
Downloading... 35.2 %
Downloading... 40.2 %
Downloading... 45.2 %
Downloading... 50.2 %
Downloading... 55.2 %
Downloading... 60.2 %
Downloading... 65.2 %
Downloading... 70.1 %
Downloading... 75.1 %
Downloading... 80.1 %
Downloading... 85.1 %
Downloading... 90.1 %
Downloading... 95.1 %
Downloading... 100.0 %
Error running mach:

['--log-no-times', 'artifact', 'toolchain', '--from-task', 'XXcBftIzSgOwz-Ef1prwwA:public/build/cargo-vet.tar.zst']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file artifact| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ModuleNotFoundError: No module named 'zstandard'

File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/artifact_commands.py", line 576, in artifact_toolchain
unpack_file(local)
File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/tooltool.py", line 993, in unpack_file
import zstandard

Flags: needinfo?(jimb)

Tom, the error above aside, I'm afraid all of these wgpu updates are going to fail until I finish vetting (for cargo vet) the differences between wgpu 0.12, which we've grandfathered in, and the recently released wgpu 0.13. So until that's done, updatebot should probably give up on wgpu.

Ideally, updatebot would have not encountered the error above, would have seen the cargo vet error message that it was about to encounter, and figured out the situation on its own. Does it know about vetting failures yet?

Flags: needinfo?(jimb) → needinfo?(tom)
Assignee: nobody → tom
Status: NEW → ASSIGNED

It does not, nor do we know what we should do about it... I will start a conversation!

Flags: needinfo?(tom)

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE

We're going to land a couple patches on this bug.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a86c951399c4
Add zstandard to the updatebot image r=jewilde
Attachment #9285511 - Attachment description: Bug 1778629: Disable updatebot for wgpu for now r?jimb → Bug 1778629: Disable updatebot for wgpu for now r?jewilde
Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19b61a9b24bb
Disable updatebot for wgpu for now r=jewilde

The leave-open keyword is there and there is no activity for 6 months.
:tjr, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Flags: needinfo?(tom)

wgpu gets bumped regularly so I'm duping this to the most recent update.

Status: REOPENED → RESOLVED
Closed: 2 years ago → 1 year ago
Duplicate of bug: 1818748
Flags: needinfo?(tom)
Keywords: leave-open
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: