177060 - Gopher type 0 (text file) pages not displayed

Status: VERIFIED DUPLICATE of bug 202188

(Core :: Networking, defect)

Description

[Sean MacLennan]

I upgraded from the 0.1 to 0.3 version of Phoenix. (Note: I am not allowed to
fill in the version part of the bug report) Directories seem to work, but I can
no longer access text or binary files. I know this worked in 0.1 and I *believe*
I have 0.2 at work and it works.

Thanks,
   Sean MacLennan

Comment 1

[Neil Cronin]

gopher://seanm.ca/  WFM on a  10/26 build.

sean, I don't know a lot about the gopher protocol or servers, but are you sure
it's not a config problem?

Comment 2

[Neil Cronin]

ok I see this now, I wasn't checking txt docs.

Comment 3

[Boris Zbarsky [:bzbarsky]]

reassign for real.  This is a problem in Mozilla too.

Comment 4

[Andrew Schultz]

regression between linux trunk builds 2002092221 and 2002092408

Comment 5

[Tom Everingham]

Bradley, are you still fixing gopher problems?  

Comment 6

[Tom Everingham]

.

Comment 7

[Tom Everingham]

assigning to bbaetz

Comment 8

[Bradley Baetz (:bbaetz)]

I'm not touching anything for the next cuople of weeks at least...

Comment 9

[Sean MacLennan]

I couldn't wait a couple of weeks ;-) So I looked into it. I noticed that html
files seemed to view fine, directories where fine, but text files just did nothing.

In the function nsGopherChannel::GetContentType I changed the type for text
('0') from TEXT_HTML to TEST_PLAIN and now I can view text files. This is
probably the correct setting anyway.

I see from the readme you do not accept patches, but since it is only one word I
thought I would include it to try to expedite the fix.

Index: netwerk/protocol/gopher/src/nsGopherChannel.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/protocol/gopher/src/nsGopherChannel.cpp,v
retrieving revision 1.27
diff -u -r1.27 nsGopherChannel.cpp
--- netwerk/protocol/gopher/src/nsGopherChannel.cpp     16 Sep 2002 19:46:27
-0000      1.27
+++ netwerk/protocol/gopher/src/nsGopherChannel.cpp     30 Oct 2002 05:46:40 -0000
@@ -331,7 +331,7 @@
 
     switch(mType) {
     case '0':
-        aContentType = NS_LITERAL_CSTRING(TEXT_HTML);
+        aContentType = NS_LITERAL_CSTRING(TEXT_PLAIN);
         break;
     case '1':
         switch (mListFormat) {

Comment 10

[Bradley Baetz (:bbaetz)]

I happily accept patches :)

We should be running this through the text->html converter - did that get lost
somewhere with those other content type changes which went in a few weeks back?
darin? dougt? any ideas?

Without this patch, does view-source show the correct text?

Comment 11

[Tom Everingham]

*** Bug 149322 has been marked as a duplicate of this bug. ***

Comment 12

[Michael Lefevre]

*** Bug 164283 has been marked as a duplicate of this bug. ***

Comment 13

[Sean MacLennan]

> We should be running this through the text->html converter - did that get lost
> somewhere with those other content type changes which went in a few weeks back?

I updated from cvs to the latest code (0.5). The text->html converter *is* the
problem. If you comment out the special case for '0' in
nsGopherChannel::OnStopRequest then you can see the text files. (You also still
want the TEXT_HTML to TEXT_PLAIN patch to make the files readable).

Comment 14

[benc]

If this is text-only, can we someone update the summary to be more specific?

Comment 15

[Michael Lefevre]

*** Bug 190132 has been marked as a duplicate of this bug. ***

Comment 16

[Bradley Baetz (:bbaetz)]

This got fixed.

*** This bug has been marked as a duplicate of 202188 ***

Comment 17

[benc]

VERIFIED/dupe