1770680 - get() of RefPtr, OwningNonNull and nsCOMPtr are not treated as safe even if they are in the auto storage

Status: NEW

(Core :: MFBT, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

RefPtr<T>::get(), OwningNonNull<T>::get() and nsCOMPtr<T>::get() are not treated as safe even if their instances are in the auto storage. Therefore, in the following case:

const bool callWithFoo = something;
const RefPtr<Foo> foo;
MayRunScript(callWithFoo ? foo.get() : nullptr);

needs to be written as:

MayRunScript(MOZ_KnownLive(callWithFoo ? foo.get() : nullptr));