1770804 - Fix remaining calls to AddonTestUtils.checkMessages using the wrong format for the options and make checkMessages to throw to make it harder to miss that kind of mistake

Status: RESOLVED FIXED

(WebExtensions :: General, task, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

While looking to Bug 1770288 we noticed that the intermittent failure was due to the test using the wrong type signature in the call to AddonTestUtils.checkMessages (See Bug 1770288 comment 3) and that was actually not the only test using the wrong type signature for that same parameter (See Bug 1770288 comment 4).

From a quick look on searchfox it seems there may be some more (e.g. this one looks also to be using the wrong format for the expected option: https://searchfox.org/mozilla-central/rev/70cf6863bd85af2a3188ec1fe5209a3ec1b2de86/browser/components/extensions/test/browser/browser_ext_windows_create_params.js#116-118).

This follow up is meant to track the following additional changes:

• make AddonTestUtils.checkMessages to throw an explicit error if the format of the expected and forbidden options isn't the right one
• fix any remaining call still using the wrong option format

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1770804 - validate forbidden and expected AddonTestUtils.checkMessages options for common mistakes. r?willdurand!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Pushed to try to double-check how many more AddonTestUtils.checkMessages may be using the wrong format for the expected and forbidden options would be caught by explicitly validating those two options:

• https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8229a7e9b5bf4b134b089e34e46e6c3dd5d9550

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1770804 - Fix wrong format for the expected option used in browser_ext_windows_create_params.js AddonTestUtils.checkMessages call. r?willdurand!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/560f9a8276ff
Fix wrong format for the expected option used in browser_ext_windows_create_params.js AddonTestUtils.checkMessages call. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/e06cf44e3b0a
validate forbidden and expected AddonTestUtils.checkMessages options for common mistakes. r=willdurand

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/560f9a8276ff
https://hg.mozilla.org/mozilla-central/rev/e06cf44e3b0a