1771073 - Correct schemas in Nimbus Feature Manifest

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Beth Rennie [:beth] (she/her)]

The features specified in the FeatureManfiest for cfr, infobar, spotlight, pbnewtab, and moments-page correspond to message types when they should actually support any fxms message in their corresponding message group

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1771073 - Correct FxMS features and keep them up to date with tests r?mardak,dmose

The Nimbus Features corresponding to FxMS messaging surfaces are actually
intended to map to FxMS message groups, which can accept any FxMS message.
The features have been updated with schemas that accept any FxMS message but
enforce that it targets the correct message group.

As part of this, all FxMS schemas have been updated with an $id so that they
can be bundled into feature schemas and have their internal $refs work.
(Otherwise, a $ref would be relative to the top-level schema instead of the
sub-schema). The previously unexposed FxMS schemas (for CFRUrlbarChiclet and
ToolbarBadgeMessage) are still unexposed as resource:// URIs because nothing
references them directly at runtime.

Additionally, each FxMS schema has had its template field become required and
requires a constant value for that schema (e.g., Spotlight requires a template
value of "spotlight").

A test has been added to ensure that if any of the messaging surfaces schemas
change that the feature schemas are also updated. The feature schemas can be
regenerated via:

cd ./browser/components/newtab/schemas
./make-schemas.py

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1771073 - Make make-schemas.py executable r?dmose

Depends on D147332

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66e738841713
Correct FxMS features and keep them up to date with tests r=dmose,pdahiya
https://hg.mozilla.org/integration/autoland/rev/c91c8dd3a806
Make make-schemas.py executable r=dmose

Comment 4

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/66e738841713
https://hg.mozilla.org/mozilla-central/rev/c91c8dd3a806