177109 - jump to specific date using command line invocation

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[Glenn Carr]

In order to integrate this the calendar with other tools (specifically 
http://www.dqsd.net), adding some command-line switches to allow starting up 
the calendar at a specific date is needed.  E.g., 

mozilla -calendar -date 2002-Oct-26

(or whatever date format(s) make sense)

Comment 1

[Mike Potter]

New contact from [e-mail] to [e-mail]
Filter on string OttawaMBA to get rid of these messages. 
Sorry for the spam.

Comment 2

[Matthew (lilmatt) Willis]

Reassigning all automatically assigned bugs from Mostafa to nobody@m.o

Bugspam filter: TorontoMostafaMove

Comment 3

[Joey Minta]

Attachment: command line goodness

This is close enough to the installer that lilmatt gets it.  I'm hijacking this bug to handle both 'jump to date' and the more important case of 'subscribe to calendar'.  rob_strong wants us to get this so we can set ourselves up as the default calendaring app on a windows box.

Comment 4

[Joey Minta]

Comment on attachment 231167 [details] [diff] [review]
command line goodness

To test:

./sunbird -showdate 1983,12,20 gets you to an important date.

./sunbird -subscribe file:///Users/Joey/Desktop/temp.ics gets you a new calendar subscription

Comment 5

[Matthew (lilmatt) Willis]

Comment on attachment 231167 [details] [diff] [review]
command line goodness

Looks good.
r=lilmatt

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 231167 [details] [diff] [review]
command line goodness

>     helpInfo : "  -calendar            Start with the calendar.\n"

You clearly need to add some lines of documentation there :)

Comment 7

[Joey Minta]

Attachment: command line goodness v2

Patch includes changes to helpInfo now.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 231488 [details] [diff] [review]
command line goodness v2

>Index: calendar/resources/content/calendarService.js
>     handle : function service_handle(cmdLine) {
>-        if (cmdLine.handleFlag("calendar", false)) {
>-            wwatch = Components.classes[WINDOWWATCHER_CONTRACTID]
>-                               .getService(nsIWindowWatcher);
>-            wwatch.openWindow(null, "chrome://calendar/content/",

Why are you removing the call to handleFlag()?

And it doesn't look good to me to move the handling of command line arguments out of the command line handler. The handler is really there to handle things.

Comment 9

[Joey Minta]

(In reply to comment #8)
> (From update of attachment 231488 [details] [diff] [review] [edit])
> >Index: calendar/resources/content/calendarService.js
> >     handle : function service_handle(cmdLine) {
> >-        if (cmdLine.handleFlag("calendar", false)) {
> >-            wwatch = Components.classes[WINDOWWATCHER_CONTRACTID]
> >-                               .getService(nsIWindowWatcher);
> >-            wwatch.openWindow(null, "chrome://calendar/content/",
> 
> Why are you removing the call to handleFlag()?
I removed it because I wanted to simply let the front-end handle whatever flags it wanted without worrying about staying in sync here.  The front end will call handleFlagWithParam, which covers this functionality.

> 
> And it doesn't look good to me to move the handling of command line arguments
> out of the command line handler. The handler is really there to handle things.
> 
But the handler doesn't have access to chrome, and that's where these arguments are actually doing work.

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 231488 [details] [diff] [review]
command line goodness v2

ok, you conviced me with the chrome access part.
r=mvl

Comment 11

[Joey Minta]

Patch checked in.

Comment 12

[Damian Szczepanik]

why I can not find this useable function on any website? this should be documented better :)

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060902 Calendar/0.3a2+

Comment 13

[Sebastian Schwieger]

REOPEN

Trying to subscribe to a locally available calendar ics file I get this error:

Error: uncaught exception: [Exception... "Component returned failure code: 0x804b000a [nsIIOService.newURI]"  nsresult: "0x804b000a (<unknown>)"  location: "JS frame :: chrome://calendar/content/calendarUtils.js :: makeURL :: line 65"  data: no]

patch coming up

Comment 14

[Sebastian Schwieger]

Attachment: use resolveURI instead of newURI

makeURL() expected an nsIFile, but calurl is AString. Hence the error.

Tested with Sunbird Trunk on Linux

Comment 15

[cmtalbert]

Comment on attachment 252531 [details] [diff] [review]
use resolveURI instead of newURI

Looks good to me.

Comment 16

[Matthew (lilmatt) Willis]

Comment on attachment 252531 [details] [diff] [review]
use resolveURI instead of newURI

Moving r2 to mvl.  I'm not an r2-er

Comment 17

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 252531 [details] [diff] [review]
use resolveURI instead of newURI

r2=mvl

Comment 18

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED