Closed Bug 1771220 Opened 3 years ago Closed 9 months ago

New implementation ignores browser.download.useDownloadDir

Categories

(Firefox :: Screenshots, defect, P2)

Product:
Firefox
Component:
Screenshots
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox101 --- unaffected
firefox102 --- affected

People

(Reporter: metasieben, Unassigned)

References

(Depends on 1 open bug)

Details

With screenshots.browser.component.enabled we currently seem to ignore browser.download.useDownloadDir.

STR:

  1. Set screenshots.browser.component.enabled to true
  2. Set browser.download.useDownloadDir to false
  3. Take a screenshot

ER: Filepicker opens

AR: Screenshot is saved to Downloads directory

Depends on: 1696573

Reproduced on 26.05.2022 Nightly on Windows 10, Ubuntu 20 and Mac ARM 12

Status: UNCONFIRMED → NEW
Has STR: --- → yes
status-firefox101: --- → unaffected
status-firefox102: --- → affected
Ever confirmed: true

Thanks for filing this. We should match the normal behavior for downloading an image - with the various preferences & external app handler settings. It looks like this does work as expected with the extension so we'll need to investigate to see what needs to happen to match behavior there.

Severity: -- → S3
Priority: -- → P2

I believe this is now fixed. If I enable the "Always ask you where to save files" checkbox in about:preferences, clicking the download button in the screenshots UI will correctly open a file picker prompt.

edit: :mak I'm not 100% sure what should happen in the STR given here though. If browser.download.useDownloadDir is false and "ask where to save files" is unchecked, what should happen? Apparently "ask where to save" is toggling the useDownloadDir pref so we should be good here.

Flags: needinfo?(mak)
Status: NEW → RESOLVED
Closed: 9 months ago
Flags: needinfo?(mak)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.