Closed Bug 1771551 Opened 2 years ago Closed 2 years ago

PiP Subtitles Support for BBC.co.uk

Categories

(Toolkit :: Picture-in-Picture, enhancement, P3)

Product:
Toolkit
Component:
Picture-in-Picture
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- verified

People

(Reporter: asafko, Assigned: eddiebrace)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 5 obsolete files)

Bug 1771551 - Add PiP subtitles support for BBC r=mconley
48 bytes, text/x-phabricator-request
Details | Review

Adding a new site-specific wrapper how-to.

Current Behavior

  • Navigate to https://www.bbc.co.uk/ (need to find an internationally available link)
  • Play a video
  • Enable subtitles in player
  • Open video in PiP player

Actual results:
No subtitles are displayed in the PiP window

Expected results:
Subtitles are displayed in the PiP window

Assignee: nobody → eddiebrace
Status: NEW → ASSIGNED

Depends on D148397

Severity: -- → S4
Priority: -- → P3

Depends on D148398

Depends on D148397

Attachment #9279873 - Attachment is obsolete: true
Attachment #9279874 - Attachment is obsolete: true
Attachment #9279906 - Attachment is obsolete: true
Attachment #9279911 - Attachment is obsolete: true

tt: Enter commit message. Lines beginning with 'HG:' are removed.

Attachment #9279912 - Attachment is obsolete: true
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e055599bb27f
Add PiP subtitles support for BBC r=mconley

https://hg.mozilla.org/mozilla-central/rev/e055599bb27f

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Flags: qe-verify+

Verified - Fixed in Beta 103.0b4 and the latest Nightly build 104.0a1 (2022-07-06) using Windows 10, Ubuntu 20 and macOS 12. The video subtitle is displayed accordingly in PiP.

Status: RESOLVED → VERIFIED
status-firefox103: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: