1771828 - Missing label/string to describe radiobox for default email address (title and/or tooltip)

Status: RESOLVED DUPLICATE of bug 1776372

(Thunderbird :: Address Book, defect, P1)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Radiobox for default email address isn't labelled in any way

P1 because this needs strings.

No label, no tooltip: It's hard to tell for the user what the radio boxes are for.
Having a title label might be odd because of the limited space in the radio box column.
Maybe we could have a Default Email Address icon in the title?
At least (which might be sufficient), we should add a tooltip to the radio boxes, something like:

• Set default email address

I'm also wondering if the meaning of Default Email Address needs a bit of explanation somewhere (speech bubble on column title icon?)

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1771828 - Fixes for primary email selection. r=nicolai,aleca

• It's nor really a default but a preferred address.
• Set title for some inputs, and remove the accessibility specials: the labels should not be hidden if used for accessibility, and just using normal semantics (title) will benefit all users
• fix preferred checkbox to be radio and remove the vcard-email-primary-checkbox CustomEvent hack. No idea why that shows as a radio atm (?!)
• selected is a boolean attribute in html: "true" is not valid
• fix some elements that do not have optional closing tags

Comment 2

[Magnus Melin [:mkmelin]]

It's not a default address, but a preferred one. With data from elsewhere, it can define the ordering.
We should fix the code to show the preferred address first, but I'm leaving that for another bug.

Comment 3

[Alessandro Castellani [:aleca]]

Marking this as duplicate of bug 1776372 since the work is being done there, and some other fixes in the patch have landed already.