1771893 - More than one trailing newline in the street textarea corrupts the vCard

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[u695164]

When applying two subsequent trailing newlines in the textarea for the street the vCard data corrupts with a Error creating vCard properties" (new ParserError("Invalid parameters in ';;;;'", (void 0)))

In the sqlite database the data looks like:

BEGIN:VCARD
N:;;;;
FN:
UID:81b3a35f-5a6c-4f83-8a61-d2353343769b
EMAIL:
ADR:;;w\n
;d;;;
END:VCARD

BEGIN:VCARD
N:dwa;awd;;;
ADR:;;foo\n
;foo\\n\n\n;;;
FN:awd dwa
UID:81b3a35f-5a6c-4f83-8a61-d2353343769b
NOTE:foo\n\n\n\n\nawd\n\n\n\n\n
END:VCARD

It is not possible to edit the vCard afterwards. (See Bug 1770146)

Comment 1

[u695164]

Attachment: Bug 1771893 - Trim newlines in the edit addressbook street field before setting it. r=darktrojan

Comment 2

[Geoff Lankow (:darktrojan)]

I've found and fixed a bug in ical.js that made this a problem.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cd75070b3fa6
Trim newlines in the edit addressbook street field before setting it. r=darktrojan

Comment 4

[u695164]

Comment on attachment 9278914 [details]
Bug 1771893 - Trim newlines in the edit addressbook street field before setting it. r=darktrojan

[Approval Request Comment]
User impact if declined: When editing a contact in the address book and a user sets two newlines at the end of the street the card will lose all vCard properties.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9278914 [details]
Bug 1771893 - Trim newlines in the edit addressbook street field before setting it. r=darktrojan

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 102.0beta6:
https://hg.mozilla.org/releases/comm-beta/rev/ea94d16e69c5