Closed Bug 1771914 Opened 6 months ago Closed 6 months ago

[x11/xwayland] I can't get the right click menu on the PiP window anymore

Categories

(Core :: Widget: Gtk, defect)

defect

Tracking

()

VERIFIED FIXED
103 Branch
Tracking Status
relnote-firefox --- 101+
firefox-esr91 --- unaffected
firefox101 --- verified
firefox102 --- verified
firefox103 --- verified

People

(Reporter: julienw, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Hey,

I'm a big fan of the PiP feature. Being on Linux I use several virtual desktops, and I was using the right click menu to toggle the option "Always on visible workspace" so that it's always visible even when I switch the workspace.

Unfortunately the right click menu doesn't work anymore for some time so I can't do it anymore, and this is a huge issue for me.

I'm using Gnome 3.38 on latest Debian Stable, with the xwayland backend.

Thanks

After mozregression, I get this pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d1eb6fe5a1fa5457425c5a33f212516a5eeaa381&tochange=498e0e6f9b19107c8c17525a3d01a659f89002e8

It looks like Bug 1756903 is the culprit :)

Hey Emilio, any thoughts about that?

Maybe it could make sense that the option Always on visible workspace is toggled by default for this window too, but I'm not sure.

Flags: needinfo?(emilio)
Regressed by: 1756903
Keywords: regression
Has Regression Range: --- → yes
Has STR: --- → yes
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Component: Picture-in-Picture → Widget: Gtk
Flags: needinfo?(emilio)
Product: Toolkit → Core
Summary: I can't get the right click menu on the PiP window anymore → [x11/xwayland] I can't get the right click menu on the PiP window anymore

This works in both X11 and Wayland, with system and client decorations.

Also don't dynamically load it, we require gtk 3.14 so we know it's
available.

Blocks: 1771950
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a746e4adc673
Use top-level gdk window to show PiP menu. r=stransky
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

Comment on attachment 9278939 [details]
Bug 1771914 - Use top-level gdk window to show PiP menu. r=stransky

Beta/Release Uplift Approval Request

  • User impact if declined: One liner fix for context menus on PiP windows.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple one liner
  • String changes made/needed: no
  • Is Android affected?: No
Attachment #9278939 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9278939 [details]
Bug 1771914 - Use top-level gdk window to show PiP menu. r=stransky

Approved for 102 beta 3, thanks.

Attachment #9278939 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Thanks, this works well now!

Reproduced this issue on an affected Nightly build from 2022-05-31, on Ubuntu 20.04 (x11).
Verified fixed on latest Nightly 103.0a1 (20220602093647) and Firefox 102.0b3 (20220602074217 - treeherder build) on Ubuntu 20.04 and Ubuntu 21.04(wayland).

Is this something we'd want to consider taking in a dot release also? Please nominate if so.

Flags: needinfo?(emilio)

Yeah, probably worth it.

Flags: needinfo?(emilio)

Comment on attachment 9278939 [details]
Bug 1771914 - Use top-level gdk window to show PiP menu. r=stransky

Beta/Release Uplift Approval Request

  • User impact if declined: see above
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: see above
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): One-liner.
  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9278939 - Flags: approval-mozilla-release?

Comment on attachment 9278939 [details]
Bug 1771914 - Use top-level gdk window to show PiP menu. r=stransky

Approved for 101.0.1.

Attachment #9278939 - Flags: approval-mozilla-release? → approval-mozilla-release+

Added to the 101.0.1 relnotes:

Fixed context menus not appearing when right-clicking Picture-in-Picture windows on some Linux systems

Verified fixed on Firefox 101.0.1 (20220608170832) on Ubuntu 22.04 and Ubuntu 21.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: in-qa-testsuite+
You need to log in before you can comment on or make changes to this bug.