Closed Bug 1756903 Opened 7 months ago Closed 6 months ago

Consider dropping support for GTK_DECORATION_SYSTEM

Categories

(Core :: Widget: Gtk, task)

task

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug, Regressed 3 open bugs)

Details

Attachments

(1 file)

Client seems to work fine ~everywhere, and SYSTEM has some weird overdrawing on window corners, so I think we should do it if we can.

I tested client all the way back to Ubuntu 18 LTS and seems to work
fine, any reason not to try this?

This fixes some weird overdrawing on the window corners on GNOME+X11.

I tried that before and hit issues so reverted it....we can reconsider that but better after 99 freeze to bake it in nightly.

Another unfortunate thing is that mozilla testsuite is running with GTK_DECORATION_NONE. The testsuite fails with GTK_DECORATION_CLIENT.
( see Bug 1681886 Bug 1431429)

GTK_DECORATION_CLIENT has one side effect - when GTK_DECORATION_CLIENT is set on we reparent mContainer widget. That leads to unrealize / unmap calls on mContainer and another map of mContainer which is generally a bug Bug 1754711. We may end up with GtkCompositorWidget & wrong XWindow. So we may want to fix Bug 1754711 (recreate GtkCompositorWidget internals and its GL context).

meta bug: bug 1283299
MOZ_GTK_TITLEBAR_DECORATION=client causes bug 1502519/bug 1743255, maybe also bug 1743254.
Is Gtk double buffering not disabled everywhere (bug 1502519 comment 27)?

Type: defect → enhancement
Type: enhancement → task

Just wondering - is Gnome with the CSD the only desktop in the world ? Even Chrome has an option to switch it off. So far it seems still possible to have nice looking oldschool window decorations instead of ugly gnomish CSD, but name of the bug looks scary.

This is not changing / removing the titlebar checkbox, it's only unifying how it's implemented.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/498e0e6f9b19
Consider using client decorations everywhere. r=stransky
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
Blocks: gtktitlebar
Regressions: 1771914
Regressions: 1781262
You need to log in before you can comment on or make changes to this bug.