1772018 - Tooltips are difficult to see

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[nrieck]

Since Version 101 tooltips on Windows are difficult to see. Not only do they look alien compared to OS tooltips, but they have worse contrast and don't stand out. They also lack shadows, which isn't a new bug, but makes the result even worse.

Comment 1

[Hani Yacoub, Desktop QA]

Could you please provide more details maybe with a screenshot to make it more clear for me to understand the issue?
Thanks.

Comment 2

[nrieck]

Found another comment for the same problem. See the screenshots here for a comparison: https://bugzilla.mozilla.org/show_bug.cgi?id=1765423#c18 and https://bugzilla.mozilla.org/show_bug.cgi?id=1765423#c19

Comment 3

[Dão Gottwald [:dao]]

Emilio, how about we make the border more pronounced and the text fully black? Was there some particular reason for tuning them down?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I didn't tune them down, I just used the menu colors, but sure happy to adjust.

I guess menus are bigger so they are more distinguishable... Do you have any particular colors I should crib from? Generally I prefer not making up colors :)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1765423

Comment 6

[Dão Gottwald [:dao]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

I didn't tune them down, I just used the menu colors,

Ah, I forgot about that and apparently even missed the comment in tooltip.css...

I guess menus are bigger so they are more distinguishable...

Yeah, I think that's fair.

Do you have any particular colors I should crib from? Generally I prefer not making up colors :)

I would recommend we make the text fully black or white, respectively. Perhaps we can just take that color to the border as well, as done in the fallback styling? If that looks too stark, my next try would be to go to the middle between #cfcfd8 and black, so something like #67676C. No need to overthink this, feel free to just make something up that feels better than the status quo, and we can always tweak it further later if needed.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1772018 - Tweak tooltip colors on Windows. r=dao

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e2af6833a15
Tweak tooltip colors on Windows. r=dao

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0e2af6833a15

Comment 11

[Pascal Chevrel:pascalc]

Emilio, do we want to uplift this color tweak in a 102 dot release and ESR102? Thanks

Comment 12

[Ardelean Oana, Desktop QA [:oardelean]]

I managed to reproduce this issue on Firefox 102.0(build ID: 20220623063721) on Windows 10 64-bits. Verified as fixed on Firefox 103.0b4(build ID: 20220703190044) and Nightly 104.0a1(build ID: 20220703213709) on Windows 10 64-bits.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9281513 [details]
Bug 1772018 - Tweak tooltip colors on Windows. r=dao

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Minor and simple color tweak to improve contrast.
• User impact if declined:
• Fix Landed on Version: 103
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS change.

Beta/Release Uplift Approval Request

• User impact if declined: See above.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS tweak.
• String changes made/needed: none
• Is Android affected?: No

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9281513 [details]
Bug 1772018 - Tweak tooltip colors on Windows. r=dao

Approved for 102.0.1, thanks.

Comment 15

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/a7294bfb4371

Comment 16

[Ardelean Oana, Desktop QA [:oardelean]]

Hello,
I confirm this issue is fixed on Firefox 102.0.1(build ID: 20220705093820) on Windows 10.

Comment 17

[Donal Meehan [:dmeehan|PTO Sept 22-Oct 3]]

Comment on attachment 9281513 [details]
Bug 1772018 - Tweak tooltip colors on Windows. r=dao

Approved for 102.1esr.

Comment 18

[Donal Meehan [:dmeehan|PTO Sept 22-Oct 3]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/5686e25969b9

Comment 19

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-esr102/rev/1ab3ecdf6853fb04a4cd5b8cf65ff07d69fdaab3 FIREFOX_ESR_102_0_X_RELBRANCH

Comment 20

[Ardelean Oana, Desktop QA [:oardelean]]

Hello,
I confirm this fix is verified on Firefox 102.0.1esr(build ID: 20220711174428) on Windows 10.