Closed Bug 1772313 Opened 2 months ago Closed 2 months ago

Stop lazy loading Services.jsm

Categories

(Core :: XPConnect, task)

task

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Regressed 1 open bug)

Details

Attachments

(10 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

Services.jsm has been lazily loaded because it had dependency to XPCOMUtils,
but now it's just a stub for native implementation and it's already loaded eagaly in several places anyway.

Blocks: 1772351
No longer blocks: 1772351
Blocks: 1608279
No longer blocks: esm-ification
See Also: → 1772358
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
See Also: → 1772482
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/4a8b3ba193dc
Part 1: Remove duplicate lazy getter vs import in toolkit/components/glean/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/2eaa68f10b19
Part 2: Remove duplicate lazy getter vs import in toolkit/components/osfile/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/575fb877c56c
Part 3: Remove duplicate lazy getter vs import in toolkit/components/search/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/74c59f9fd51c
Part 4: Remove duplicate lazy getter vs import in toolkit/components/telemetry/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/302ac54741f8
Part 5: Stop calling ChromeUtils.defineModuleGetter for Services. r=kmag,webcompat-reviewers,pip-reviewers,denschub,mhowell
https://hg.mozilla.org/integration/autoland/rev/4378e519a8e7
Part 6: Stop calling ChromeUtils.defineModuleGetter for Services, in services/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/aad8efac9d05
Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/ab60885a8a93
Part 8: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in mobile/. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/59a33598ff51
Part 9: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in services/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/b389e7654771
Part 10: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in intl/. r=kmag

Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d90d31e6e0abf093d7efd26bd45df7103ac6e71d

Push with failures

Failure log

Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/fb358574e0f5
Part 1: Remove duplicate lazy getter vs import in toolkit/components/glean/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/b273123fdc5e
Part 2: Remove duplicate lazy getter vs import in toolkit/components/osfile/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/575cfebbd4aa
Part 3: Remove duplicate lazy getter vs import in toolkit/components/search/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/158da673907a
Part 4: Remove duplicate lazy getter vs import in toolkit/components/telemetry/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/ed175658d893
Part 5: Stop calling ChromeUtils.defineModuleGetter for Services. r=kmag,webcompat-reviewers,pip-reviewers,denschub,mhowell
https://hg.mozilla.org/integration/autoland/rev/9b602478adac
Part 6: Stop calling ChromeUtils.defineModuleGetter for Services, in services/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/b812444da6bf
Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/ec7c1c45f410
Part 8: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in mobile/. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/15e075a4b30a
Part 9: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in services/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/17616fa13c34
Part 10: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in intl/. r=kmag
Regressions: 1772798
Flags: needinfo?(arai.unmht)
You need to log in before you can comment on or make changes to this bug.