1772313 - Stop lazy loading Services.jsm

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Tooru Fujisawa [:arai]]

Services.jsm has been lazily loaded because it had dependency to XPCOMUtils,
but now it's just a stub for native implementation and it's already loaded eagaly in several places anyway.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772313 - Part 1: Remove duplicate lazy getter vs import in toolkit/components/glean/. r?kmag

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772313 - Part 2: Remove duplicate lazy getter vs import in toolkit/components/osfile/. r?kmag

Depends on D148154

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772313 - Part 3: Remove duplicate lazy getter vs import in toolkit/components/search/. r?kmag

Depends on D148155

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772313 - Part 4: Remove duplicate lazy getter vs import in toolkit/components/telemetry/. r?kmag

Depends on D148156

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772313 - Part 5: Stop calling ChromeUtils.defineModuleGetter for Services. r?kmag

Depends on D148157

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772313 - Part 6: Stop calling ChromeUtils.defineModuleGetter for Services, in services/. r?kmag

Depends on D148158

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r?kmag

Depends on D148159

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772313 - Part 8: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in mobile/. r?kmag

Depends on D148160

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772313 - Part 9: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in services/. r?kmag

Depends on D148161

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772313 - Part 10: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in intl/. r?kmag

Depends on D148162

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a8b3ba193dc
Part 1: Remove duplicate lazy getter vs import in toolkit/components/glean/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/2eaa68f10b19
Part 2: Remove duplicate lazy getter vs import in toolkit/components/osfile/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/575fb877c56c
Part 3: Remove duplicate lazy getter vs import in toolkit/components/search/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/74c59f9fd51c
Part 4: Remove duplicate lazy getter vs import in toolkit/components/telemetry/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/302ac54741f8
Part 5: Stop calling ChromeUtils.defineModuleGetter for Services. r=kmag,webcompat-reviewers,pip-reviewers,denschub,mhowell
https://hg.mozilla.org/integration/autoland/rev/4378e519a8e7
Part 6: Stop calling ChromeUtils.defineModuleGetter for Services, in services/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/aad8efac9d05
Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/ab60885a8a93
Part 8: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in mobile/. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/59a33598ff51
Part 9: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in services/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/b389e7654771
Part 10: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in intl/. r=kmag

Comment 12

[Sandor Molnar]

Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d90d31e6e0abf093d7efd26bd45df7103ac6e71d

Push with failures

Failure log

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb358574e0f5
Part 1: Remove duplicate lazy getter vs import in toolkit/components/glean/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/b273123fdc5e
Part 2: Remove duplicate lazy getter vs import in toolkit/components/osfile/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/575cfebbd4aa
Part 3: Remove duplicate lazy getter vs import in toolkit/components/search/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/158da673907a
Part 4: Remove duplicate lazy getter vs import in toolkit/components/telemetry/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/ed175658d893
Part 5: Stop calling ChromeUtils.defineModuleGetter for Services. r=kmag,webcompat-reviewers,pip-reviewers,denschub,mhowell
https://hg.mozilla.org/integration/autoland/rev/9b602478adac
Part 6: Stop calling ChromeUtils.defineModuleGetter for Services, in services/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/b812444da6bf
Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/ec7c1c45f410
Part 8: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in mobile/. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/15e075a4b30a
Part 9: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in services/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/17616fa13c34
Part 10: Stop calling XPCOMUtils.defineLazyModuleGetters for Services in intl/. r=kmag

Comment 14

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/fb358574e0f5
https://hg.mozilla.org/mozilla-central/rev/b273123fdc5e
https://hg.mozilla.org/mozilla-central/rev/575cfebbd4aa
https://hg.mozilla.org/mozilla-central/rev/158da673907a
https://hg.mozilla.org/mozilla-central/rev/ed175658d893
https://hg.mozilla.org/mozilla-central/rev/9b602478adac
https://hg.mozilla.org/mozilla-central/rev/b812444da6bf
https://hg.mozilla.org/mozilla-central/rev/ec7c1c45f410
https://hg.mozilla.org/mozilla-central/rev/15e075a4b30a
https://hg.mozilla.org/mozilla-central/rev/17616fa13c34