1772360 - Stop calling XPCOMUtils.defineLazyGlobalGetters for always available symbols

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Tooru Fujisawa [:arai]]

In some case, XPCOMUtils.defineLazyGlobalGetters is called for symbol that's always avaialble in the shared module global.

Comment 1

[Tooru Fujisawa [:arai]]

symbols used there, and it's always available from the beginning:

• AbortController
• Blob
• CSS
• ChannelWrapper
• DOMParser
• Element
• EventTarget
• File
• FileReader
• FormData
• Headers
• InspectorUtils
• NodeFilter
• Request
• TextDecoder
• TextEncoder
• URL
• URLSearchParams
• XMLHttpRequest
• XMLSerializer
• btoa

symbols used there, and not available:

• crypto
• fetch
• indexedDB

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r?florian

Depends on D148167

Comment 3

[Tooru Fujisawa [:arai]]

Just realized that I removed occurrences in non-JSM, and that wasn't correct.
I'll revert partially

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8b0a2ed239e
Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo

Comment 5

[Sandor Molnar[:smolnar]]

Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d90d31e6e0abf093d7efd26bd45df7103ac6e71d

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f35b0fca8a4e
Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo

Comment 7

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/f35b0fca8a4e