Closed Bug 1772360 Opened 2 months ago Closed 2 months ago

Stop calling XPCOMUtils.defineLazyGlobalGetters for always available symbols

Categories

(Core :: XPConnect, task)

task

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In some case, XPCOMUtils.defineLazyGlobalGetters is called for symbol that's always avaialble in the shared module global.

symbols used there, and it's always available from the beginning:

  • AbortController
  • Blob
  • CSS
  • ChannelWrapper
  • DOMParser
  • Element
  • EventTarget
  • File
  • FileReader
  • FormData
  • Headers
  • InspectorUtils
  • NodeFilter
  • Request
  • TextDecoder
  • TextEncoder
  • URL
  • URLSearchParams
  • XMLHttpRequest
  • XMLSerializer
  • btoa

symbols used there, and not available:

  • crypto
  • fetch
  • indexedDB
See Also: → 1608282
See Also: → 1772480

Just realized that I removed occurrences in non-JSM, and that wasn't correct.
I'll revert partially

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/c8b0a2ed239e
Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo

Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d90d31e6e0abf093d7efd26bd45df7103ac6e71d

Push with failures

Failure log

Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/f35b0fca8a4e
Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Flags: needinfo?(arai.unmht)
You need to log in before you can comment on or make changes to this bug.