1772321 - 56.51 - 31.02% ts_paint_webext / startup_about_home_paint + 14 more (OSX) regression on Thu May 26 2022

Status: RESOLVED WONTFIX

(Core :: Widget: Cocoa, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a talos performance regression from push c8d9ed133a435e0bdda96c27a3175436192cb510. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
57%	ts_paint_webext	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	526.42 -> 823.92
55%	ts_paint_webext	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	521.04 -> 807.00
52%	ts_paint	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	532.00 -> 809.17
50%	sessionrestore_many_windows	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	564.33 -> 844.75
49%	sessionrestore	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	564.42 -> 840.25
47%	sessionrestore_no_auto_restore	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	581.25 -> 855.58
40%	ts_paint	macosx1015-64-shippable-qr	e10s fission stylo webrender	724.25 -> 1,016.33
39%	startup_about_home_paint_cached	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	726.50 -> 1,009.25
39%	ts_paint_webext	macosx1015-64-shippable-qr	e10s fission stylo webrender	746.58 -> 1,035.75
38%	sessionrestore_no_auto_restore	macosx1015-64-shippable-qr	e10s fission stylo webrender	772.58 -> 1,065.50
...	...	...	...	...
36%	startup_about_home_paint	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	746.50 -> 1,014.75
36%	sessionrestore_many_windows	macosx1015-64-shippable-qr	e10s fission stylo webrender	772.83 -> 1,050.33
32%	startup_about_home_paint_realworld_webextensions	macosx1015-64-shippable-qr	e10s fission stylo webrender	956.33 -> 1,260.92
31%	startup_about_home_paint_cached	macosx1015-64-shippable-qr	e10s fission stylo webrender	930.17 -> 1,222.25
31%	startup_about_home_paint	macosx1015-64-shippable-qr	e10s fission stylo webrender	935.75 -> 1,226.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Stephen A Pohl [:spohl]]

Markus, just wanted to confirm that this is what we were expecting to see. Is there anything concerning jumping out at you?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1696504

Comment 3

[Markus Stange [:mstange]]

(In reply to Stephen A Pohl [:spohl] (OOO until 6/22) from comment #1)

Markus, just wanted to confirm that this is what we were expecting to see. Is there anything concerning jumping out at you?

It looks pretty similar to the regressions we got the first time around, in bug 1743409.

So I'm going to wontfix this bug with the same justification as last time:

(In reply to Markus Stange [:mstange] from bug 1743409 comment #14)

Given that we cannot reproduce a performance regression locally, and given that the test machines which show the regression are running an old version of macOS, I am wontfixing this bug. The SDK switch is unavoidable. If there are startup improvements we can make, we should choose what to optimize based on profiling results from a modern versions of macOS.

Comment 4

[Markus Stange [:mstange]]

For future reference, here's a set of before/after profiles for ts_paint_webext.
Before: https://share.firefox.dev/39vXPCg
After: https://share.firefox.dev/3b29LMu

The differences are all under font stuff. 120ms -[NSButtonCell _convertToText:], 60ms gfxUserFontSet::gfxUserFontSet, 90ms gfxMacPlatformFontList::InitSharedFontListForPlatform.