1772404 - Allow corner snapping for Windows and Linux

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P1)

Description

[Niklas Baumgardner [:niklas]]

PiP windows can be snapped to the corner on mac. We should be able to do this on Windows and Linux too.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Setting to P1 since there's an active assignee.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1772404 - Corner snapping for Windows and Linux. r=#pip-reviewers!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D151162	Bug 1772404 - Corner snapping for Windows and Linux. r=#pip-reviewers!	niklas	mhowell: Back Jan 3, 2023

:niklas, could you please find another reviewer?

For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/739b182f1451
Corner snapping for Windows and Linux. r=mhowell,mconley

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/739b182f1451

Comment 8

[Dianna Smith [:diannaS]]

:niklas do you want to include this in the fx120 release notes?

Comment 9

[Ania]

Hi Dianna!
Yes, it would be great to include it in the release notes in 120.

Release Note Request (optional, but appreciated)
Hi!
[Why is this notable]: A small handy improvement that saves users a long annoying corner dragging movement, especially on larger screns.

[Suggested wording]: You asked, and we listened. Picture-in-Picture now supports corner snapping on Windows and Linux - just hold Ctrl as you move the PiP window.
[Links (documentation, blog post, etc)]:

Comment 10

[Dianna Smith [:diannaS]]

Added to 120 nightly release notes ( https://www.mozilla.org/en-US/firefox/120.0a1/releasenotes/)