177242 - Mozilla and Phoenix crash in Print Preview if typeaheadfind is enabled and I start typing a search string

Status: RESOLVED FIXED

(SeaMonkey :: Find In Page, defect, P1)

Description

[Manoj]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021021 Phoenix/0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021021 Phoenix/0.3

Print Preview crashes the browser (DrWatson starts generating an error message)
if typeaheadfind has been enabled and I start typing. 

Reproducible: Always

Steps to Reproduce:
1. Ensure that typeaheadfind is enabled (it is by default) 
2. Open url - www.nytimes.com <could be any other>
3. Print Preview
4. Type some characters

Actual Results:  
The browser crashed

Expected Results:  
Anything but crash. It should ignore typeaheadfind during print preview as a
first solution to the problem

Comment 1

[Thomas Leineweber]

It does not crash for me (Solaris 2.6), but disabling typeaheadfind during print
preview sounds reasonable for me.

Comment 2

[Chris Lyon]

Manoj, please enable Talkbacka nd include the talkback id in this bug report.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Typeaheadfind has code like:

2141   doc->GetShellAt(0, getter_AddRefs(presShell));

which _already_ will not work in print preview, where the shell at 0 does not in
fact exist, iirc.  So yes, typeaheadfind should be disabled in print preview.

Comment 4

[Aaron Leventhal]

Right, typeaheadfind needs to detect print preview and disable itself then.

Comment 5

[rods (gone)]

You can QI for nsIPrintPreviewContext from the prescontext

Comment 6

[Aaron Leventhal]

Attachment: Don't activate typeaheadfind when print preview is open

Seeking r=/sr=

Comment 7

[Kyle Yuan]

Comment on attachment 104530 [details] [diff] [review]
Don't activate typeaheadfind when print preview is open

r=kyle

Comment 8

[Alec Flett]

Comment on attachment 104530 [details] [diff] [review]
Don't activate typeaheadfind when print preview is open

comments please! Explain why you're bailing early.

sr=alecf

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 104530 [details] [diff] [review]
Don't activate typeaheadfind when print preview is open

a=roc+moz for trunk

Comment 10

[Aaron Leventhal]

checked in