1772503 - BUG: Conflict between DisableFirefoxStudies and UserMessaging policies

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[Heiko]

Attachment: conflict.png

Steps to reproduce:

I found two bugs:

• The policies for DisableFirefoxStudies and UserMessaging (ExtensionRecommendations, FeatureRecommendations) conflicting.

If you set the policy DisableFirefoxStudies the ui elements for the following settings are unchecked and looked:

• Settings UI > General > Browsing > Recommend extensions as you browse
• Settings UI > General > Browsing > Recommend features as you browse

If you the disable the policies for ExtensionRecommendations and FeatureRecommendations the ui settings aren't looked anymore. It is even possible to enable the settings regardless of the state of DisableFirefoxStudies.

Note: We configure the policies using Active Directory GPOs.
FF 91.10.0esr; ADMX v3.10

Comment 1

[Heiko]

Attachment: disable studies.png

Comment 2

[Heiko]

Github-Issue: https://github.com/mozilla/policy-templates/issues/914

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mkaply, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Rares Doghi, Desktop QA]

I was able to reproduce this issue on my end as well, Setting those prefs in the policies.json file will unlock the extensions and feature recommendations.

Comment 5

[Rares Doghi, Desktop QA]

I think there is only one issue here, the conflict between DisableFirefoxStudies and UserMessaging (ExtensionRecommendations, FeatureRecommendations) are causing the Extension and Feature Recommendations to uncheck and unlock. I will mark Bug 1772504 as a duplicate for this issue since that the same thing is causing it, but please feel free to reopen that one if these are indeed 2 separate issues.

Comment 7

[Mike Kaply [:mkaply]]

For this bug, what I'm going to do is add code to our policy code that if something is already locked, another policy can't unlock it.

Comment 8

[Mike Kaply [:mkaply]]

Attachment: Bug 1772503 - Keep policy locked preferences locked. r?mhowell

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/208ba0efbefb
Keep policy locked preferences locked. r=mhowell

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures in netwerk/test/unit/test_trr_enterprise_policy.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/272d7188fe71c94facdcd15027c7b5385863315f

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_trr_enterprise_policy.js | test_enterprise_policy_unlocked - [test_enterprise_policy_unlocked : 77] true == false

Comment 11

[Mike Kaply [:mkaply]]

Didn't realize there was a test for this elsewhere. Fix ready, running on try to see if there is anything else.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81ee49e2175e
Keep policy locked preferences locked. r=mhowell,necko-reviewers,kershaw

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/81ee49e2175e

Comment 14

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest build 116.0a1 (2023-06-21). Updating the remaining flags.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mkaply, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 16

[Mike Kaply [:mkaply]]

Comment on attachment 9339309 [details]
Bug 1772503 - Keep policy locked preferences locked. r?mhowell

Beta/Release Uplift Approval Request

• User impact if declined: Some policies can stomp on each other.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, automated test, tested by QA

Main reason I want this is it will make ESR 115 merges easier.

• String changes made/needed:
• Is Android affected?: No

Comment 17

[Donal Meehan [:dmeehan]]

Comment on attachment 9339309 [details]
Bug 1772503 - Keep policy locked preferences locked. r?mhowell

Approved for 115.0 RC1.

Comment 18

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/025e8bacef88

Comment 19

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Beta 115.0b10