1772568 - Assertion failure: mSegment (null segment), at /ipc/glue/Shmem.cpp:260

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P3)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev 2f53c261903e (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build 2f53c261903e --debug --fuzzing -n firefox
$ GNOME_ACCESSIBILITY=1 python -m grizzly.replay ./firefox/firefox testcase.html

Assertion failure: mSegment (null segment), at /ipc/glue/Shmem.cpp:260

    ==843195==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7fcabd00b713 bp 0x7ffcb481aa50 sp 0x7ffcb481aa40 T843195)
    ==843195==The signal is caused by a WRITE memory access.
    ==843195==Hint: address points to the zero page.
        #0 0x7fcabd00b713 in mozilla::ipc::Shmem::AssertInvariants() const /ipc/glue/Shmem.cpp:260:3
        #1 0x7fcabd00b7dd in mozilla::ipc::Shmem::RevokeRights(mozilla::ipc::Shmem::PrivateIPDLCaller) /ipc/glue/Shmem.cpp:274:3
        #2 0x7fcabd00cb84 in mozilla::ipc::IPDLParamTraits<mozilla::ipc::Shmem>::Write(IPC::MessageWriter*, mozilla::ipc::IProtocol*, mozilla::ipc::Shmem&&) /ipc/glue/Shmem.cpp:455:10
        #3 0x7fcabf818b93 in Write<mozilla::ipc::Shmem> /ipc/chromium/src/chrome/common/ipc_message_utils.h:317:5
        #4 0x7fcabf818b93 in WriteParam<mozilla::ipc::Shmem> /ipc/chromium/src/chrome/common/ipc_message_utils.h:293:3
        #5 0x7fcabf818b93 in mozilla::webgpu::PWebGPUChild::SendBufferUnmap(unsigned long const&, mozilla::ipc::Shmem&&, bool const&, bool const&) /builds/worker/workspace/obj-build/ipc/ipdl/PWebGPUChild.cpp:500:5
        #6 0x7fcabf7ea53f in UnmapBuffer /dom/webgpu/Device.cpp:196:14
        #7 0x7fcabf7ea53f in mozilla::webgpu::Buffer::Unmap(JSContext*, mozilla::ErrorResult&) /dom/webgpu/Buffer.cpp:197:12
        #8 0x7fcabed53396 in mozilla::dom::GPUBuffer_Binding::unmap(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/WebGPUBinding.cpp:11889:24
        #9 0x7fcabf3b1fcc in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /dom/bindings/BindingUtils.cpp:3271:13
        #10 0x7fcac4846980 in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) /js/src/vm/Interpreter.cpp:420:13
        #11 0x7fcac484618a in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:507:12
        #12 0x7fcac483d566 in CallFromStack /js/src/vm/Interpreter.cpp:578:10
        #13 0x7fcac483d566 in Interpret(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:3314:16
        #14 0x7fcac4834802 in js::RunScript(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:389:13
        #15 0x7fcac4846086 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:539:13
        #16 0x7fcac48476b8 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:605:8
        #17 0x7fcac3511f21 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /js/src/vm/CallAndConstruct.cpp:117:10
        #18 0x7fcabf16d220 in mozilla::dom::Function::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, nsTArray<JS::Value> const&, JS::MutableHandle<JS::Value>, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/FunctionBinding.cpp:50:8
        #19 0x7fcabdf2fd12 in void mozilla::dom::Function::Call<nsCOMPtr<nsIGlobalObject> >(nsCOMPtr<nsIGlobalObject> const&, nsTArray<JS::Value> const&, JS::MutableHandle<JS::Value>, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/FunctionBinding.h:71:12
        #20 0x7fcabdf2fab4 in mozilla::dom::CallbackTimeoutHandler::Call(char const*) /dom/base/TimeoutHandler.cpp:167:29
        #21 0x7fcabdc0e702 in nsGlobalWindowInner::RunTimeoutHandler(mozilla::dom::Timeout*, nsIScriptContext*) /dom/base/nsGlobalWindowInner.cpp:6409:38
        #22 0x7fcabdf418fa in mozilla::dom::TimeoutManager::RunTimeout(mozilla::TimeStamp const&, mozilla::TimeStamp const&, bool) /dom/base/TimeoutManager.cpp:903:44
        #23 0x7fcabdf2d610 in mozilla::dom::TimeoutExecutor::MaybeExecute() /dom/base/TimeoutExecutor.cpp:179:11
        #24 0x7fcabdf2dbb9 in Notify /dom/base/TimeoutExecutor.cpp:246:5
        #25 0x7fcabdf2dbb9 in non-virtual thunk to mozilla::dom::TimeoutExecutor::Notify(nsITimer*) /dom/base/TimeoutExecutor.cpp
        #26 0x7fcabc44117c in operator() /xpcom/threads/nsTimerImpl.cpp:656:44
        #27 0x7fcabc44117c in matchN<mozilla::Variant<nsTimerImpl::UnknownCallback, nsCOMPtr<nsITimerCallback>, nsCOMPtr<nsIObserver>, nsTimerImpl::FuncCallback, nsTimerImpl::ClosureCallback> &, (lambda at /xpcom/threads/nsTimerImpl.cpp:656:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:657:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:660:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:661:7)> /builds/worker/workspace/obj-build/dist/include/mozilla/Variant.h:309:16
        #28 0x7fcabc44117c in matchN<mozilla::Variant<nsTimerImpl::UnknownCallback, nsCOMPtr<nsITimerCallback>, nsCOMPtr<nsIObserver>, nsTimerImpl::FuncCallback, nsTimerImpl::ClosureCallback> &, (lambda at /xpcom/threads/nsTimerImpl.cpp:655:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:656:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:657:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:660:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:661:7)> /builds/worker/workspace/obj-build/dist/include/mozilla/Variant.h:318:14
        #29 0x7fcabc44117c in matchN<mozilla::Variant<nsTimerImpl::UnknownCallback, nsCOMPtr<nsITimerCallback>, nsCOMPtr<nsIObserver>, nsTimerImpl::FuncCallback, nsTimerImpl::ClosureCallback> &, (lambda at /xpcom/threads/nsTimerImpl.cpp:655:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:656:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:657:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:660:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:661:7)> /builds/worker/workspace/obj-build/dist/include/mozilla/Variant.h:902:12
        #30 0x7fcabc44117c in match<(lambda at /xpcom/threads/nsTimerImpl.cpp:655:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:656:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:657:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:660:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:661:7)> /builds/worker/workspace/obj-build/dist/include/mozilla/Variant.h:857:12
        #31 0x7fcabc44117c in nsTimerImpl::Fire(int) /xpcom/threads/nsTimerImpl.cpp:654:22
        #32 0x7fcabc4129ee in nsTimerEvent::Run() /xpcom/threads/TimerThread.cpp:263:11
        #33 0x7fcabc431c1d in mozilla::ThrottledEventQueue::Inner::ExecuteRunnable() /xpcom/threads/ThrottledEventQueue.cpp:254:22
        #34 0x7fcabc42e501 in mozilla::ThrottledEventQueue::Inner::Executor::Run() /xpcom/threads/ThrottledEventQueue.cpp:81:15
        #35 0x7fcabc42f55e in mozilla::RunnableTask::Run() /xpcom/threads/TaskController.cpp:475:16
        #36 0x7fcabc409f13 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:788:26
        #37 0x7fcabc408ac3 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:620:15
        #38 0x7fcabc408d33 in mozilla::TaskController::ProcessPendingMTTask(bool) /xpcom/threads/TaskController.cpp:398:36
        #39 0x7fcabc432d59 in operator() /xpcom/threads/TaskController.cpp:127:37
        #40 0x7fcabc432d59 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_1>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:531:5
        #41 0x7fcabc41e7bf in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1180:16
        #42 0x7fcabc424dbd in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:465:10
        #43 0x7fcabcfe7064 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:107:5
        #44 0x7fcabcf0e1c7 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:380:10
        #45 0x7fcabcf0e0d2 in RunHandler /ipc/chromium/src/base/message_loop.cc:373:3
        #46 0x7fcabcf0e0d2 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:355:3
        #47 0x7fcac114ddf8 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:137:27
        #48 0x7fcac328c17b in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:875:20
        #49 0x7fcabcfe7faa in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:235:9
        #50 0x7fcabcf0e1c7 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:380:10
        #51 0x7fcabcf0e0d2 in RunHandler /ipc/chromium/src/base/message_loop.cc:373:3
        #52 0x7fcabcf0e0d2 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:355:3
        #53 0x7fcac328b79c in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:734:34
        #54 0x562f44774f60 in content_process_main /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #55 0x562f44774f60 in main /browser/app/nsBrowserApp.cpp:338:18
        #56 0x7fcad2dcb082 in __libc_start_main /build/glibc-SzIz7B/glibc-2.31/csu/../csu/libc-start.c:308:16
        #57 0x562f4474ad0c in _start (/home/jkratzer/builds/mc-debug/firefox-bin+0x15d0c) (BuildId: 133b6fa9e3c11dc0f9c98e9989cac1e3f5e92ac3)
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /ipc/glue/Shmem.cpp:260:3 in mozilla::ipc::Shmem::AssertInvariants() const
    ==843195==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Mayank Bansal]

https://crash-stats.mozilla.org/report/index/fe6046e2-e6c5-42b8-b128-8241d0220603

Comment 3

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220603155506-68727ef04ccf.
The bug appears to have been introduced in the following build range:

Start: 1f856a88914ab02d164fd47e334b03848dae2049 (20210818155306)
End: cfb323870af4cbe082a6e01d3c20786a61165585 (20210818145907)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1f856a88914ab02d164fd47e334b03848dae2049&tochange=cfb323870af4cbe082a6e01d3c20786a61165585

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimb, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Nicolas Silva [:nical]]

Will be fixed by bug 1777535.

Comment 6

[Nicolas Silva [:nical]]

Doesn't reproduce anymore for me.

Comment 7

[Nicolas Silva [:nical]]

The test case sometimes triggers another issue (related to large binding indices) that will be fixed in the next wgpu update.

Comment 8

[Jim Blandy :jimb]

Jason, could you confirm this fix for us? Thanks!

Comment 9

[Jason Kratzer [:jkratzer]]

Bugmon Analysis
Testcase crashes using the initial build (mozilla-central 20220603093350-2f53c261903e) but not with tip (mozilla-central 20220829094551-ad01d1ce5556.)

The bug appears to have been fixed in the following build range:

Start: 880cac21dca544a25fa34b5d0c6599d0fd240c17 (20220810143834)
End: bdb42cfe62138374343d5be83ac208826812cd2d (20220810161147)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=880cac21dca544a25fa34b5d0c6599d0fd240c17&tochange=bdb42cfe62138374343d5be83ac208826812cd2d

nical, can you confirm that the above bisection range is responsible for fixing this issue?
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 10

[Jason Kratzer [:jkratzer]]

Removing NI as :nical already stated in comment #5 that this was fixed by bug 1777535.